Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UriComponentsBuilder copies query params through MultiValueMap.addAll

Browse Source 
Issue: SPR-17256
This commit is contained in:
Juergen Hoeller
2018-09-10 11:31:37 +02:00
parent e49896d95f
commit c06b9525ac
3 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java
View File

@@ -705,7 +705,7 @@ public class UriComponentsBuilder implements UriBuilder, Cloneable {
@Override
public UriComponentsBuilder queryParams(@Nullable MultiValueMap<String, String> params) {
if (params != null) {
this.queryParams.putAll(params);
this.queryParams.addAll(params);
}
return this;
}

7
spring-web/src/test/java/org/springframework/web/util/UriComponentsBuilderTests.java
View File

@@ -922,4 +922,11 @@ public class UriComponentsBuilderTests {
assertNotEquals(uri1, uri2);
}
@Test // SPR-17256
public void uriComponentsWithQueryParamClone() {
UriComponentsBuilder.fromUriString("http://localhost:8081")
.uriComponents(UriComponentsBuilder.fromUriString("/{path}?sort={sort}").build())
.queryParam("sort", "another_value").build();
}
}