Unwrap Optional for @RequestParam reverse resolution
Closes gh-22656
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2012-2018 the original author or authors.
|
||||
* Copyright 2012-2019 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@@ -23,6 +23,7 @@ import java.lang.annotation.RetentionPolicy;
|
||||
import java.lang.annotation.Target;
|
||||
import java.util.Arrays;
|
||||
import java.util.List;
|
||||
import java.util.Optional;
|
||||
import javax.servlet.http.HttpServletRequest;
|
||||
|
||||
import org.hamcrest.Matchers;
|
||||
@@ -264,6 +265,15 @@ public class MvcUriComponentsBuilderTests {
|
||||
assertThat(uriComponents.toUriString(), is("http://localhost/something/optional-param"));
|
||||
}
|
||||
|
||||
@Test // gh-22656
|
||||
public void fromMethodNameWithOptionalNamedParam() {
|
||||
UriComponents uriComponents = fromMethodName(ControllerWithMethods.class,
|
||||
"methodWithOptionalNamedParam", Optional.of("foo")).build();
|
||||
|
||||
assertThat(uriComponents.toUriString(),
|
||||
is("http://localhost/something/optional-param-with-name?search=foo"));
|
||||
}
|
||||
|
||||
@Test
|
||||
public void fromMethodNameWithMetaAnnotation() {
|
||||
UriComponents uriComponents = fromMethodName(MetaAnnotationController.class, "handleInput").build();
|
||||
@@ -533,6 +543,11 @@ public class MvcUriComponentsBuilderTests {
|
||||
HttpEntity<Void> methodWithOptionalParam(@RequestParam(defaultValue = "") String q) {
|
||||
return null;
|
||||
}
|
||||
|
||||
@GetMapping("/optional-param-with-name")
|
||||
HttpEntity<Void> methodWithOptionalNamedParam(@RequestParam("search") Optional<String> q) {
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user