From caaa86d6cf202fc2d07e7c8e327b19a3e0800500 Mon Sep 17 00:00:00 2001 From: Sam Brannen <104798+sbrannen@users.noreply.github.com> Date: Wed, 4 Sep 2024 17:30:16 +0200 Subject: [PATCH] Make AspectJ pointcut in test more robust The previous pointcut attempted to match against a local lambda type; however, that pointcut was unreliable and failed sporadically. This commit therefore changes the pointcut so that it specifically targets the get() method of a subtype of Supplier, which seems to result in reliable pointcut matching. --- .../aop/aspectj/autoproxy/AspectJAutoProxyCreatorTests.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spring-context/src/test/java/org/springframework/aop/aspectj/autoproxy/AspectJAutoProxyCreatorTests.java b/spring-context/src/test/java/org/springframework/aop/aspectj/autoproxy/AspectJAutoProxyCreatorTests.java index 64f670650c..16da2ef070 100644 --- a/spring-context/src/test/java/org/springframework/aop/aspectj/autoproxy/AspectJAutoProxyCreatorTests.java +++ b/spring-context/src/test/java/org/springframework/aop/aspectj/autoproxy/AspectJAutoProxyCreatorTests.java @@ -609,7 +609,7 @@ abstract class AbstractProxyTargetClassConfig { @Aspect static class SupplierAdvice { - @Around("execution(public * org.springframework.aop.aspectj.autoproxy..*.*(..))") + @Around("execution(* java.util.function.Supplier+.get())") Object aroundSupplier(ProceedingJoinPoint joinPoint) throws Throwable { return "advised: " + joinPoint.proceed(); }