Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary method.isAccessible() invocation

Browse Source 
Closes gh-32548
This commit is contained in:
Sébastien Deleuze
2024-03-28 11:50:29 +01:00
parent dc982d0d51
commit cf87441a26
6 changed files with 42 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-web/src/main/java/org/springframework/web/method/support/InvocableHandlerMethod.java
View File

@@ -305,7 +305,7 @@ public class InvocableHandlerMethod extends HandlerMethod {
if (function == null) {
return method.invoke(target, args);
}
if (method.isAccessible() && !KCallablesJvm.isAccessible(function)) {
if (!KCallablesJvm.isAccessible(function)) {
KCallablesJvm.setAccessible(function, true);
}
Map<KParameter, Object> argMap = CollectionUtils.newHashMap(args.length + 1);

11
spring-web/src/test/kotlin/org/springframework/web/method/support/InvocableHandlerMethodKotlinTests.kt
View File

@@ -84,6 +84,15 @@ class InvocableHandlerMethodKotlinTests {
Assertions.assertThat(value).isNull()
}
@Test
fun private() {
composite.addResolver(StubArgumentResolver(Float::class.java, 1.2f))
val value = getInvocable(Handler::class.java, Float::class.java).invokeForRequest(request, null)
Assertions.assertThat(getStubResolver(0).resolvedParameters).hasSize(1)
Assertions.assertThat(value).isEqualTo("1.2")
}
@Test
fun valueClass() {
composite.addResolver(StubArgumentResolver(Long::class.java, 1L))
@@ -182,6 +191,8 @@ class InvocableHandlerMethodKotlinTests {
return null
}
private fun private(value: Float) = value.toString()
}
private class ValueClassHandler {