Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary method.isAccessible() invocation

Browse Source 
Closes gh-32548
This commit is contained in:
Sébastien Deleuze
2024-03-28 11:50:29 +01:00
parent dc982d0d51
commit cf87441a26
6 changed files with 42 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/InvocableHandlerMethod.java
View File

@@ -318,7 +318,7 @@ public class InvocableHandlerMethod extends HandlerMethod {
if (function == null) {
return method.invoke(target, args);
}
if (method.isAccessible() && !KCallablesJvm.isAccessible(function)) {
if (!KCallablesJvm.isAccessible(function)) {
KCallablesJvm.setAccessible(function, true);
}
Map<KParameter, Object> argMap = CollectionUtils.newHashMap(args.length + 1);

15
spring-webflux/src/test/kotlin/org/springframework/web/reactive/result/InvocableHandlerMethodKotlinTests.kt
View File

@@ -112,11 +112,18 @@ class InvocableHandlerMethodKotlinTests {
@Test
fun privateController() {
this.resolvers.add(stubResolver("foo"))
val method = PrivateCoroutinesController::singleArg.javaMethod!!
val result = invoke(PrivateCoroutinesController(), method,"foo")
val method = PrivateController::singleArg.javaMethod!!
val result = invoke(PrivateController(), method,"foo")
assertHandlerResultValue(result, "success:foo")
}
@Test
fun privateFunction() {
val method = PrivateController::class.java.getDeclaredMethod("private")
val result = invoke(PrivateController(), method)
assertHandlerResultValue(result, "private")
}
@Test
fun defaultValue() {
this.resolvers.add(stubResolver(null, String::class.java))
@@ -330,12 +337,14 @@ class InvocableHandlerMethodKotlinTests {
}
}
private class PrivateCoroutinesController {
private class PrivateController {
suspend fun singleArg(q: String?): String {
delay(1)
return "success:$q"
}
private fun private() = "private"
}
class DefaultValueController {