Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Clean up warnings in tests

Browse Source
This commit is contained in:
Sam Brannen
2023-09-23 13:30:05 +02:00
parent ebd4f1b45b
commit d0a088f9dc
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-context/src/test/java/org/springframework/context/support/DefaultLifecycleProcessorTests.java
View File

@@ -48,6 +48,7 @@ class DefaultLifecycleProcessorTests {
Object lifecycleProcessor = new DirectFieldAccessor(context).getPropertyValue("lifecycleProcessor"); Object lifecycleProcessor = new DirectFieldAccessor(context).getPropertyValue("lifecycleProcessor");
assertThat(lifecycleProcessor).isNotNull(); assertThat(lifecycleProcessor).isNotNull();
assertThat(lifecycleProcessor.getClass()).isEqualTo(DefaultLifecycleProcessor.class); assertThat(lifecycleProcessor.getClass()).isEqualTo(DefaultLifecycleProcessor.class);
context.close();
} }
@Test @Test
@@ -63,6 +64,7 @@ class DefaultLifecycleProcessorTests {
assertThat(contextLifecycleProcessor).isSameAs(bean); assertThat(contextLifecycleProcessor).isSameAs(bean);
assertThat(new DirectFieldAccessor(contextLifecycleProcessor).getPropertyValue("timeoutPerShutdownPhase")) assertThat(new DirectFieldAccessor(contextLifecycleProcessor).getPropertyValue("timeoutPerShutdownPhase"))
.isEqualTo(1000L); .isEqualTo(1000L);
context.close();
} }
@Test @Test
@@ -122,6 +124,7 @@ class DefaultLifecycleProcessorTests {
.isThrownBy(context::refresh).withCauseInstanceOf(IllegalStateException.class); .isThrownBy(context::refresh).withCauseInstanceOf(IllegalStateException.class);
assertThat(bean.isRunning()).isFalse(); assertThat(bean.isRunning()).isFalse();
assertThat(startedBeans).hasSize(1); assertThat(startedBeans).hasSize(1);
context.close();
} }
@Test @Test
@@ -654,7 +657,7 @@ class DefaultLifecycleProcessorTests {
private static int getPhase(Lifecycle lifecycle) { private static int getPhase(Lifecycle lifecycle) {
return (lifecycle instanceof SmartLifecycle ? ((SmartLifecycle) lifecycle).getPhase() : 0); return (lifecycle instanceof SmartLifecycle smartLifecycle ? smartLifecycle.getPhase() : 0);
} }
@@ -718,7 +721,8 @@ class DefaultLifecycleProcessorTests {
return new TestSmartLifecycleBean(phase, shutdownDelay, null, stoppedBeans); return new TestSmartLifecycleBean(phase, shutdownDelay, null, stoppedBeans);
} }
private TestSmartLifecycleBean(int phase, int shutdownDelay, CopyOnWriteArrayList<Lifecycle> startedBeans, CopyOnWriteArrayList<Lifecycle> stoppedBeans) { private TestSmartLifecycleBean(int phase, int shutdownDelay, CopyOnWriteArrayList<Lifecycle> startedBeans,
CopyOnWriteArrayList<Lifecycle> stoppedBeans) {
super(startedBeans, stoppedBeans); super(startedBeans, stoppedBeans);
this.phase = phase; this.phase = phase;
this.shutdownDelay = shutdownDelay; this.shutdownDelay = shutdownDelay;