Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Test CollectionUtils.unmodifiableMultiValueMap only once

Browse Source 
No need to test that feature as a parameterized test.
This commit is contained in:
Sam Brannen
2023-08-26 14:44:07 +02:00
parent 31a07e6fbf
commit dac481da43
1 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
spring-core/src/test/java/org/springframework/util/MultiValueMapTests.java
View File

@@ -25,6 +25,7 @@ import java.util.List;
import java.util.Map;
import java.util.stream.Stream;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;
@@ -139,30 +140,31 @@ class MultiValueMapTests {
assertThat(map).isEqualTo(map2);
}
@ParameterizedMultiValueMapTest
void canNotChangeAnUnmodifiableMultiValueMap(MultiValueMap<String, String> map) {
MultiValueMap<String, String> asUnmodifiableMultiValueMap = CollectionUtils.unmodifiableMultiValueMap(map);
@Test
void canNotChangeAnUnmodifiableMultiValueMap() {
MultiValueMap<String, String> map = new LinkedMultiValueMap<>();
MultiValueMap<String, String> unmodifiableMap = CollectionUtils.unmodifiableMultiValueMap(map);
assertSoftly(softly -> {
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
.isThrownBy(() -> asUnmodifiableMultiValueMap.add("key", "value"));
.isThrownBy(() -> unmodifiableMap.add("key", "value"));
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
.isThrownBy(() -> asUnmodifiableMultiValueMap.addIfAbsent("key", "value"));
.isThrownBy(() -> unmodifiableMap.addIfAbsent("key", "value"));
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
.isThrownBy(() -> asUnmodifiableMultiValueMap.addAll("key", exampleListOfValues()));
.isThrownBy(() -> unmodifiableMap.addAll("key", exampleListOfValues()));
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
.isThrownBy(() -> asUnmodifiableMultiValueMap.addAll(exampleMultiValueMap()));
.isThrownBy(() -> unmodifiableMap.addAll(exampleMultiValueMap()));
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
.isThrownBy(() -> asUnmodifiableMultiValueMap.set("key", "value"));
.isThrownBy(() -> unmodifiableMap.set("key", "value"));
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
.isThrownBy(() -> asUnmodifiableMultiValueMap.setAll(exampleHashMap()));
.isThrownBy(() -> unmodifiableMap.setAll(exampleHashMap()));
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
.isThrownBy(() -> asUnmodifiableMultiValueMap.put("key", exampleListOfValues()));
.isThrownBy(() -> unmodifiableMap.put("key", exampleListOfValues()));
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
.isThrownBy(() -> asUnmodifiableMultiValueMap.putIfAbsent("key", exampleListOfValues()));
.isThrownBy(() -> unmodifiableMap.putIfAbsent("key", exampleListOfValues()));
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
.isThrownBy(() -> asUnmodifiableMultiValueMap.putAll(exampleMultiValueMap()));
.isThrownBy(() -> unmodifiableMap.putAll(exampleMultiValueMap()));
softly.assertThatExceptionOfType(UnsupportedOperationException.class)
.isThrownBy(() -> asUnmodifiableMultiValueMap.remove("key1"));
.isThrownBy(() -> unmodifiableMap.remove("key1"));
});
}