Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use StringJoiner where possible to simplify String joining

Browse Source
This commit is contained in:
Sebastien Deleuze
2019-02-18 14:50:27 +01:00
committed by Juergen Hoeller
parent 766a23bd93
commit dc8fb8bc5e
3 changed files with 17 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
spring-web/src/main/java/org/springframework/http/HttpHeaders.java
View File

@@ -39,6 +39,7 @@ import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Set;
import java.util.StringJoiner;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import java.util.stream.Collectors;
@@ -1505,17 +1506,13 @@ public class HttpHeaders implements MultiValueMap<String, String>, Serializable
* @return a combined result with comma delimitation
*/
protected String toCommaDelimitedString(List<String> headerValues) {
StringBuilder builder = new StringBuilder();
for (Iterator<String> it = headerValues.iterator(); it.hasNext();) {
String val = it.next();
StringJoiner joiner = new StringJoiner(", ");
for (String val : headerValues) {
if (val != null) {
builder.append(val);
if (it.hasNext()) {
builder.append(", ");
}
joiner.add(val);
}
}
return builder.toString();
return joiner.toString();
}
/**