Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Requalify tests as LONG_RUNNING

Browse Source 
Prior to this commit, some tests would belong to the PERFORMANCE
`TestGroup`, while they were not testing for performance but rather
performing functional tests that involve long running operations or
timeouts.

This commit moves those tests to the LONG_RUNNING `TestGroup`.

See gh-24830
This commit is contained in:
Brian Clozel
2020-09-25 13:13:51 +02:00
parent f89bd47188
commit e02d3f32b4
12 changed files with 47 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
spring-context-support/src/test/java/org/springframework/scheduling/quartz/QuartzSupportTests.java
View File

@@ -46,7 +46,7 @@ import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException
import static org.mockito.BDDMockito.given;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.springframework.core.testfixture.TestGroup.PERFORMANCE;
import static org.springframework.core.testfixture.TestGroup.LONG_RUNNING;
/**
* @author Juergen Hoeller
@@ -96,7 +96,7 @@ public class QuartzSupportTests {
}
@Test
@EnabledForTestGroups(PERFORMANCE)
@EnabledForTestGroups(LONG_RUNNING)
public void schedulerWithTaskExecutor() throws Exception {
CountingTaskExecutor taskExecutor = new CountingTaskExecutor();
DummyJob.count = 0;
@@ -137,7 +137,7 @@ public class QuartzSupportTests {
}
@Test
@EnabledForTestGroups(PERFORMANCE)
@EnabledForTestGroups(LONG_RUNNING)
public void schedulerWithQuartzJobBean() throws Exception {
DummyJob.param = 0;
DummyJob.count = 0;
@@ -170,7 +170,7 @@ public class QuartzSupportTests {
}
@Test
@EnabledForTestGroups(PERFORMANCE)
@EnabledForTestGroups(LONG_RUNNING)
public void schedulerWithSpringBeanJobFactory() throws Exception {
DummyJob.param = 0;
DummyJob.count = 0;
@@ -205,7 +205,7 @@ public class QuartzSupportTests {
}
@Test
@EnabledForTestGroups(PERFORMANCE)
@EnabledForTestGroups(LONG_RUNNING)
public void schedulerWithSpringBeanJobFactoryAndParamMismatchNotIgnored() throws Exception {
DummyJob.param = 0;
DummyJob.count = 0;
@@ -241,7 +241,7 @@ public class QuartzSupportTests {
}
@Test
@EnabledForTestGroups(PERFORMANCE)
@EnabledForTestGroups(LONG_RUNNING)
public void schedulerWithSpringBeanJobFactoryAndQuartzJobBean() throws Exception {
DummyJobBean.param = 0;
DummyJobBean.count = 0;
@@ -275,7 +275,7 @@ public class QuartzSupportTests {
}
@Test
@EnabledForTestGroups(PERFORMANCE)
@EnabledForTestGroups(LONG_RUNNING)
public void schedulerWithSpringBeanJobFactoryAndJobSchedulingData() throws Exception {
DummyJob.param = 0;
DummyJob.count = 0;
@@ -316,7 +316,7 @@ public class QuartzSupportTests {
}
@Test
@EnabledForTestGroups(PERFORMANCE)
@EnabledForTestGroups(LONG_RUNNING)
public void twoAnonymousMethodInvokingJobDetailFactoryBeans() throws Exception {
Thread.sleep(3000);
try (ClassPathXmlApplicationContext ctx = context("multipleAnonymousMethodInvokingJobDetailFB.xml")) {
@@ -331,7 +331,7 @@ public class QuartzSupportTests {
}
@Test
@EnabledForTestGroups(PERFORMANCE)
@EnabledForTestGroups(LONG_RUNNING)
public void schedulerAccessorBean() throws Exception {
Thread.sleep(3000);
try (ClassPathXmlApplicationContext ctx = context("schedulerAccessorBean.xml")) {