Use try-with-resources for AutoClosables where feasible
Where unfeasible, this commit adds inline comments to explain why try-with-resources must not be used in certain scenarios. The purpose of the comments is to avoid accidental conversion to try-with-resources at a later date. Closes gh-27823
This commit is contained in:
committed by
Sam Brannen
parent
999376f9f9
commit
e1200f34e7
@@ -101,6 +101,8 @@ public class LocalVariableTableParameterNameDiscoverer implements ParameterNameD
|
||||
}
|
||||
return NO_DEBUG_INFO_MAP;
|
||||
}
|
||||
// We cannot use try-with-resources here as, potential, exception upon closing
|
||||
// would still bubble up the stack
|
||||
try {
|
||||
ClassReader classReader = new ClassReader(is);
|
||||
Map<Executable, String[]> map = new ConcurrentHashMap<>(32);
|
||||
|
||||
Reference in New Issue
Block a user