Collection.isEmpty() should be used to test for emptiness

Closes gh-1670
This commit is contained in:
igor-suhorukov
2018-02-09 00:31:43 +03:00
committed by Stephane Nicoll
parent 7da40abba5
commit e381514b07
14 changed files with 17 additions and 17 deletions

View File

@@ -72,7 +72,7 @@ class CacheAdviceParser extends AbstractSingleBeanDefinitionParser {
CacheNamespaceHandler.parseKeyGenerator(element, builder.getBeanDefinition());
List<Element> cacheDefs = DomUtils.getChildElementsByTagName(element, DEFS_ELEMENT);
if (cacheDefs.size() >= 1) {
if (!cacheDefs.isEmpty()) {
// Using attributes source.
List<RootBeanDefinition> attributeSourceDefinitions = parseDefinitionsSources(cacheDefs, parserContext);
builder.addPropertyValue("cacheOperationSources", attributeSourceDefinitions);

View File

@@ -95,7 +95,7 @@ public abstract class JmxUtils {
// null means any registered server, but "" specifically means the platform server
if (!"".equals(agentId)) {
List<MBeanServer> servers = MBeanServerFactory.findMBeanServer(agentId);
if (servers != null && servers.size() > 0) {
if (servers != null && !servers.isEmpty()) {
// Check to see if an MBeanServer is registered.
if (servers.size() > 1 && logger.isWarnEnabled()) {
logger.warn("Found more than one MBeanServer instance" +

View File

@@ -568,7 +568,7 @@ public class DataBinder implements PropertyEditorRegistry, TypeConverter {
*/
@Nullable
public Validator getValidator() {
return (this.validators.size() > 0 ? this.validators.get(0) : null);
return (!this.validators.isEmpty() ? this.validators.get(0) : null);
}
/**