From e6020ed3777fe5d99e0c9333185f7f5ad143b9c9 Mon Sep 17 00:00:00 2001 From: igor-suhorukov Date: Thu, 29 Mar 2018 00:22:37 +0300 Subject: [PATCH] avoid unnecessary autoboxing --- .../org/springframework/aop/config/AopNamespaceUtils.java | 4 ++-- .../scheduling/support/CronSequenceGenerator.java | 2 +- .../servlet/config/ViewControllerBeanDefinitionParser.java | 2 +- .../web/servlet/mvc/WebContentInterceptor.java | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/spring-aop/src/main/java/org/springframework/aop/config/AopNamespaceUtils.java b/spring-aop/src/main/java/org/springframework/aop/config/AopNamespaceUtils.java index 56b6358ccb..7276ec7843 100644 --- a/spring-aop/src/main/java/org/springframework/aop/config/AopNamespaceUtils.java +++ b/spring-aop/src/main/java/org/springframework/aop/config/AopNamespaceUtils.java @@ -82,11 +82,11 @@ public abstract class AopNamespaceUtils { private static void useClassProxyingIfNecessary(BeanDefinitionRegistry registry, @Nullable Element sourceElement) { if (sourceElement != null) { - boolean proxyTargetClass = Boolean.valueOf(sourceElement.getAttribute(PROXY_TARGET_CLASS_ATTRIBUTE)); + boolean proxyTargetClass = Boolean.parseBoolean(sourceElement.getAttribute(PROXY_TARGET_CLASS_ATTRIBUTE)); if (proxyTargetClass) { AopConfigUtils.forceAutoProxyCreatorToUseClassProxying(registry); } - boolean exposeProxy = Boolean.valueOf(sourceElement.getAttribute(EXPOSE_PROXY_ATTRIBUTE)); + boolean exposeProxy = Boolean.parseBoolean(sourceElement.getAttribute(EXPOSE_PROXY_ATTRIBUTE)); if (exposeProxy) { AopConfigUtils.forceAutoProxyCreatorToExposeProxy(registry); } diff --git a/spring-context/src/main/java/org/springframework/scheduling/support/CronSequenceGenerator.java b/spring-context/src/main/java/org/springframework/scheduling/support/CronSequenceGenerator.java index a2a73b6112..6fcd8ed625 100644 --- a/spring-context/src/main/java/org/springframework/scheduling/support/CronSequenceGenerator.java +++ b/spring-context/src/main/java/org/springframework/scheduling/support/CronSequenceGenerator.java @@ -352,7 +352,7 @@ public class CronSequenceGenerator { if (!split[0].contains("-")) { range[1] = max - 1; } - int delta = Integer.valueOf(split[1]); + int delta = Integer.parseInt(split[1]); if (delta <= 0) { throw new IllegalArgumentException("Incrementer delta must be 1 or higher: '" + field + "' in expression \"" + this.expression + "\""); diff --git a/spring-webmvc/src/main/java/org/springframework/web/servlet/config/ViewControllerBeanDefinitionParser.java b/spring-webmvc/src/main/java/org/springframework/web/servlet/config/ViewControllerBeanDefinitionParser.java index 5c27570615..50bc3c5d6b 100644 --- a/spring-webmvc/src/main/java/org/springframework/web/servlet/config/ViewControllerBeanDefinitionParser.java +++ b/spring-webmvc/src/main/java/org/springframework/web/servlet/config/ViewControllerBeanDefinitionParser.java @@ -76,7 +76,7 @@ class ViewControllerBeanDefinitionParser implements BeanDefinitionParser { HttpStatus statusCode = null; if (element.hasAttribute("status-code")) { - int statusValue = Integer.valueOf(element.getAttribute("status-code")); + int statusValue = Integer.parseInt(element.getAttribute("status-code")); statusCode = HttpStatus.valueOf(statusValue); } diff --git a/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/WebContentInterceptor.java b/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/WebContentInterceptor.java index f97d2bb6ac..d599ec52dc 100644 --- a/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/WebContentInterceptor.java +++ b/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/WebContentInterceptor.java @@ -121,7 +121,7 @@ public class WebContentInterceptor extends WebContentGenerator implements Handle Enumeration propNames = cacheMappings.propertyNames(); while (propNames.hasMoreElements()) { String path = (String) propNames.nextElement(); - int cacheSeconds = Integer.valueOf(cacheMappings.getProperty(path)); + int cacheSeconds = Integer.parseInt(cacheMappings.getProperty(path)); this.cacheMappings.put(path, cacheSeconds); } }