diff --git a/spring-context/src/test/java/org/springframework/context/event/EventPublicationInterceptorTests.java b/spring-context/src/test/java/org/springframework/context/event/EventPublicationInterceptorTests.java index 772472dd11..dc298c2264 100644 --- a/spring-context/src/test/java/org/springframework/context/event/EventPublicationInterceptorTests.java +++ b/spring-context/src/test/java/org/springframework/context/event/EventPublicationInterceptorTests.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2019 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -129,7 +129,7 @@ public class EventPublicationInterceptorTests { public static class FactoryBeanTestListener extends TestListener implements FactoryBean { @Override - public Object getObject() throws Exception { + public Object getObject() { return "test"; } diff --git a/spring-context/src/test/java/org/springframework/context/event/PayloadApplicationEventTests.java b/spring-context/src/test/java/org/springframework/context/event/PayloadApplicationEventTests.java index c9f9c17996..1b1100bafe 100644 --- a/spring-context/src/test/java/org/springframework/context/event/PayloadApplicationEventTests.java +++ b/spring-context/src/test/java/org/springframework/context/event/PayloadApplicationEventTests.java @@ -35,10 +35,10 @@ public class PayloadApplicationEventTests { @Test public void testEventClassWithInterface() { - ApplicationContext ac = new AnnotationConfigApplicationContext(Listener.class); - MyEventClass event = new MyEventClass<>(this, "xyz"); + ApplicationContext ac = new AnnotationConfigApplicationContext(AuditableListener.class); + AuditablePayloadEvent event = new AuditablePayloadEvent<>(this, "xyz"); ac.publishEvent(event); - assertTrue(ac.getBean(Listener.class).events.contains(event)); + assertTrue(ac.getBean(AuditableListener.class).events.contains(event)); } @@ -46,20 +46,17 @@ public class PayloadApplicationEventTests { } - public static class MyEventClass extends PayloadApplicationEvent implements Auditable { + @SuppressWarnings("serial") + public static class AuditablePayloadEvent extends PayloadApplicationEvent implements Auditable { - public MyEventClass(Object source, GT payload) { + public AuditablePayloadEvent(Object source, T payload) { super(source, payload); } - - public String toString() { - return "Payload: " + getPayload(); - } } @Component - public static class Listener { + public static class AuditableListener { public final List events = new ArrayList<>(); diff --git a/spring-jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java b/spring-jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java index 67e7762e28..d9153a4faf 100644 --- a/spring-jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java +++ b/spring-jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java @@ -612,6 +612,7 @@ public class JdbcTemplate extends JdbcAccessor implements JdbcOperations { ((ParameterDisposer) psc).cleanupParameters(); } String sql = getSql(psc); + psc = null; JdbcUtils.closeStatement(ps); ps = null; DataSourceUtils.releaseConnection(con, getDataSource()); @@ -1053,6 +1054,7 @@ public class JdbcTemplate extends JdbcAccessor implements JdbcOperations { ((ParameterDisposer) csc).cleanupParameters(); } String sql = getSql(csc); + csc = null; JdbcUtils.closeStatement(cs); cs = null; DataSourceUtils.releaseConnection(con, getDataSource());