From ee40310c926f3ce1a51f28b20ede096995a667f2 Mon Sep 17 00:00:00 2001 From: Phillip Webb Date: Mon, 1 May 2017 21:26:16 -0700 Subject: [PATCH] Defer Charset.availableCharsets() call Change the `StringHttpMessageConverter` to defer calling Charset.availableCharsets() until absolutely necessary to help improve startup times. Issue: SPR-15502 --- .../http/converter/StringHttpMessageConverter.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/spring-web/src/main/java/org/springframework/http/converter/StringHttpMessageConverter.java b/spring-web/src/main/java/org/springframework/http/converter/StringHttpMessageConverter.java index dc15005483..b8c6a1943d 100644 --- a/spring-web/src/main/java/org/springframework/http/converter/StringHttpMessageConverter.java +++ b/spring-web/src/main/java/org/springframework/http/converter/StringHttpMessageConverter.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -43,7 +43,7 @@ public class StringHttpMessageConverter extends AbstractHttpMessageConverter availableCharsets; + private volatile List availableCharsets; private boolean writeAcceptCharset = true; @@ -62,7 +62,6 @@ public class StringHttpMessageConverter extends AbstractHttpMessageConverter(Charset.availableCharsets().values()); } @@ -115,6 +114,10 @@ public class StringHttpMessageConverter extends AbstractHttpMessageConverter getAcceptedCharsets() { + if (this.availableCharsets == null) { + this.availableCharsets = new ArrayList( + Charset.availableCharsets().values()); + } return this.availableCharsets; }