Eliminate all Javadoc warnings
- Support external Javadoc links using Gradle's javadoc.options.links - Fix all other Javadoc warnings, such as typos, references to non-existent (or no longer existent) types and members, etc, including changes related to the Quartz 2.0 upgrade (SPR-8275) and adding the HTTP PATCH method (SPR-7985). - Suppress all output for project-level `javadoc` tasks in order to hide false-negative warnings about cross-module @see and @link references (e.g. spring-core having a @see reference to spring-web). Use the `--info` (-i) flag to gradle at any time to see project-level javadoc warnings without running the entire `api` task. e.g. `gradle :spring-core:javadoc -i` - Favor root project level `api` task for detection of legitimate Javadoc warnings. There are now zero Javadoc warnings across the entirety of spring-framework. Goal: keep it that way. - Remove all @link and @see references to types and members that exist only in Servlet <= 2.5 and Hibernate <= 4.0, favoring 3.0+ and 4.0+ respectively. This is necessary because only one version of each of these dependencies can be present on the global `api` javadoc task's classpath. To that end, the `api` task classpath has now been customized to ensure that the Servlet 3 API and Hibernate Core 4 jars have precedence. - SPR-8896 replaced our dependency on aspectjrt with a dependency on aspectjweaver, which is fine from a POM point of view, but causes a spurious warning to be emitted from the ant iajc task that it "cannot find aspectjrt on the classpath" - even though aspectjweaver is perfectly sufficient. In the name of keeping the console quiet, a new `rt` configuration has been added, and aspectjrt added as a dependency to it. In turn, configurations.rt.asPath is appended to the iajc classpath during both compileJava and compileTestJava for spring-aspects. Issue: SPR-10078, SPR-8275, SPR-7985, SPR-8896
This commit is contained in:
Chris Beams
@@ -22,8 +22,6 @@ import javax.sql.rowset.CachedRowSet;
|
||||
import javax.sql.rowset.RowSetFactory;
|
||||
import javax.sql.rowset.RowSetProvider;
|
||||
|
||||
import com.sun.rowset.CachedRowSetImpl;
|
||||
|
||||
import org.springframework.core.JdkVersion;
|
||||
import org.springframework.jdbc.support.rowset.ResultSetWrappingSqlRowSet;
|
||||
import org.springframework.jdbc.support.rowset.SqlRowSet;
|
||||
@@ -91,7 +89,6 @@ public class SqlRowSetResultSetExtractor implements ResultSetExtractor<SqlRowSet
|
||||
* @return a new CachedRowSet instance
|
||||
* @throws SQLException if thrown by JDBC methods
|
||||
* @see #createSqlRowSet
|
||||
* @see com.sun.rowset.CachedRowSetImpl
|
||||
*/
|
||||
protected CachedRowSet newCachedRowSet() throws SQLException {
|
||||
return cachedRowSetFactory.createCachedRowSet();
|
||||
@@ -135,7 +132,7 @@ public class SqlRowSetResultSetExtractor implements ResultSetExtractor<SqlRowSet
|
||||
private static class SunCachedRowSetFactory implements CachedRowSetFactory {
|
||||
|
||||
public CachedRowSet createCachedRowSet() throws SQLException {
|
||||
return new CachedRowSetImpl();
|
||||
return new com.sun.rowset.CachedRowSetImpl();
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2002-2010 the original author or authors.
|
||||
* Copyright 2002-2012 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@@ -58,7 +58,7 @@ import org.springframework.util.FileCopyUtils;
|
||||
* <code>oracle.jdbc.OracleConnection</code>. If you pass in Connections from a
|
||||
* connection pool (the usual case in a J2EE environment), you need to set an
|
||||
* appropriate {@link org.springframework.jdbc.support.nativejdbc.NativeJdbcExtractor}
|
||||
* to allow for automatical retrieval of the underlying native JDBC Connection.
|
||||
* to allow for automatic retrieval of the underlying native JDBC Connection.
|
||||
* LobHandler and NativeJdbcExtractor are separate concerns, therefore they
|
||||
* are represented by separate strategy interfaces.
|
||||
*
|
||||
@@ -73,8 +73,6 @@ import org.springframework.util.FileCopyUtils;
|
||||
* @author Thomas Risberg
|
||||
* @since 04.12.2003
|
||||
* @see #setNativeJdbcExtractor
|
||||
* @see oracle.sql.BLOB
|
||||
* @see oracle.sql.CLOB
|
||||
*/
|
||||
public class OracleLobHandler extends AbstractLobHandler {
|
||||
|
||||
@@ -117,13 +115,14 @@ public class OracleLobHandler extends AbstractLobHandler {
|
||||
* method, namely <code>getNativeConnectionFromStatement</code> with a
|
||||
* PreparedStatement argument (falling back to a
|
||||
* <code>PreparedStatement.getConnection()</code> call if no extractor is set).
|
||||
* <p>A common choice is SimpleNativeJdbcExtractor, whose Connection unwrapping
|
||||
* <p>A common choice is {@code SimpleNativeJdbcExtractor}, whose Connection unwrapping
|
||||
* (which is what OracleLobHandler needs) will work with many connection pools.
|
||||
* See SimpleNativeJdbcExtractor's javadoc for details.
|
||||
* See {@code SimpleNativeJdbcExtractor} and
|
||||
* <a href="http://download.oracle.com/otn_hosted_doc/jdeveloper/905/jdbc-javadoc/oracle/jdbc/OracleConnection.html">
|
||||
* oracle.jdbc.OracleConnection</a> javadoc for details.
|
||||
* @see org.springframework.jdbc.support.nativejdbc.NativeJdbcExtractor#getNativeConnectionFromStatement
|
||||
* @see org.springframework.jdbc.support.nativejdbc.SimpleNativeJdbcExtractor
|
||||
* @see org.springframework.jdbc.support.nativejdbc.OracleJdbc4NativeJdbcExtractor
|
||||
* @see oracle.jdbc.OracleConnection
|
||||
*/
|
||||
public void setNativeJdbcExtractor(NativeJdbcExtractor nativeJdbcExtractor) {
|
||||
this.nativeJdbcExtractor = nativeJdbcExtractor;
|
||||
@@ -132,10 +131,12 @@ public class OracleLobHandler extends AbstractLobHandler {
|
||||
/**
|
||||
* Set whether to cache the temporary LOB in the buffer cache.
|
||||
* This value will be passed into BLOB/CLOB.createTemporary.
|
||||
*
|
||||
* <p>Default is <code>true</code>.
|
||||
* @see oracle.sql.BLOB#createTemporary
|
||||
* @see oracle.sql.CLOB#createTemporary
|
||||
* <p><strong>See Also:</strong>
|
||||
* <ul>
|
||||
* <li><a href="http://download.oracle.com/otn_hosted_doc/jdeveloper/905/jdbc-javadoc/oracle/sql/BLOB.html#createTemporary()">oracle.sql.BLOB.createTemporary</a></li>
|
||||
* <li><a href="http://download.oracle.com/otn_hosted_doc/jdeveloper/905/jdbc-javadoc/oracle/sql/CLOB.html#createTemporary()">oracle.sql.CLOB.createTemporary</a></li>
|
||||
* </ul>
|
||||
*/
|
||||
public void setCache(boolean cache) {
|
||||
this.cache = cache;
|
||||
@@ -149,12 +150,15 @@ public class OracleLobHandler extends AbstractLobHandler {
|
||||
* temporary LOBs that occupy space in the TEMPORARY tablespace or when you want to free up any
|
||||
* memory allocated by the driver for the LOB reading.
|
||||
* <p>Default is <code>false</code>.
|
||||
* @see oracle.sql.BLOB#freeTemporary
|
||||
* @see oracle.sql.CLOB#freeTemporary
|
||||
* @see oracle.sql.BLOB#open
|
||||
* @see oracle.sql.CLOB#open
|
||||
* @see oracle.sql.BLOB#close
|
||||
* @see oracle.sql.CLOB#close
|
||||
* <p><strong>See Also:</strong>
|
||||
* <ul>
|
||||
* <li><a href="http://download.oracle.com/otn_hosted_doc/jdeveloper/905/jdbc-javadoc/oracle/sql/BLOB.html#freeTemporary()">oracle.sql.BLOB.freeTemporary</a></li>
|
||||
* <li><a href="http://download.oracle.com/otn_hosted_doc/jdeveloper/905/jdbc-javadoc/oracle/sql/CLOB.html#freeTemporary()">oracle.sql.CLOB.freeTemporary</a></li>
|
||||
* <li><a href="http://download.oracle.com/otn_hosted_doc/jdeveloper/905/jdbc-javadoc/oracle/sql/BLOB.html#open()">oracle.sql.BLOB.open</a></li>
|
||||
* <li><a href="http://download.oracle.com/otn_hosted_doc/jdeveloper/905/jdbc-javadoc/oracle/sql/CLOB.html#open()">oracle.sql.CLOB.open</a></li>
|
||||
* <li><a href="http://download.oracle.com/otn_hosted_doc/jdeveloper/905/jdbc-javadoc/oracle/sql/BLOB.html#open()">oracle.sql.BLOB.close</a></li>
|
||||
* <li><a href="http://download.oracle.com/otn_hosted_doc/jdeveloper/905/jdbc-javadoc/oracle/sql/CLOB.html#open()">oracle.sql.CLOB.close</a></li>
|
||||
* </ul>
|
||||
*/
|
||||
public void setReleaseResourcesAfterRead(boolean releaseResources) {
|
||||
this.releaseResourcesAfterRead = releaseResources;
|
||||
@@ -165,14 +169,17 @@ public class OracleLobHandler extends AbstractLobHandler {
|
||||
* Retrieve the <code>oracle.sql.BLOB</code> and <code>oracle.sql.CLOB</code>
|
||||
* classes via reflection, and initialize the values for the
|
||||
* DURATION_SESSION, MODE_READWRITE and MODE_READONLY constants defined there.
|
||||
* <p><strong>See Also:</strong>
|
||||
* <ul>
|
||||
* <li><a href="http://download.oracle.com/otn_hosted_doc/jdeveloper/905/jdbc-javadoc/oracle/sql/BLOB.html#DURATION_SESSION">oracle.sql.BLOB.DURATION_SESSION</a></li>
|
||||
* <li><a href="http://download.oracle.com/otn_hosted_doc/jdeveloper/905/jdbc-javadoc/oracle/sql/BLOB.html#MODE_READWRITE">oracle.sql.BLOB.MODE_READWRITE</a></li>
|
||||
* <li><a href="http://download.oracle.com/otn_hosted_doc/jdeveloper/905/jdbc-javadoc/oracle/sql/BLOB.html#MODE_READONLY">oracle.sql.BLOB.MODE_READONLY</a></li>
|
||||
* <li><a href="http://download.oracle.com/otn_hosted_doc/jdeveloper/905/jdbc-javadoc/oracle/sql/CLOB.html#DURATION_SESSION">oracle.sql.CLOB.DURATION_SESSION</a></li>
|
||||
* <li><a href="http://download.oracle.com/otn_hosted_doc/jdeveloper/905/jdbc-javadoc/oracle/sql/CLOB.html#MODE_READWRITE">oracle.sql.CLOB.MODE_READWRITE</a></li>
|
||||
* <li><a href="http://download.oracle.com/otn_hosted_doc/jdeveloper/905/jdbc-javadoc/oracle/sql/CLOB.html#MODE_READONLY">oracle.sql.CLOB.MODE_READONLY</a></li>
|
||||
* </ul>
|
||||
* @param con the Oracle Connection, for using the exact same class loader
|
||||
* that the Oracle driver was loaded with
|
||||
* @see oracle.sql.BLOB#DURATION_SESSION
|
||||
* @see oracle.sql.BLOB#MODE_READWRITE
|
||||
* @see oracle.sql.BLOB#MODE_READONLY
|
||||
* @see oracle.sql.CLOB#DURATION_SESSION
|
||||
* @see oracle.sql.CLOB#MODE_READWRITE
|
||||
* @see oracle.sql.CLOB#MODE_READONLY
|
||||
*/
|
||||
protected synchronized void initOracleDriverClasses(Connection con) {
|
||||
if (this.blobClass == null) {
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2002-2008 the original author or authors.
|
||||
* Copyright 2002-2012 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@@ -37,8 +37,6 @@ import org.springframework.util.ReflectionUtils;
|
||||
*
|
||||
* @author Juergen Hoeller
|
||||
* @since 1.1
|
||||
* @see com.ibm.ws.rsadapter.jdbc.WSJdbcConnection
|
||||
* @see com.ibm.ws.rsadapter.jdbc.WSJdbcUtil#getNativeConnection
|
||||
*/
|
||||
public class WebSphereNativeJdbcExtractor extends NativeJdbcExtractorAdapter {
|
||||
|
||||
|
||||
Reference in New Issue
Block a user