From f5ff1dc3f93d88b1983ace34a8152529c86394de Mon Sep 17 00:00:00 2001 From: Rossen Stoyanchev Date: Fri, 27 Jul 2018 07:52:12 -0400 Subject: [PATCH] Comment on difference in matrix variable test Based on discussion under https://github.com/spring-projects/spring-framework/pull/1901 --- .../result/method/RequestMappingInfoHandlerMappingTests.java | 4 ++++ .../mvc/method/RequestMappingInfoHandlerMappingTests.java | 1 + 2 files changed, 5 insertions(+) diff --git a/spring-webflux/src/test/java/org/springframework/web/reactive/result/method/RequestMappingInfoHandlerMappingTests.java b/spring-webflux/src/test/java/org/springframework/web/reactive/result/method/RequestMappingInfoHandlerMappingTests.java index 282918f69f..d486dc9350 100644 --- a/spring-webflux/src/test/java/org/springframework/web/reactive/result/method/RequestMappingInfoHandlerMappingTests.java +++ b/spring-webflux/src/test/java/org/springframework/web/reactive/result/method/RequestMappingInfoHandlerMappingTests.java @@ -284,6 +284,10 @@ public class RequestMappingInfoHandlerMappingTests { matrixVariables = getMatrixVariables(exchange, "foo"); uriVariables = getUriTemplateVariables(exchange); + // Unlike Spring MVC, WebFlux currently does not support APIs like + // "/foo/{ids}" and URL "/foo/id=1;id=2;id=3" where the whole path + // segment is a sequence of name-value pairs. + assertNotNull(matrixVariables); assertEquals(1, matrixVariables.size()); assertEquals("c", matrixVariables.getFirst("b")); diff --git a/spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/RequestMappingInfoHandlerMappingTests.java b/spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/RequestMappingInfoHandlerMappingTests.java index 68bae95edb..2464d9ce9a 100644 --- a/spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/RequestMappingInfoHandlerMappingTests.java +++ b/spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/RequestMappingInfoHandlerMappingTests.java @@ -355,6 +355,7 @@ public class RequestMappingInfoHandlerMappingTests { uriVariables = getUriTemplateVariables(request); assertNotNull(matrixVariables); + assertEquals(2, matrixVariables.size()); assertEquals("42", matrixVariables.getFirst("a")); assertEquals("c", matrixVariables.getFirst("b")); assertEquals("a=42", uriVariables.get("foo"));