Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SpringServletContainerInitializer does not log WebApplicationInitializer class names

Browse Source 
Issue: SPR-14213
This commit is contained in:
Juergen Hoeller
2016-04-26 17:03:57 +02:00
parent bf7b475267
commit f73df2e138
1 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
spring-web/src/main/java/org/springframework/web/SpringServletContainerInitializer.java
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2014 the original author or authors. * Copyright 2002-2016 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@@ -113,18 +113,14 @@ public class SpringServletContainerInitializer implements ServletContainerInitia
/** /**
* Delegate the {@code ServletContext} to any {@link WebApplicationInitializer} * Delegate the {@code ServletContext} to any {@link WebApplicationInitializer}
* implementations present on the application classpath. * implementations present on the application classpath.
*
* <p>Because this class declares @{@code HandlesTypes(WebApplicationInitializer.class)}, * <p>Because this class declares @{@code HandlesTypes(WebApplicationInitializer.class)},
* Servlet 3.0+ containers will automatically scan the classpath for implementations * Servlet 3.0+ containers will automatically scan the classpath for implementations
* of Spring's {@code WebApplicationInitializer} interface and provide the set of all * of Spring's {@code WebApplicationInitializer} interface and provide the set of all
* such types to the {@code webAppInitializerClasses} parameter of this method. * such types to the {@code webAppInitializerClasses} parameter of this method.
* * <p>If no {@code WebApplicationInitializer} implementations are found on the classpath,
* <p>If no {@code WebApplicationInitializer} implementations are found on the * this method is effectively a no-op. An INFO-level log message will be issued notifying
* classpath, this method is effectively a no-op. An INFO-level log message will be * the user that the {@code ServletContainerInitializer} has indeed been invoked but that
* issued notifying the user that the {@code ServletContainerInitializer} has indeed * no {@code WebApplicationInitializer} implementations were found.
* been invoked but that no {@code WebApplicationInitializer} implementations were
* found.
*
* <p>Assuming that one or more {@code WebApplicationInitializer} types are detected, * <p>Assuming that one or more {@code WebApplicationInitializer} types are detected,
* they will be instantiated (and <em>sorted</em> if the @{@link * they will be instantiated (and <em>sorted</em> if the @{@link
* org.springframework.core.annotation.Order @Order} annotation is present or * org.springframework.core.annotation.Order @Order} annotation is present or
@@ -134,7 +130,6 @@ public class SpringServletContainerInitializer implements ServletContainerInitia
* that each instance may register and configure servlets such as Spring's * that each instance may register and configure servlets such as Spring's
* {@code DispatcherServlet}, listeners such as Spring's {@code ContextLoaderListener}, * {@code DispatcherServlet}, listeners such as Spring's {@code ContextLoaderListener},
* or any other Servlet API componentry such as filters. * or any other Servlet API componentry such as filters.
*
* @param webAppInitializerClasses all implementations of * @param webAppInitializerClasses all implementations of
* {@link WebApplicationInitializer} found on the application classpath * {@link WebApplicationInitializer} found on the application classpath
* @param servletContext the servlet context to be initialized * @param servletContext the servlet context to be initialized
@@ -168,9 +163,8 @@ public class SpringServletContainerInitializer implements ServletContainerInitia
return; return;
} }
servletContext.log(initializers.size() + " Spring WebApplicationInitializers detected on classpath");
AnnotationAwareOrderComparator.sort(initializers); AnnotationAwareOrderComparator.sort(initializers);
servletContext.log("Spring WebApplicationInitializers detected on classpath: " + initializers);
for (WebApplicationInitializer initializer : initializers) { for (WebApplicationInitializer initializer : initializers) {
initializer.onStartup(servletContext); initializer.onStartup(servletContext);
} }