Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Implement JCacheCache#putIfAbsent as atomic operation

Browse Source 
This commit modifies putIfAbsent to use an EntryProcessor that
guarantees that the operation is atomic.

Closes gh-21591
This commit is contained in:
Stéphane Nicoll
2023-09-18 09:09:47 +02:00
parent 57a4628934
commit f79bc7b14d
2 changed files with 40 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
spring-context-support/src/main/java/org/springframework/cache/jcache/JCacheCache.java vendored
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2002-2020 the original author or authors.
* Copyright 2002-2023 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -98,8 +98,8 @@ public class JCacheCache extends AbstractValueAdaptingCache {
@Override
@Nullable
public ValueWrapper putIfAbsent(Object key, @Nullable Object value) {
boolean set = this.cache.putIfAbsent(key, toStoreValue(value));
return (set ? null : get(key));
Object previous = this.cache.invoke(key, PutIfAbsentEntryProcessor.INSTANCE, toStoreValue(value));
return (previous != null ? toValueWrapper(previous) : null);
}
@Override
@@ -125,6 +125,22 @@ public class JCacheCache extends AbstractValueAdaptingCache {
}
private static class PutIfAbsentEntryProcessor implements EntryProcessor<Object, Object, Object> {
private static final PutIfAbsentEntryProcessor INSTANCE = new PutIfAbsentEntryProcessor();
@Override
@Nullable
public Object process(MutableEntry<Object, Object> entry, Object... arguments) throws EntryProcessorException {
Object existingValue = entry.getValue();
if (existingValue == null) {
entry.setValue(arguments[0]);
}
return existingValue;
}
}
private class ValueLoaderEntryProcessor<T> implements EntryProcessor<Object, Object, T> {
@SuppressWarnings("unchecked")