Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplify DefaultSingletonBeanRegistry.isDependent()

Browse Source 
Move `alreadySeen` handling out of for-loop.

Closes gh-30839
This commit is contained in:
bnbakp0582
2023-07-08 22:02:38 +08:00
committed by Sam Brannen
parent b3de1b8e95
commit fb4ad2f3ba
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-beans/src/main/java/org/springframework/beans/factory/support/DefaultSingletonBeanRegistry.java
View File

@@ -453,11 +453,11 @@ public class DefaultSingletonBeanRegistry extends SimpleAliasRegistry implements
if (dependentBeans.contains(dependentBeanName)) { if (dependentBeans.contains(dependentBeanName)) {
return true; return true;
} }
if (alreadySeen == null) {
alreadySeen = new HashSet<>();
}
alreadySeen.add(beanName);
for (String transitiveDependency : dependentBeans) { for (String transitiveDependency : dependentBeans) {
if (alreadySeen == null) {
alreadySeen = new HashSet<>();
}
alreadySeen.add(beanName);
if (isDependent(transitiveDependency, dependentBeanName, alreadySeen)) { if (isDependent(transitiveDependency, dependentBeanName, alreadySeen)) {
return true; return true;
} }