Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Work-around for Eclipse bug regarding EnumSets

Browse Source 
This commit introduces superfluous casts in CollectionFactory to
address a bug in Eclipse 4.4.1 that prevents the code from compiling
within Eclipse. Specifically, without these casts Eclipse displays the
following error for use of the EnumSet.copyOf() and EnumSet.noneOf()
methods:

Type mismatch: cannot convert from EnumSet<Enum<Enum<E>>> to
Collection<E>
This commit is contained in:
Sam Brannen
2014-12-09 20:54:36 +01:00
parent 84ef269d54
commit fe78900524
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spring-core/src/main/java/org/springframework/core/CollectionFactory.java
View File

@@ -105,7 +105,7 @@ public abstract class CollectionFactory {
* @see java.util.ArrayList
* @see java.util.LinkedList
*/
@SuppressWarnings("unchecked")
@SuppressWarnings({ "unchecked", "cast" })
public static <E> Collection<E> createApproximateCollection(Object collection, int capacity) {
if (collection instanceof LinkedList) {
return new LinkedList<E>();
@@ -114,7 +114,8 @@ public abstract class CollectionFactory {
return new ArrayList<E>(capacity);
}
else if (collection instanceof EnumSet) {
return EnumSet.copyOf((Collection) collection);
// superfluous cast necessary for bug in Eclipse 4.4.1.
return (Collection<E>) EnumSet.copyOf((EnumSet) collection);
}
else if (collection instanceof SortedSet) {
return new TreeSet<E>(((SortedSet<E>) collection).comparator());
@@ -149,7 +150,7 @@ public abstract class CollectionFactory {
* @see java.util.EnumSet
* @see java.util.ArrayList
*/
@SuppressWarnings("unchecked")
@SuppressWarnings({ "unchecked", "cast" })
public static <E> Collection<E> createCollection(Class<?> collectionClass, Class<?> elementType, int capacity) {
if (collectionClass.isInterface()) {
if (Set.class.equals(collectionClass) || Collection.class.equals(collectionClass)) {
@@ -167,7 +168,8 @@ public abstract class CollectionFactory {
}
else if (EnumSet.class.equals(collectionClass)) {
Assert.notNull(elementType, "Cannot create EnumSet for unknown element type");
return EnumSet.noneOf((Class) elementType);
// superfluous cast necessary for bug in Eclipse 4.4.1.
return (Collection<E>) EnumSet.noneOf((Class) elementType);
}
else {
if (!Collection.class.isAssignableFrom(collectionClass)) {