Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
23,916 Commits 18 Branches 0 Tags
0b4b313baeddb4edee26d0678f040f0696c4873e
Commit Graph

489 Commits

Author SHA1 Message Date
Juergen Hoeller
dd16e012ba Clarify ReactiveTransactionManager exception declarations 
Avoid misleading "throws TransactionException" declarations but preserve javadoc "@throws" notes for specific exceptions (with reactive propagation semantics).

Closes gh-30817
 2023-07-05 12:15:05 +02:00
Juergen Hoeller
d4cd358c76 Discuss JdbcTransactionManager vs DataSourceTransactionManager 
Closes gh-30802
 2023-07-05 12:14:48 +02:00
Juergen Hoeller
69827a2f21 Raise beforeCompletion/afterCompletion exception log level to error 
Closes gh-30776

(cherry picked from commit f1567fb21a)
 2023-06-30 13:16:37 +02:00
Juergen Hoeller
000383fbff Explicit target ClassLoader for interface-based infrastructure proxies 
Includes direct JDK Proxy usage instead of ProxyFactory where possible.

Closes gh-29913

(cherry picked from commit 4d6249811e)
 2023-01-31 16:48:27 +01:00
Juergen Hoeller
937ab5f4b2 Polishing (aligned with main) 2022-12-13 12:06:09 +01:00
Sam Brannen
41a6b7ec20 Update copyright headers for source code changed since August 2022 
The changes in this commit were performed using the newly introduced
update_copyright_headers.sh script.
 2022-12-03 17:23:21 -05:00
Sam Brannen
e5878ab15b Fix precondition assertions 2022-11-08 12:08:08 +01:00
Johnny Lim
1c1a0afbed Use AssertJ static imports consistently in 5.3.x 
Closes gh-29282
 2022-10-08 13:57:21 +02:00
Sam Brannen
62a0ab3667 Polish contribution 2022-09-14 16:50:32 +02:00
Marc Wrobel
92a231cf91 Fix typos in Javadoc, reference docs, and code 
Closes gh-28822
 2022-09-14 16:45:34 +02:00
Marc Wrobel
3b68e97710 Fix and improve Javadoc in spring-tx 
Closes gh-28794
 2022-07-12 12:36:49 +02:00
Sam Brannen
d274e893a6 Remove superfluous static declaration for enum, annotation, & interface 2022-07-09 16:16:13 +02:00
Sam Brannen
1beb7068f6 Use new AssertJ exception assertions 2022-05-31 14:08:28 +02:00
Sam Brannen
64b64d9ba0 Stop referring to features as "Java 5" features 
With a Java 8 baseline in place for quite some time now, it no longer
makes sense to refer to features such as annotations as "Java 5
annotations".

This commit also removes old `Tiger*Tests` classes, thereby avoiding
duplicate execution of various tests.
 2022-03-18 16:32:30 +01:00
Sam Brannen
fa3130d716 Document that TX rollback rules may result in unintentional matches 
Closes gh-28125
 2022-03-04 16:39:11 +01:00
Sam Brannen
b3e5f86277 Polish rollback rule support 2022-03-03 16:20:13 +01:00
Sam Brannen
340f41af6d Suppress warnings in Gradle build 2022-03-02 17:28:45 +01:00
Sam Brannen
25aa295c2c Rename test class to adhere to conventions 2022-03-02 17:25:37 +01:00
Sam Brannen
67b91b2390 Polish RollbackRuleTests 
See gh-28098
 2022-03-01 19:10:33 +01:00
Juergen Hoeller
a71a45e719 Deprecate AsyncTaskExecutor.execute(Runnable task, long startTimeout) 
Closes gh-27959
 2022-02-04 23:21:00 +01:00
Sam Brannen
df263d01b9 Use idiomatic AssertJ assertions for true, false, and null 2022-01-10 14:15:55 +01:00
Sam Brannen
3e14cdbc69 Polish tests 2022-01-04 14:02:32 +01:00
Juergen Hoeller
d665977787 Polishing 2021-12-15 21:50:30 +01:00
Juergen Hoeller
14f24f43d7 Polishing 2021-12-03 22:36:31 +01:00
Juergen Hoeller
8d735e6e60 Note on PersistenceExceptionTranslator sorting and non-singleton retrieval 
Closes gh-26412
 2021-11-09 22:30:44 +01:00
Sam Brannen
41ae9632d1 Upgrade to Checkstyle 9.0 and spring-javaformat 0.0.29 
This commit upgrades the Gradle build to use Checkstyle 9.0 and
spring-javaformat 0.0.29 (which internally uses Checkstyle 8.45.1).

Closes gh-27520
 2021-10-06 12:11:19 +02:00
Rossen Stoyanchev
7b9848a352 Replace deprecated Reactor Context related methods 2021-10-05 14:33:52 +01:00
Sam Brannen
96e4d3a530 Fail Gradle build for Javadoc warnings 
In order to catch Javadoc errors in the build, we now enable the
`Xwerror` flag for the `javadoc` tool. In addition, we now use
`Xdoclint:syntax` instead of `Xdoclint:none` in order to validate
syntax within our Javadoc.

This commit fixes all resulting Javadoc errors and warnings.

This commit also upgrades to Undertow 2.2.12.Final and fixes the
artifact names for exclusions for the Servlet and annotations APIs.

The incorrect exclusion of the Servlet API resulted in the Servlet API
being on the classpath twice for the javadoc task, which resulted in the
following warnings in previous builds.

javadoc: warning - Multiple sources of package comments found for package "javax.servlet"
javadoc: warning - Multiple sources of package comments found for package "javax.servlet.http"
javadoc: warning - Multiple sources of package comments found for package "javax.servlet.descriptor"
javadoc: warning - Multiple sources of package comments found for package "javax.servlet.annotation"

Closes gh-27480
 2021-09-29 14:02:37 +02:00
Philippe Marschall
debf61b948 Remove unused private loggers 
Closes gh-27336
 2021-08-30 16:51:59 +02:00
Juergen Hoeller
a07c7865a5 Lazy initialization of transaction UUID (with deprecated getter methods) 
Includes removal of trace logging for individual synchronization steps.

Closes gh-26955
 2021-07-09 15:07:30 +02:00
Sam Brannen
a2ef6badc4 Use StringBuilder.append(char) where possible 
To slightly improve performance, this commit switches to
StringBuilder.append(char) instead of StringBuilder.append(String)
whenever we append a single character to a StringBuilder.

Closes gh-27098
 2021-06-25 10:44:28 +02:00
Sam Brannen
da9ee06e05 Improve @Transactional docs regarding method visibility 
Closes gh-27003
 2021-05-30 17:10:01 +02:00
Sam Brannen
1e1045ba42 Doc tx semantics for @TransactionalEventListener after completion phases 
This commit improves the Javadoc regarding transactional semantics for
@TransactionalEventListener methods invoked in the AFTER_COMMIT,
AFTER_ROLLBACK, or AFTER_COMPLETION phase. Specifically, the
documentation now points out that interactions with the underlying
transactional resource will not be committed in those phases.

Closes gh-26974
 2021-05-26 14:21:08 +02:00
Sébastien Deleuze
3dba3691a7 Upgrade to Coroutines 1.5.0 
This commit upgrades to Coroutines 1.5.0 while retaining
Coroutines 1.4.x compatibility.

Closes gh-26897
 2021-05-17 11:37:02 +02:00
Juergen Hoeller
7f670bbe68 TransactionSynchronization does not support @Order (just Ordered interface) 
See gh-21725
 2021-05-11 15:45:05 +02:00
Juergen Hoeller
3c9bd3177e Move getListenerId method to Smart/GenericApplicationListener 
See gh-26638
 2021-03-09 12:30:52 +01:00
Juergen Hoeller
86902d27b2 Expose id/getListenerId in base EventListener/ApplicationListener (pulled up from tx) 
Includes removeApplicationListeners(Predicate) method in ApplicationEventMulticaster.

Closes gh-26638
 2021-03-08 19:31:56 +01:00
Sam Brannen
3215880d08 Remove Javadoc link to private method 2021-02-21 19:13:02 +01:00
Sam Brannen
2d29fcd0bb Polish Javadoc for TransactionSynchronizationUtils 2021-01-27 14:03:38 +01:00
Sam Brannen
5e56162394 Fix Checkstyle violation 
The @since tag must come before @see tags.

See gh-26450
 2021-01-27 11:53:20 +01:00
Johnny Lim
45650f2b27 Add @since tag to TransactionSynchronizationUtils.unwrapResourceIfNecessary() 
Closes gh-26450
 2021-01-27 11:23:22 +01:00
Sam Brannen
4a7a2258f9 Unwrap proxied DataSources in SqlScriptsTestExecutionListener 
Prior to this commit, if the DataSource in the
DataSourceFromTransactionManager was wrapped in a proxy implementing
InfrastructureProxy, SqlScriptsTestExecutionListener would throw an
exception stating that the DataSource in the ApplicationContext and the
DataSource in the DataSourceFromTransactionManager were not the same.

This commit unwraps both data sources and compares the underlying
target instances to check for equality.

In addition, this commit makes the unwrapResourceIfNecessary() method in
TransactionSynchronizationUtils public.

Closes gh-26422
 2021-01-22 18:22:00 +01:00
Juergen Hoeller
2ee231dee2 Document that @Transactional does not propagate to new threads 
Closes gh-25439
 2020-11-17 14:43:17 +01:00
Juergen Hoeller
51b1306d70 Move coroutines invocation decision to invokeWithinTransaction 
See gh-26092
 2020-11-16 17:41:09 +01:00
Sébastien Deleuze
737d77a739 Fix @Transactional support on functions returning Flow 
Closes gh-26052
 2020-11-09 17:45:28 +01:00
Sébastien Deleuze
1f13516528 Fix @Transactional support on suspending function 
With this commit, @Transactional on suspending functions
returning a value now commits the transaction properly.

Closes gh-25998
 2020-11-09 17:43:31 +01:00
Sébastien Deleuze
32238cc996 Add CoroutinesAnnotationTransactionInterceptorTests 
suspendingValueSuccess() currently fails due to an
unexpected rollback on transactional suspending functions
returning a value.

See gh-25998
 2020-11-09 10:19:24 +01:00
Sébastien Deleuze
d80dd50c9d Add CoroutinesAnnotationTransactionInterceptorTests 
suspendingValueSuccess() currently fails due to an
unexpected rollback on transactional suspending functions
returning a value.

See gh-25998
 2020-11-09 10:11:39 +01:00
Sébastien Deleuze
bdf120f1ef Add CoroutinesAnnotationTransactionInterceptorTests 
suspendingValueSuccess() currently fails due to an
unexpected rollback on transactional suspending functions
returning a value.

See gh-25998
 2020-11-09 10:10:25 +01:00
Sébastien Deleuze
e781d21097 Add CoroutinesAnnotationTransactionInterceptorTests 
suspendingValueSuccess() currently fails due to an
unexpected rollback on transactional suspending functions
returning a value.

See gh-25998
 2020-11-09 10:10:13 +01:00