Commit Graph

12 Commits

Author SHA1 Message Date
Brian Clozel
96a429a561 Move reactive server instrumentation out of WebFilter
Prior to this commit, the Observation instrumentation for Reactive
server applications was implemented with a `WebFilter`. This allowed to
record observations and set up a tracing context for the controller
handlers.

The limitation of this approach is that all processing happening at a
lower level is not aware of any observation. Here, the
`HttpWebHandlerAdapter` handles several interesting aspects:

* logging of HTTP requests and responses at the TRACE level
* logging of client disconnect errors
* handling of unresolved errors

With the current instrumentation, these logging statements will miss the
tracing context information. As a result, this commit deprecates the
`ServerHttpObservationFilter` in favor of a more direct instrumentation
of the `HttpWebHandlerAdapter`. This enables a more precise
instrumentattion and allows to set up the current observation earlier in
the reactor context: log statements will now contain the relevant
information.

Fixes gh-30013
2023-05-22 11:03:02 +02:00
Stephane Nicoll
0bd0578ff9 Merge branch '6.0.x' 2023-05-11 16:36:38 +02:00
Stephane Nicoll
a9b94241af Fix typo
Closes gh-30473
2023-05-11 16:35:20 +02:00
rstoyanchev
73d30dd875 Polishing contribution
Closes gh-30403
2023-05-05 20:53:52 +01:00
Olga MaciaszekSharma
033548a760 Remove default blockTimeout on interface clients
See gh-30403
2023-05-05 20:53:52 +01:00
Rob Winch
3774e9be7a Trim IDs with parent 2023-05-04 15:35:05 +01:00
Rob Winch
68235464fc Use include-code Macro 2023-05-04 15:35:05 +01:00
Rob Winch
35229c8bff Enable Section Summary TOC for small pages 2023-05-04 15:35:05 +01:00
Rob Winch
139cde47e2 Fix cross references 2023-05-04 15:35:05 +01:00
Rob Winch
9f49d24833 Split files 2023-05-04 15:35:05 +01:00
Rob Winch
9ceb75b228 Insert explicit ids for headers 2023-05-04 15:35:05 +01:00
Rob Winch
3fe7c65218 Migrate Structure 2023-05-04 15:35:05 +01:00