Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
14,843 Commits 18 Branches 0 Tags
4b1478d830f3cdbc4eb0d50d84f152d7900f30c3
Commit Graph

192 Commits

Author SHA1 Message Date
diguage
4b1478d830 Replace relevant code with lambda 
See gh-1454
 2017-06-13 08:55:38 +02:00
Juergen Hoeller
738160538e TargetSource.getTarget() is nullable again (for compatibility with MethodInvocation.getThis) 
Issue: SPR-15651
 2017-06-13 03:11:36 +02:00
Juergen Hoeller
47ec966757 TargetSource.getTarget() is nullable again (for compatibility with MethodInvocation.getThis) 
Issue: SPR-15651
 2017-06-12 22:54:18 +02:00
Juergen Hoeller
fd53d2a51a Consistent use of @Nullable in spring-test 
This commit also removes nullability from two common spots: ResolvableType.getType() and TargetSource.getTarget(), both of which are never effectively null with any regular implementation. For such scenarios, a non-null empty type/target is the cleaner contract.

Issue: SPR-15540
 2017-06-08 22:52:59 +02:00
Juergen Hoeller
f813712f5b Consistent use of @Nullable across the codebase (even for internals) 
Beyond just formally declaring the current behavior, this revision actually enforces non-null behavior in selected signatures now, not tolerating null values anymore when not explicitly documented. It also changes some utility methods with historic null-in/null-out tolerance towards enforced non-null return values, making them a proper citizen in non-null assignments.

Some issues are left as to-do: in particular a thorough revision of spring-test, and a few tests with unclear failures (ignored as "TODO: NULLABLE") to be sorted out in a follow-up commit.

Issue: SPR-15540
 2017-06-07 14:19:15 +02:00
Sebastien Deleuze
b47d713e14 Add missing @Nullable annotations on parameters 
Issue: SPR-15540
 2017-05-31 16:56:08 +02:00
Sebastien Deleuze
87598f48e4 Introduce null-safety of Spring Framework API 
This commit introduces 2 new @Nullable and @NonNullApi
annotations that leverage JSR 305 (dormant but available via
Findbugs jsr305 dependency and already used by libraries
like OkHttp) meta-annotations to specify explicitly
null-safety of Spring Framework parameters and return values.

In order to avoid adding too much annotations, the
default is set at package level with @NonNullApi and
@Nullable annotations are added when needed at parameter or
return value level. These annotations are intended to be used
on Spring Framework itself but also by other Spring projects.

@Nullable annotations have been introduced based on Javadoc
and search of patterns like "return null;". It is expected that
nullability of Spring Framework API will be polished with
complementary commits.

In practice, this will make the whole Spring Framework API
null-safe for Kotlin projects (when KT-10942 will be fixed)
since Kotlin will be able to leverage these annotations to
know if a parameter or a return value is nullable or not. But
this is also useful for Java developers as well since IntelliJ
IDEA, for example, also understands these annotations to
generate warnings when unsafe nullable usages are detected.

Issue: SPR-15540
 2017-05-27 08:57:01 +02:00
Juergen Hoeller
3cc94ae8b5 Consistently accept "taskExecutor" bean of type Executor (as stated in @EnableAsync's javadoc) 
Issue: SPR-15566
 2017-05-25 23:37:02 +02:00
Juergen Hoeller
6c43d14a77 Async annotations on interface methods with CGLIB proxies 
Issue: SPR-14949
 2017-04-26 18:16:40 +02:00
John Ryan
33d7816de3 Remove extraneous asterisk 
Closes gh-1397
 2017-04-21 09:48:03 +02:00
Juergen Hoeller
43e806c733 Refined log message for interface-implementing method 
Issue: SPR-15436
(cherry picked from commit 665e6cf)
 2017-04-17 19:47:24 +02:00
Juergen Hoeller
0d0b879a23 CglibAopProxy logs explicit warning for interface-implementing method marked as final 
Issue: SPR-15436
 2017-04-17 15:02:13 +02:00
Juergen Hoeller
9abf249cee Explicitly replace target ApplicationListener with singleton proxy, if any (avoiding double registration/invocation) 
Issue: SPR-15452
 2017-04-15 14:10:28 +02:00
Stephane Nicoll
bf6e7d0c26 Update copyright header 
Closes gh-1382
 2017-04-09 09:47:16 +02:00
John S. Ryan
9287bbb91a Fix typo in AfterReturningAdviceInterceptor JavaDoc 
See gh-1382
 2017-04-09 09:45:46 +02:00
Juergen Hoeller
67ea4b3a05 package-info for repackaged libraries (and other polishing) 2017-04-06 14:10:46 +02:00
Juergen Hoeller
f4de1ea147 Polishing 2017-02-22 15:32:19 +01:00
Juergen Hoeller
5f531a7a7d Comparators entry point with generically typed factory methods 
Issue: SPR-14779
 2017-02-15 18:05:32 +01:00
Juergen Hoeller
1b2dc3638f Revisit Assert to avoid single-arg assert methods (with refined messages) 
Issue: SPR-15196
 2017-01-30 22:15:55 +01:00
Juergen Hoeller
ed40b1c8ee Remove outdated abstractions/delegates from core/util 
Issue: SPR-15159
 2017-01-23 13:41:55 +01:00
Juergen Hoeller
fc629bb508 Polishing 2016-12-29 22:39:36 +01:00
Juergen Hoeller
a8741dd371 Polishing 2016-12-26 11:26:58 +01:00
Juergen Hoeller
f51fe5fd39 Polishing 2016-12-23 12:27:07 +01:00
Juergen Hoeller
d64d9ab370 Consistent ClassLoader propagation and ConcurrentHashMap setup for AspectJ pointcuts 
Issue: SPR-15040
 2016-12-22 17:00:04 +01:00
Juergen Hoeller
97ea22cb4a Defensively catch any exception from match attempts (for compatibility with AspectJ 1.8.10) 
Issue: SPR-15019
 2016-12-20 12:17:51 +01:00
Juergen Hoeller
3370f41c61 Defensively catch IllegalStateException from match attempts (for compatibility with AspectJ 1.8.10) 
Issue: SPR-15019
 2016-12-14 22:06:13 +01:00
Juergen Hoeller
6d1cae2f57 Avoid proxy replacement for generic return type signatures 
Issue: SPR-15010
 2016-12-14 22:00:41 +01:00
Juergen Hoeller
84d3808b3b Upgrade to Mockito 2.2 
Issue: SPR-14880
 2016-11-03 22:53:35 +01:00
Juergen Hoeller
5ac5ec1046 No external locking for singleton advice/aspect beans 
Issue: SPR-14324
 2016-10-28 23:35:01 +02:00
Juergen Hoeller
3726c6f18d Polishing 2016-10-21 12:26:27 +02:00
Juergen Hoeller
cfa0f6c84b Consistent final logger fields 2016-10-04 23:00:36 +02:00
Juergen Hoeller
214c919742 AspectJ bean pointcut supports qualifier match 
Issue: SPR-11217
 2016-08-17 00:43:41 +02:00
Juergen Hoeller
b9ab895743 Inferred generics for newSetFromMap arrangements 
Issue: SPR-13188
 2016-07-26 21:26:31 +02:00
Juergen Hoeller
0e3f0bd9d0 Avoid JDK proxy against CGLIB Factory interface and assert required type when resolving dependency 
Issue: SPR-14478
 2016-07-20 18:05:51 +02:00
Juergen Hoeller
aaac199e8b Consistently use constructor-based instantiation instead of Class.newInstance / BeanUtils.instantiate 
Issue: SPR-14486
 2016-07-19 19:21:06 +02:00
Juergen Hoeller
a1f5fb53db Java 8 getParameterCount() instead of getParameterTypes().length 
Issue: SPR-13188
 2016-07-07 01:04:24 +02:00
Stephane Nicoll
e4b0486c5a Add @FunctionalInterface on candidate interfaces 
Issue: SPR-14432
 2016-07-06 14:32:13 +02:00
Stephane Nicoll
00d2606b00 Explicit type can be replaced by <> 
Issue: SPR-13188
 2016-07-05 17:00:34 +02:00
Juergen Hoeller
0fc0ce78ae Drop deprecated dependencies on Log4j, JRuby, JExcel, Burlap, Commons Pool/DBCP 
This commit also removes outdated support classes for Oracle, GlassFish, JBoss.

Issue: SPR-14429
 2016-07-05 15:46:53 +02:00
Juergen Hoeller
51252ebbca Avoid defensive checks against Java 8 API (java.util.Optional etc) 
This commit also fixes broken javadoc links and code references.

Issue: SPR-13188
 2016-07-05 02:09:00 +02:00
Juergen Hoeller
fd9d518c36 Avoid potential deadlock in AbstractBeanFactoryPointcutAdvisor 
Issue: SPR-14388
 2016-06-22 14:41:20 +02:00
Juergen Hoeller
8cb9d5ebae EnableAspectJAutoProxy features exposeProxy flag (analogous to XML namespace) 
Issue: SPR-10454
 2016-06-20 13:50:04 +02:00
Juergen Hoeller
162aedccbe Polishing 2016-05-04 17:02:16 +02:00
Juergen Hoeller
e6e3ca3e96 LazySingletonAspectInstanceFactoryDecorator uses shared singleton mutex 
Issue: SPR-14241
 2016-05-04 09:03:28 +02:00
Johnny Lim
44e652f99e Remove duplicate words 
Closes gh-1039
 2016-04-19 08:24:21 +02:00
Juergen Hoeller
999112216d AopUtils.canApply properly matches package-visible methods (aligned with advice matching within proxies) 
Also, AbstractAutoProxyCreator considers Pointcut as infrastructure class, analogous to Advice and Advisor.

Issue: SPR-14174
 2016-04-14 21:46:25 +02:00
Juergen Hoeller
54aeb7a5d6 Cache key classes implement Comparable and consistently provide a toString representation 
Issue: SPR-14017
 2016-03-26 14:32:10 +01:00
Juergen Hoeller
517ebd1d3e Consistent formatting 2016-03-24 19:22:50 +01:00
Juergen Hoeller
6e3fac85f3 AnnotationAwareOrderComparator uses DecoratingProxy interface for target class introspection 
Issue: SPR-13884
 2016-03-18 22:12:10 +01:00
Juergen Hoeller
f2f87ff1e0 Explicit javadoc references to BeanFactory-based default executor lookup 
Issue: SPR-14030
 2016-03-11 23:52:31 +01:00