Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
18,905 Commits 18 Branches 0 Tags
521539b68e6b5ec91bbbb43e1601117a141ff670
Commit Graph

1732 Commits

Author SHA1 Message Date
Johnny Lim
ef704aa531 Polish FormattingConversionServiceTests 
See gh-23162
 2019-06-20 08:40:47 +02:00
Juergen Hoeller
0a77477d32 Merge branch '5.1.x' 2019-06-12 18:16:30 +02:00
Juergen Hoeller
fc46abf0b7 Polishing 2019-06-12 18:04:06 +02:00
Juergen Hoeller
7e02358166 Merge branch '5.1.x' 2019-06-12 00:05:01 +02:00
Juergen Hoeller
33b5bc2aae Polishing 2019-06-11 23:50:29 +02:00
Phillip Webb
5e505ce3a9 Add FormatterRegistry addPrinter/addParser methods 
Update `FormatterRegistry` with `addPrinter` and `addParser` methods
that can be used to register Printer or Parser implementations in a
similar way to the existing `addFormatter` method.

Closes gh-23110
 2019-06-11 14:47:42 -07:00
Juergen Hoeller
a89bfffd8c Merge branch '5.1.x' 2019-06-11 23:16:03 +02:00
Juergen Hoeller
7dc92aa05d Polishing 2019-06-11 20:57:27 +02:00
Sebastien Deleuze
098ac0bbb8 Annotate Object#equals parameter with @Nullable 
Closes gh-23093
 2019-06-06 14:18:30 +02:00
Sam Brannen
3794a57651 Improve AnnotationProcessorPerformanceTests with Awaitility 2019-05-30 12:07:30 +02:00
Sam Brannen
30944ed2e2 Attempt to make AbstractSchedulingTaskExecutorTests more robust 2019-05-27 13:02:30 +02:00
Sam Brannen
32277b74db Attempt to make AbstractSchedulingTaskExecutorTests more robust 2019-05-27 12:01:34 +02:00
Juergen Hoeller
8f972a5a60 Merge branch '5.1.x' 2019-05-24 23:46:25 +02:00
Juergen Hoeller
80c6f2bcf9 Polishing 2019-05-24 23:31:32 +02:00
Juergen Hoeller
4d97a05fbc SpringValidatorAdapter applies MessageFormat to {0}-containing message 
Closes gh-23014
 2019-05-24 23:31:06 +02:00
Juergen Hoeller
3c3d828e6c Actually test LiteConfiguration arrangement 
Closes gh-23013
 2019-05-24 23:18:10 +02:00
Phillip Webb
9d74da006c Migrate JUnit 4 assertions to AssertJ 
Migrate all existing JUnit 4 `assert...` based assertions to AssertJ
and add a checkstyle rule to ensure they don't return.

See gh-23022
 2019-05-23 15:52:49 -07:00
Phillip Webb
95a9d46a87 Migrate Hamcrest assertions to AssertJ 
Migrate all existing `assertThat(..., Matcher)` assertions to AssertJ
and add checkstyle rules to ensure they don't return.

See gh-23022
 2019-05-23 15:49:59 -07:00
Rossen Stoyanchev
5f7541344a Fix test failing after #99302f 2019-05-23 10:41:08 -04:00
Rossen Stoyanchev
3a5fb1fdf3 Fix test failing after #99302f 2019-05-23 10:38:08 -04:00
Phillip Webb
02850f357f Migrate exception checking tests to use AssertJ 
Migrate tests that use `@Test(expectedException=...)` or
`try...fail...catch` to use AssertJ's `assertThatException`
instead.
 2019-05-20 10:47:53 -07:00
Sam Brannen
73dbd06361 Enforces static imports for JUnit 4 assertions and assumptions 
This commit configures Checkstyle to enforces static imports for JUnit 4
assertions and assumptions.

See gh-22932
 2019-05-12 15:13:07 +02:00
Sam Brannen
deecab6311 Use assertThat from Hamcrest instead of JUnit 4 
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.

See gh-22894
 2019-05-12 14:46:55 +02:00
Sam Brannen
724c805211 Discontinue use of JUnit 3 APIs 
This commit also ensures that the JSR-330 TCK is executed with the
normal build by adhering to naming conventions for test classes.

See gh-22894
 2019-05-12 14:46:55 +02:00
Phillip Webb
798b51f4a3 Migrate to BDD Mockito 
Migrate all tests to consistently use BDD Mockito. Also add
checksyle rule to enforce going forwards.
 2019-05-08 13:46:13 -07:00
Phillip Webb
816bbee8de Remove '.*' imports from tests 
Organize test imports to expand all '.*' static imports into
fully qualified imports.

This update will allow us to use additional checkstyle rules in
the future, and will also help if we migrate fully to AssertJ.
 2019-05-08 09:55:09 -07:00
Phil Webb
d7320de871 Migrate away from ExpectedException (#22922) 
* Add limited checkstyles to test code

Add a limited set of checkstyle rules to the test codebase to improve
code consistency.

* Fix checksyle violations in test code

* Organize imports to fix checkstyle for test code

* Migrate to assertThatExceptionOfType

Migrate aware from ExpectedException rules to AssertJ exception
assertions. Also include a checkstyle rules to ensure that the
the ExpectedException is not accidentally used in the future.

See gh-22894
 2019-05-08 16:25:52 +02:00
Juergen Hoeller
cdf51c3d51 Nullability refinements and related polishing 2019-05-08 00:27:56 +02:00
Phillip Webb
7031964e49 Deprecate StandardMetadata constructors 
Deprecate the public `StandardMetadata` constructors to make it clearer
that these classes should not be instantiated directly. A new
`AnnotationMetadata.introspect` factory method has been added which
can now be used to obtain instances.

This change will allow use to make the constructors package private
and drop the `nestedAnnotationsAsMap` parameter in a future release.

Closes gh-22906
 2019-05-07 23:12:42 +02:00
Phillip Webb
8a293f51a4 Don't expose RetentionPolicy.CLASS annotations 
Update ASM based metadata readers so that only RetentionPolicy.RUNTIME
annotations are exposed. This aligned behavior with the reflection based
implementation.

Closes gh-22886
 2019-05-07 23:12:42 +02:00
Juergen Hoeller
fff3813d75 Properly detect importing class metadata for lite configuration class 
Closes gh-22920
 2019-05-07 21:23:47 +02:00
Sam Brannen
ccb01e663a Merge branch '5.1.x' 2019-05-07 13:03:45 +02:00
Sam Brannen
4aaec942c4 Introduce HTTPS mappings in spring.schemas files 
Closes gh-22903
 2019-05-07 12:56:42 +02:00
Sam Brannen
c79fdfb668 Use assertThat from Hamcrest instead of JUnit 4 
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.

See gh-22894
 2019-05-05 18:09:11 +02:00
Sebastien Deleuze
fc8d5c068c Support final @Configuration(proxyBeanMethods = false) classes 
Closes gh-22869
 2019-05-03 13:45:14 +02:00
Juergen Hoeller
55418b256d Merge branch '5.1.x' 2019-04-26 16:56:04 +02:00
Juergen Hoeller
e5e2d2d661 Polishing (includes minor performance refinements from master) 2019-04-26 16:51:18 +02:00
Juergen Hoeller
ad497c259a Merge branch '5.1.x' 2019-04-25 14:55:04 +02:00
Juergen Hoeller
168a5159b8 Log ClassCastException from lambda-defined listener at trace level 
Closes gh-22834
 2019-04-25 14:31:57 +02:00
Сергей Цыпанов
18af3892dd Make inner classes static where possible 
Closes gh-22804
 2019-04-17 19:05:24 +02:00
Sam Brannen
5b17bb2e14 Polish Javadoc for @Scheduled 2019-04-09 19:12:06 +02:00
P. Ottlinger
85597f29f2 Improve @Scheduled Javadoc regarding cron element order 
Closes gh-22777
 2019-04-09 19:03:30 +02:00
Juergen Hoeller
dc14ea86eb Fix regression for nested AnnotationAttributes.annotationType() result 
See gh-22738
 2019-04-09 09:40:53 +02:00
Sam Brannen
bd414df944 Remove JMXMP from TestGroup 
Due to the changes in a7425c81c0, we no
longer need to execute tests using the JMXMP protocol in PERFORMANCE
builds.

This commit removes the JMXMP constant from the TestGroup enum and
updates affected tests, thereby effectively including such tests in
the standard build from now on.

See gh-22757
 2019-04-08 17:05:16 +02:00
Juergen Hoeller
fd8fa301a6 Consistent non-exposure of inherited annotations in AnnotationMetadata 
Closes gh-22766
 2019-04-08 15:59:06 +02:00
Sebastien Deleuze
2e7ed915cd Merge branch '5.1.x' 2019-04-08 15:46:47 +02:00
Juergen Hoeller
43cb1af26a Polishing 2019-04-08 15:33:26 +02:00
Juergen Hoeller
a1efe3cfe5 Avoid MessageFormat processing for default Bean Validation messages 
Closes gh-22761
 2019-04-08 15:33:04 +02:00
Juergen Hoeller
fc9ce7cd99 Skip plain Java annotations in SourceClass.getAnnotations() upfront 
Includes direct reflective introspection of annotations when possible.

Closes gh-22750
 2019-04-08 15:32:52 +02:00
Juergen Hoeller
9de83674cd Complete set of registerBean methods on AnnotatedBeanDefinitionReader 
Includes bringing registerBean constructor-vararg variants up to GenericApplicationContext, making AnnotationConfigApplicationContext a straightforward subclass with a single template method to override.

See gh-22457
 2019-04-05 13:56:33 +02:00