Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
16,737 Commits 18 Branches 0 Tags
5cedd0d5d4c7bb8d0e06e355edb4f607283a895d
Commit Graph

248 Commits

Author SHA1 Message Date
Phillip Webb
5cedd0d5d4 Consistently use tabs rather than spaces 
Update code that has accidentally used spaces instead of tabs.
Also remove all trailing whitespace.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
634f5c2792 Ensure when equals() is implemented so is hashCode() 
Update classes that override `equals()` to ensure that they also
implement `hashCode()`.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
9de3689f63 Never use 'this.' when accessing loggers 
Ensure that `this.` is never used when accessing loggers.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
0b53c1096a Always use 'this.' when accessing fields 
Ensure that `this.` is used consistently when accessing class
fields.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
eeebd51f57 Use consistent class design 
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
866e9d702e Use consistent block style 
Update all code to use a consistent block style.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
e9d1b39aff Apply consistent copyright header 
Add copyright header to `package-info.java` files and fix a few
malformed headers on existing java files.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
c3a17dfd47 Ensure all files end with a newline 
Update all files to ensure that they always end with a new line.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
e0480f75ac Fix javadoc checkstyle issues 
Fix checkstyle violations for javadoc.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Juergen Hoeller
bba5dcaab3 AspectJExpressionPointcut evaluates interface method on proxy as well 
Issue: SPR-16803
 2018-05-16 00:43:51 +02:00
Juergen Hoeller
3917737df2 Polishing 2018-05-07 14:17:15 +02:00
Johnny Lim
fb898e1727 Remove inconsistent spaces 2018-05-05 11:07:35 +02:00
Juergen Hoeller
aa11721ff0 AopUtils.getMostSpecificMethod exposes dynamic proxy class methods 
Includes efficient canApply check for IntroductionAwareMethodMatcher.

Issue: SPR-16757
 2018-04-27 18:23:34 +02:00
Juergen Hoeller
b95e05db04 AspectJExpressionPointcut consistently resolves superinterface methods 
Includes efficient check for same ClassLoader in ClassUtils.isVisible, efficient MethodMatchers check for IntroductionAwareMethodMatcher, and supertype method resolution in MethodMapTransactionAttributeSource.

Issue: SPR-16723
 2018-04-14 15:10:05 +02:00
Juergen Hoeller
61c3db0869 MethodHandles.Lookup.defineClass for CGLIB class definition purposes 
Spring's CGLIB fork is patched with local copies of affected files here, introducing the notion of a "contextClass" (e.g. the proxy superclass) which gets passed through to ReflectUtils.defineClass for delegating to MethodHandles.Lookup.defineClass eventually, against a privateLookupIn(contextClass) lookup context on JDK 9/10/11.

Issue: SPR-15859
 2018-04-11 12:47:55 +02:00
Juergen Hoeller
6102715b8d Consistent treatment of proxy classes and interfaces for introspection 
Issue: SPR-16675
Issue: SPR-16677
 2018-04-03 02:42:41 +02:00
Juergen Hoeller
cc379f1cc7 Polishing 2018-04-01 12:57:19 +02:00
Juergen Hoeller
666037ec5c Pointcut checking directly against superclass in case of CGLIB subclass 
Issue: SPR-16675
 2018-04-01 12:57:02 +02:00
Juergen Hoeller
6393e5ce0c Consistent Ordered.LOWEST_PRECEDENCE declarations for default order 2018-03-31 00:20:44 +02:00
igor-suhorukov
93abe0e94b All branches in a conditional structure should not have exactly the same implementation 2018-03-29 23:33:50 +02:00
igor-suhorukov
e6020ed377 avoid unnecessary autoboxing 2018-03-28 23:48:12 +02:00
Christoph Dreis
d3a0a8e007 Use Collection.removeIf() where possible (#1747) 
Use Collection.removeIf() where possible

Issue: SPR-16622
 2018-03-22 11:36:11 +01:00
Juergen Hoeller
50253f670e Quick access to volatile field (full synchronization only for lazy init) 
Issue: SPR-16570
 2018-03-08 18:13:00 +01:00
Juergen Hoeller
139dc1d373 Polishing (collapsed if checks, consistent downcasts, refined javadoc) 2018-03-08 18:11:57 +01:00
igor-suhorukov
0f7485b01d Polish: reorder the modifiers to comply with the Java Language Specification. 2018-03-08 17:57:47 +01:00
Juergen Hoeller
a19d4deb24 Polishing 2018-02-28 16:41:59 +01:00
Juergen Hoeller
9962df6527 Polishing 2018-02-28 00:09:15 +01:00
igor-suhorukov
49fd724d8f Polish: String function use should be optimized for single characters 2018-02-25 20:48:47 +01:00
Juergen Hoeller
578c078082 Polishing 2018-02-22 15:14:20 +01:00
Juergen Hoeller
a5cbf5fe24 Consistent use of Collection.toArray with zero-sized array argument 
Includes consistent use of ClassUtils.toClassArray (as non-null variant)

Issue: SPR-16523
 2018-02-22 11:29:46 +01:00
Juergen Hoeller
8d3264f680 Prefer List.sort(Comparator) over Collections.sort(List, Comparator) 2018-02-16 10:23:18 +01:00
igor-suhorukov
2be4985b8f Polish: anonymous inner classes containing only one method should become lambdas, 
use getOrDefault instead of ternary operator
 2018-02-16 09:38:19 +01:00
Juergen Hoeller
b449928691 Avoid unused arguments for internal delegates 2018-02-13 11:40:28 +01:00
igor-suhorukov
9a6fbf59c5 Polish: follow name convention - make immutable fields final 2018-02-10 12:09:19 +01:00
Juergen Hoeller
0a06bce3a6 Relaxed BeanFactory assertion in resolveInterceptorNames 
Issue: SPR-16347
 2018-01-07 23:23:25 +01:00
nkjackzhang
ec6eed6c63 Polish Javadoc 
Closes gh-1627
 2017-12-23 14:19:56 +01:00
Juergen Hoeller
7ae59d0c2a Nullability refinements on private and static methods 
Based on IntelliJ IDEA 2017.3 introspection results.

Issue: SPR-15756
 2017-09-22 18:22:14 +02:00
Sebastien Deleuze
1bc93e3d0f Revisit nullability annotations 
This commit introduces the following changes.

1) It adds a new Spring @NonNull annotation which allows to apply
@NonNullApi semantic on a specific element, like @Nullable does.
Combined with @Nullable, it allows partial null-safety support when
package granularity is too broad.

2) @Nullable and @NonNull can apply to ElementType.TYPE_USE in order
to be used on generic type arguments (SPR-15942).

3) Annotations does not apply to ElementType.TYPE_PARAMETER anymore
since it is not supported yet (applicability for such use case is
controversial and need to be discussed).

4) @NonNullApi does not apply to ElementType.FIELD anymore since in a
lot of use cases (private, protected) it is not part for the public API
+ its usage should remain opt-in. A dedicated @NonNullFields annotation
has been added in order to set fields default to non-nullable.

5) Updated Javadoc and reference documentation.

Issue: SPR-15756
 2017-09-15 13:26:41 +02:00
Juergen Hoeller
47a7475898 Resolve remaining nullability warnings 
Issue: SPR-15869
 2017-08-18 00:15:46 +02:00
Sebastien Deleuze
73cf07e9a4 Fix overridden methods nullability 
Issue: SPR-15869
 2017-08-17 15:02:59 +02:00
Sebastien Deleuze
1e07468d20 Prevent warning about final private methods in CglibAopProxy 
Issue: SPR-15820
 2017-07-26 15:57:57 +02:00
Juergen Hoeller
6d6d772f31 Polishing 2017-07-20 00:14:56 +02:00
Juergen Hoeller
118d1470fd Ignore (Auto)Closeable for interface-based proxy decisions 
Issue: SPR-15779
 2017-07-19 22:40:45 +02:00
Juergen Hoeller
ac1d3b22c9 Polishing 2017-07-19 22:22:27 +02:00
Juergen Hoeller
46eba3dbfa Nullability fine-tuning around declaration inconsistencies 
Issue: SPR-15720
Issue: SPR-15792
 2017-07-19 22:22:20 +02:00
Sebastien Deleuze
fb4ddb0746 Make getters and setters null-safety consistent 
This commit ensure that null-safety is consistent between
getters and setters in order to be able to provide beans
with properties with a common type when type safety is
taken in account like with Kotlin.

It also add a few missing property level @Nullable
annotations.

Issue: SPR-15792
 2017-07-19 09:07:56 +02:00
Juergen Hoeller
c292a89b24 Http(Async)Client not actually nullable, plus MethodInterceptor nullability 
Issue: SPR-15720
 2017-07-19 00:15:37 +02:00
Juergen Hoeller
57f961e36b No nullability declarations in AOP Alliance sources 
Issue: SPR-15720
 2017-07-14 15:10:20 +02:00
Juergen Hoeller
6d7612e052 AbstractTraceInterceptor provides logExceptionStackTrace flag and writeToLog delegates 
Issue: SPR-15763
(cherry picked from commit aa0d7a6)
 2017-07-13 13:19:40 +02:00
Juergen Hoeller
19a8efc717 Revised assertions and $[invocationTime] support for exceptionMessage 
Issue: SPR-15763
 2017-07-12 19:13:12 +02:00