Rossen Stoyanchev
e9ed45ee3b
Fix code completion typo
2018-07-11 11:13:57 -04:00
Rossen Stoyanchev
7b3a72f483
Warn when SimpleAsyncTaskExecutor is used
...
Issue: SPR-16203
2018-07-11 11:10:03 -04:00
Rossen Stoyanchev
1b1bc7f5b5
Switch defaults and model for logging sensitive data
...
Issue: SPR-17029
2018-07-11 11:10:03 -04:00
Brian Clozel
d00f6f09a5
Polish ContentCachingRequestWrapper
...
Issue: SPR-15762
2018-07-09 19:15:29 +02:00
zilong6
4d0800f392
Improve ContentCachingRequestWrapper performance
...
This commit improves the performance of `read` method variants
to write to the cache in an optimized way.
Issue: SPR-15762
2018-07-09 19:15:21 +02:00
Arjen Poutsma
2ac6a15f6f
Add setBearerAuth method
...
Issue: SPR-16997
2018-07-09 17:06:55 +02:00
Arjen Poutsma
a663454fad
Changed Basic Authentication consumer to setBasicAuth method
...
This commit changes the Basic Authentication Consumer<HttpHeaders> to
a basic setBasicAuth(String, String) method.
Issue: SPR-16913
2018-07-09 16:41:51 +02:00
Rossen Stoyanchev
4bd22eeb13
Fallback logger for logging in http and codec packages
...
Issue: SPR-17012
2018-07-07 10:54:03 -04:00
Rossen Stoyanchev
bca9f51092
Polish hint for suppressing logging at Encoder/Decoder
2018-07-06 20:32:08 -04:00
Rossen Stoyanchev
2874dd75ca
Fine-tune WebFlux logging at HTTP/WebSocket level
...
1. Use special category prefix "spring-web.reactivestreams" for logging
of reactive streams signals in spring-web, since those are quite
verbose would fill the logs at TRACE.
2. Add and use loggers in request and websocket session implementations
separate from reactive streams bridge for regular TRACE logging.
3. Improve log messages and add where missing (e.g. for Reactor)
Issue: SPR-16898
2018-07-06 17:33:16 -04:00
Rossen Stoyanchev
7746878b50
Remove workaround for Reactor Netty #171
2018-07-06 15:44:24 -04:00
Rossen Stoyanchev
bc3cf0eeb8
Expose request id at the ServerHttpRequest level
...
Hiding it (at AbstractServerHttpRequest) complicates matters since
requests are often mutated and decorated, plus it's also possible to
implement the interface directly (we've one, albeit corner case).
Issue: SPR-16966
2018-07-06 15:44:24 -04:00
Rossen Stoyanchev
5dc49b16ea
Correlated messages at HTTP adapter + WebSocket level
...
Issue: SPR-16966
2018-07-06 15:44:18 -04:00
Rossen Stoyanchev
39d5874441
Use connection id in server log messages if possible
...
Issue: SPR-16966
2018-07-05 08:32:27 -04:00
Rossen Stoyanchev
5cdc26770e
Correlated WebClient log messages
...
Issue: SPR-16966
2018-07-05 08:30:23 -04:00
Rossen Stoyanchev
82310660fd
Correlated encoding/decoding log messages via hints
...
Issue: SPR-16966
2018-07-05 08:28:15 -04:00
Rossen Stoyanchev
fd90b73748
Correlated WebFlux server log messages
...
Issue: SPR-16966
2018-07-05 08:27:13 -04:00
Juergen Hoeller
83faee67d5
HttpMessageNotReadableException provides access to HttpInputMessage
...
Issue: SPR-15588
2018-07-04 22:46:09 +02:00
Rossen Stoyanchev
43d6ceb6f0
Align settings for sameSite and secure flag
...
After this change sameSite still gets a default value of "Strict" in
CookieWebSessionIdResolver but for changes to either sameSite or secure
it is now expected to use
addCookieInitializer(Consumer<ResponseCookie.ResponseCookieBuilder>).
Issue: SPR-16418, SPR-16980
2018-07-03 12:44:29 -04:00
Juergen Hoeller
e485abbe56
Fix checkstyle violation (plus related polishing)
...
Issue: SPR-16913
2018-07-02 23:56:58 +02:00
Juergen Hoeller
d08b72a75a
Consistent throwing of HttpMessageNotReadableException vs IOException
...
Includes specific fine-tuning of ProtobufHttpMessageConverter and JAXB2 based message converters, as well as revised javadoc for abstract base classes.
Issue: SPR-16995
2018-07-02 22:37:29 +02:00
Arjen Poutsma
6bcf6ffb06
Add Basic Authentication Consumer
...
Issue: SPR-16913
2018-07-02 15:16:03 +02:00
Juergen Hoeller
4ff1e3e74b
Consistent abstract declaration for utility classes (plus polishing)
...
Issue: SPR-16968
2018-07-01 02:31:20 +02:00
Rossen Stoyanchev
e72f4ec501
Fix checkstyle error
2018-06-29 21:45:43 -04:00
Rossen Stoyanchev
51ec7c6b4a
Add hook for customizing response cookie
...
Issue: SPR-16980
2018-06-29 18:15:52 -03:00
Rossen Stoyanchev
5ec8db1adc
Polish CookieWebSessionIdResolver
2018-06-29 18:15:52 -03:00
Damiano Albani
3165b3c024
Fix typo in Java doc
2018-06-29 18:12:43 -03:00
Juergen Hoeller
e22466e9d5
Polishing
2018-06-29 19:44:15 +02:00
Juergen Hoeller
d34e6f7f70
Polishing
2018-06-28 18:02:07 +02:00
Juergen Hoeller
40efcc933c
Polishing
2018-06-28 14:51:33 +02:00
Juergen Hoeller
bac68c8d3f
StandardServletMultipartResolver accepts any HTTP method for multipart
...
Issue: SPR-16975
2018-06-28 14:15:16 +02:00
Phillip Webb
81451aa800
Organize imports
...
Reorganize imports to ensure consistent ordering. This commit also
expands any `.*` static imports in favor of using fully-qualified
method references.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
Phillip Webb
5cedd0d5d4
Consistently use tabs rather than spaces
...
Update code that has accidentally used spaces instead of tabs.
Also remove all trailing whitespace.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
Phillip Webb
9de3689f63
Never use 'this.' when accessing loggers
...
Ensure that `this.` is never used when accessing loggers.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
Phillip Webb
0b53c1096a
Always use 'this.' when accessing fields
...
Ensure that `this.` is used consistently when accessing class
fields.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
Phillip Webb
eeebd51f57
Use consistent class design
...
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
Phillip Webb
0ad0f341bd
Don't use single letter catch variables
...
Update existing catch blocks to ensure that `ex` is always used
in preference to `e` or `t` as the variable name.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
Phillip Webb
866e9d702e
Use consistent block style
...
Update all code to use a consistent block style.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
Phillip Webb
04a8c285df
Fix annotation styling issues
...
Update all annotations so that each is on its own line and
consistently use the short form (i.e. don't use `value=`) when
possible.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
Phillip Webb
e9d1b39aff
Apply consistent copyright header
...
Add copyright header to `package-info.java` files and fix a few
malformed headers on existing java files.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
Phillip Webb
c3a17dfd47
Ensure all files end with a newline
...
Update all files to ensure that they always end with a new line.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
Phillip Webb
e0480f75ac
Fix javadoc checkstyle issues
...
Fix checkstyle violations for javadoc.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
Rossen Stoyanchev
7ccd2b024d
Refine logging for async requests
...
Issue: SPR-16898
2018-06-25 14:42:29 -03:00
Juergen Hoeller
2a15962d7f
WebHttpHandlerBuilder retains ApplicationContext in copy constructor
...
Issue: SPR-16972
2018-06-25 18:12:12 +02:00
Rossen Stoyanchev
900bc8a2e3
Logging improvements for WebFlux
...
Issue: SPR-16898
2018-06-22 22:44:24 -04:00
Brian Clozel
4a26f93a0d
WebClient writes Content-Length for Mono bodies
...
In SPR-16892, the `EncoderHttpMessageWriter` has been improved to write
`"Content-Length"` HTTP response headers if the response body is of type
`Mono` (i.e. the actual content length is easily accessible without
buffering a possibly large response body). That change was relying on
the fact that the server side is using a `ChannelSendOperator` to delay
the writing of the body until the first signal is received.
This strategy is not effective on the client side, since no such channel
operator is used for `WebClient`. This commit improves
`EncoderHttpMessageWriter` and delays, for `Mono` HTTP message bodies
only, the writing of the body so that we can write the
`"Content-Length"` header information once we've got the body resolved.
Issue: SPR-16949
2018-06-19 11:51:45 +02:00
Rossen Stoyanchev
28a5c3009e
Improve DEBUG/TRACE logging for Spring MVC
...
Issue: SPR-16898
2018-06-18 18:33:11 -04:00
Juergen Hoeller
003d643adc
Consistent support for new JsonMappingException wording in Jackson 2.9
...
Issue: SPR-16947
2018-06-17 21:42:20 +02:00
Mark Chesney
e4666c17ec
Support new exception message wording since Jackson 2.9
...
The wording changed from "Can not find" to "Cannot find" via PR #1682
Issues: SPR-16947
2018-06-17 13:27:20 +02:00
Rossen Stoyanchev
ebdcc015a4
Correctly set maxAge and expires in ResponseCookie
...
Issue: SPR-16940
2018-06-14 13:07:17 -04:00