Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
19,547 Commits 18 Branches 0 Tags
6fbd4841ec4a20cfd8c5338c6bcf0171839c2326
Commit Graph

18 Commits

Author SHA1 Message Date
Phillip Webb
6fbd4841ec Update checkstyle import rule 
Update the checkstyle rule to enforce the blank line between `java`
and `javax`.

Closes gh-23539
 2019-09-04 22:06:46 -07:00
Sam Brannen
652db21d3e Ensure Hamcrest imports are properly banned 2019-09-03 16:01:30 +02:00
Phillip Webb
f8a93ee4a7 Add SpringJUnit5 checkstyle rule 
Add `SpringJUnit5` checkstyle rule to ensure that JUnit 4 annotations
aren't accidentally used in new tests.

The "must not be public" rule has been suppressed since there are
quite a few tests that extend base tests from other packages.
 2019-08-17 08:31:23 -07:00
Juergen Hoeller
a5cb8799fa Merge branch '5.1.x' 2019-07-05 18:22:02 +02:00
Juergen Hoeller
aeef95938e SpringValidatorAdapter's ObjectError subclasses are serializable 
Closes gh-23181
 2019-07-05 17:07:01 +02:00
Sam Brannen
141ef9082f Clean up Mockito usage 
This commit migrates to the MockitoJUnitRunner where sensible, which
will later allow for an easier migration to Mockito's extension for
JUnit Jupiter.

In addition, this commit deletes unnecessary stubbing for various mocks
and polishes test fixture setup in various test classes.
 2019-05-28 13:59:43 +02:00
Sam Brannen
4f4427f550 Migrate TestNG assertions to AssertJ 
Migrate all existing TestNG based assertions to AssertJ and add
Checkstyle rules to ensure they don't return.

See gh-23022
 2019-05-26 18:29:39 +02:00
Sam Brannen
5a1217cafe Migrate JUnit Jupiter assertions to AssertJ 
Migrate all existing JUnit Jupiter based assertions to AssertJ and add
Checkstyle rules to ensure they don't return.

See gh-23022
 2019-05-24 18:50:01 +02:00
Phillip Webb
9d74da006c Migrate JUnit 4 assertions to AssertJ 
Migrate all existing JUnit 4 `assert...` based assertions to AssertJ
and add a checkstyle rule to ensure they don't return.

See gh-23022
 2019-05-23 15:52:49 -07:00
Phillip Webb
95a9d46a87 Migrate Hamcrest assertions to AssertJ 
Migrate all existing `assertThat(..., Matcher)` assertions to AssertJ
and add checkstyle rules to ensure they don't return.

See gh-23022
 2019-05-23 15:49:59 -07:00
Phillip Webb
02850f357f Migrate exception checking tests to use AssertJ 
Migrate tests that use `@Test(expectedException=...)` or
`try...fail...catch` to use AssertJ's `assertThatException`
instead.
 2019-05-20 10:47:53 -07:00
Sam Brannen
73dbd06361 Enforces static imports for JUnit 4 assertions and assumptions 
This commit configures Checkstyle to enforces static imports for JUnit 4
assertions and assumptions.

See gh-22932
 2019-05-12 15:13:07 +02:00
Sam Brannen
5685e9dfa3 Add Checkstyle rules for deprecated JUnit APIs 
This commit adds Checkstyle rules to disallow imports of the following.

- junit.framework.*
- org.junit.Assert.assertThat
- org.junit.Assume.assumeThat

See gh-22894
 2019-05-12 14:46:55 +02:00
Phillip Webb
798b51f4a3 Migrate to BDD Mockito 
Migrate all tests to consistently use BDD Mockito. Also add
checksyle rule to enforce going forwards.
 2019-05-08 13:46:13 -07:00
Phil Webb
d7320de871 Migrate away from ExpectedException (#22922) 
* Add limited checkstyles to test code

Add a limited set of checkstyle rules to the test codebase to improve
code consistency.

* Fix checksyle violations in test code

* Organize imports to fix checkstyle for test code

* Migrate to assertThatExceptionOfType

Migrate aware from ExpectedException rules to AssertJ exception
assertions. Also include a checkstyle rules to ensure that the
the ExpectedException is not accidentally used in the future.

See gh-22894
 2019-05-08 16:25:52 +02:00
Sam Brannen
68de9820dc Upgrade to latest Checkstyle DTDs 
See gh-22634
 2019-03-23 15:40:10 +01:00
Sam Brannen
3967082c77 Upgrade to latest Checkstyle DTD 
See http://checkstyle.sourceforge.net/config.html#Configuration_XML_Structure
 2019-03-15 16:32:20 +01:00
Phillip Webb
032096d699 Add checkstyle to build 
Add checkstyle to the build to enforce Spring Framework coding
conventions. Rule suppressions are used for several classes where
relaxing the rules makes more sense than fixing them.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00