Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
16,751 Commits 18 Branches 0 Tags
7a02e438e7fa64840ee645fd4873bb074e694625
Commit Graph

775 Commits

Author SHA1 Message Date
Juergen Hoeller
bf5fe46fa9 CachedIntrospectionResults completely traverses interface hierarchy 
Issue: SPR-16978
 2018-06-28 14:15:16 +02:00
Juergen Hoeller
81cb740e0a New postProcessProperties variant on InstantiationAwareBeanPostProcessor 
Allows for skipping the now-deprecated postProcessPropertyValues callback with its expensive PropertyDescriptor retrieval requirement. RequiredAnnotationBeanPostProcessor (which is dependent on postProcessPropertyValues) and the @Required annotation itself are also deprecated now: in favor of constructor injection (or afterPropertiesSet).

Issue: SPR-16918
 2018-06-28 14:15:16 +02:00
Phillip Webb
a89e716cc7 Use tabs rather than spaces in tests 
Update tests to ensure that tabs are used instead of spaces. Also
consistently apply a new line at the end of each file.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
5cedd0d5d4 Consistently use tabs rather than spaces 
Update code that has accidentally used spaces instead of tabs.
Also remove all trailing whitespace.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
634f5c2792 Ensure when equals() is implemented so is hashCode() 
Update classes that override `equals()` to ensure that they also
implement `hashCode()`.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
9de3689f63 Never use 'this.' when accessing loggers 
Ensure that `this.` is never used when accessing loggers.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
0b53c1096a Always use 'this.' when accessing fields 
Ensure that `this.` is used consistently when accessing class
fields.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
eeebd51f57 Use consistent class design 
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
8f9aa06dfe Polishing AbstractBeanDefinition.equals 2018-06-28 10:28:44 +02:00
Phillip Webb
866e9d702e Use consistent block style 
Update all code to use a consistent block style.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
04a8c285df Fix annotation styling issues 
Update all annotations so that each is on its own line and
consistently use the short form (i.e. don't use `value=`) when
possible.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
e0480f75ac Fix javadoc checkstyle issues 
Fix checkstyle violations for javadoc.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Sam Brannen
cafb5033e2 Polishing 2018-06-19 13:50:13 +03:00
Juergen Hoeller
51091f2242 Suppress deprecation warning in DefaultBeanDefinitionDocumentReader 
Issue: SPR-12458
 2018-06-15 22:09:23 +02:00
Juergen Hoeller
0777a80efe Polishing 
(cherry picked from commit a2765c0)
 2018-06-11 19:17:57 +02:00
Brian Clozel
0092653d42 Fix JDK9 build after Groovy 2.5 upgrade 
After the Groovy 2.5 upgrade, the Spring Framework build on JDK9 hit
GROOVY-8631. Adding the relevant `jax-api` dependency to the module
didn't fix this issue. The Groovy release notes mention the use of the
`--add-modules` JVM flag, but this is not an option for this build which
should run on JDK8 -> JDK11.

This commit changes the dependency from `groovy-all` to more focused
dependencies on Groovy in the `spring-beans` and `spring-context`
modules. This change seems to avoid the automatic loading of Groovy
enhancements to JAXB (shipped with `groovy-xml`).

See:

* http://groovy-lang.org/releasenotes/groovy-2.5.html#Groovy2.5releasenotes-Knownissues
* https://issues.apache.org/jira/browse/GROOVY-8631

Issue: SPR-15407
 2018-06-08 13:37:44 +02:00
Juergen Hoeller
7ece0e219e Correct code example for YamlProcessor.setDocumentMatchers 
Issue: SPR-16849
 2018-06-06 21:27:00 +02:00
Juergen Hoeller
74fcdea2d9 SimpleAliasRegistry logs info message for alias overriding 
Issue: SPR-16871
 2018-05-29 21:51:33 +02:00
Juergen Hoeller
46a89d9534 Restore lenient null return value for ConditionContext.getBeanFactory() 
Includes nullable return value for getClassLoader() with corresponding notes in applicable javadoc.

Issue: SPR-16866
 2018-05-29 21:51:06 +02:00
Juergen Hoeller
138b0d0bbd YamlProcessor embraces SnakeYAML 1.18+ duplicate key handling 
Includes removal of StrictMapAppenderConstructor for compatibility with SnakeYAML 1.21.

Issue: SPR-16791
 2018-05-05 12:47:11 +02:00
Juergen Hoeller
9281f820f1 Expose FactoryBean's raw object on retrieval during post-processing 
Issue: SPR-16783
 2018-05-02 15:21:40 +02:00
Stephane Nicoll
e51330e905 Keep YAML entries that haven an empty array value 
Prior to this commit, a YAML entry that define an empty array value was
lost. This commit makes sure to flag it with an empty String, which
corresponds as an empty comma separated list of entries in the
properties format.

Issue: SPR-16769
 2018-04-29 10:30:08 +02:00
Dimitrios (Dimi) Liapis
6d6da91ab9 Fix typo 
See gh-1803
 2018-04-21 18:16:13 +02:00
Juergen Hoeller
b95e05db04 AspectJExpressionPointcut consistently resolves superinterface methods 
Includes efficient check for same ClassLoader in ClassUtils.isVisible, efficient MethodMatchers check for IntroductionAwareMethodMatcher, and supertype method resolution in MethodMapTransactionAttributeSource.

Issue: SPR-16723
 2018-04-14 15:10:05 +02:00
Juergen Hoeller
6184c4ecc9 Consistent getTypeForFactoryMethod result for parameterized method 
Issue: SPR-16720
 2018-04-12 15:14:41 +02:00
Juergen Hoeller
61c3db0869 MethodHandles.Lookup.defineClass for CGLIB class definition purposes 
Spring's CGLIB fork is patched with local copies of affected files here, introducing the notion of a "contextClass" (e.g. the proxy superclass) which gets passed through to ReflectUtils.defineClass for delegating to MethodHandles.Lookup.defineClass eventually, against a privateLookupIn(contextClass) lookup context on JDK 9/10/11.

Issue: SPR-15859
 2018-04-11 12:47:55 +02:00
Thor Andreas Rognan
17c16eaa9e Upgrade to Gradle 4.6 
Issue: SPR-16475
 2018-04-04 12:39:09 +02:00
Bian Jiaping
8f525f07e9 Fix typos, formatting and escaping in reference 
Note: Some symbol combinations (including <=) serve as textual symbol
replacements in AsciiDoc.

http://asciidoctor.org/docs/asciidoc-syntax-quick-reference/#text-replacement
 2018-03-30 10:06:33 -04:00
Juergen Hoeller
d553ddc5b3 Nullability refinements (based on IntelliJ IDEA 2018.1 introspection) 
Issue: SPR-15756
 2018-03-29 23:50:17 +02:00
igor-suhorukov
93abe0e94b All branches in a conditional structure should not have exactly the same implementation 2018-03-29 23:33:50 +02:00
Juergen Hoeller
e3d0ef6015 Use Map.forEach instead of manual Map.Entry iteration wherever possible 
Issue: SPR-16646
 2018-03-27 00:38:32 +02:00
Juergen Hoeller
24aae2e104 Defensive containsSingleton cache guard within getObjectFromFactoryBean 
Issue: SPR-16625
 2018-03-27 00:24:03 +02:00
Juergen Hoeller
8d5587fe4f Consistent thread-safe iteration in DefaultSingletonBeanRegistry 
Issue: SPR-16620
 2018-03-24 16:30:51 +01:00
Juergen Hoeller
8d8e218b52 Consistent FactoryBean cache visibility in concurrent creation scenarios 
Issue: SPR-16625
Issue: SPR-16627
 2018-03-23 17:34:33 +01:00
Juergen Hoeller
937cd48fcb Contextual BeanCreationException in case of depending on a missing bean 
Issue: SPR-16628
 2018-03-23 17:32:08 +01:00
Christoph Dreis
d3a0a8e007 Use Collection.removeIf() where possible (#1747) 
Use Collection.removeIf() where possible

Issue: SPR-16622
 2018-03-22 11:36:11 +01:00
Juergen Hoeller
499128dae7 URIEditor uses straight ClassPathResource.getURI() access 
Issue: SPR-16581
 2018-03-12 22:26:18 +01:00
igor-suhorukov
32b689a994 use StringBuilder for complex string concatenation 2018-03-08 21:25:47 +01:00
Juergen Hoeller
139dc1d373 Polishing (collapsed if checks, consistent downcasts, refined javadoc) 2018-03-08 18:11:57 +01:00
igor-suhorukov
0f7485b01d Polish: reorder the modifiers to comply with the Java Language Specification. 2018-03-08 17:57:47 +01:00
Juergen Hoeller
a02aafe5fe Regular getBeanInfo call for interfaces (enabling Introspector's cache) 
Issue: SPR-16568
 2018-03-08 12:29:09 +01:00
Juergen Hoeller
f57fcdee3c Polishing 2018-03-07 15:49:58 +01:00
Juergen Hoeller
4f8c4546f1 Upgrade to SnakeYAML 1.20 and Selenium 3.10 2018-03-05 15:25:01 +01:00
igor-suhorukov
129530f792 Polish 
Closes gh-1715
 2018-03-03 12:12:15 +01:00
Juergen Hoeller
bfddbbe731 Polishing 2018-03-01 01:39:06 +01:00
Juergen Hoeller
6f7ad0304c Polishing 2018-03-01 00:29:38 +01:00
igor-suhorukov
8080f56db8 Polish: "@Override" should be used on overriding and implementing methods 2018-03-01 00:15:18 +01:00
Juergen Hoeller
a19d4deb24 Polishing 2018-02-28 16:41:59 +01:00
Juergen Hoeller
9962df6527 Polishing 2018-02-28 00:09:15 +01:00
igor-suhorukov
d1ccecd021 Polish: to get rid unnecessary array creation 2018-02-27 23:37:54 +01:00