Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
16,751 Commits 18 Branches 0 Tags
7a02e438e7fa64840ee645fd4873bb074e694625
Commit Graph

432 Commits

Author SHA1 Message Date
Phillip Webb
a89e716cc7 Use tabs rather than spaces in tests 
Update tests to ensure that tabs are used instead of spaces. Also
consistently apply a new line at the end of each file.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
1c25cec44f Polish test code 
Polish a few issue identified when adding checkstyle to the
build. Although checkstyle is not enforcing rules on tests,
these are a few minor changes that are still worth making.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
81451aa800 Organize imports 
Reorganize imports to ensure consistent ordering. This commit also
expands any `.*` static imports in favor of using fully-qualified
method references.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
5cedd0d5d4 Consistently use tabs rather than spaces 
Update code that has accidentally used spaces instead of tabs.
Also remove all trailing whitespace.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
0b53c1096a Always use 'this.' when accessing fields 
Ensure that `this.` is used consistently when accessing class
fields.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
eeebd51f57 Use consistent class design 
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
866e9d702e Use consistent block style 
Update all code to use a consistent block style.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
e0480f75ac Fix javadoc checkstyle issues 
Fix checkstyle violations for javadoc.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Juergen Hoeller
7bce7504c7 JdbcTemplate consistently exposes first value of equally named columns 
Issue: SPR-16578
 2018-06-11 14:17:03 +02:00
Juergen Hoeller
25559b9e44 Polishing 2018-06-06 21:31:24 +02:00
Juergen Hoeller
0941081b0a Upgrade to HSQLDB 2.4.1, Derby 10.14.2.0, HtmlUnit 2.31, Selenium 3.12 2018-06-06 21:24:53 +02:00
Juergen Hoeller
d9c63182d9 MapSqlParameterSource.addValue declares nullable value parameter 
Issue: SPR-16843
 2018-05-18 22:20:29 +02:00
nkjackzhang
a1fa0daad5 Fix a typo in javadoc 
Closes gh-1824
 2018-05-10 17:32:21 +02:00
Johnny Lim
fb898e1727 Remove inconsistent spaces 2018-05-05 11:07:35 +02:00
Johnny Lim
8f21cb1a7c Polish DatabaseStartupValidator 2018-05-05 11:07:20 +02:00
Juergen Hoeller
e170cb0f79 Upgrade framework build to JPA 2.2 and JTA 1.3 
Issue: SPR-16685
 2018-04-11 16:06:10 +02:00
Juergen Hoeller
ff53d78e96 Remove bogus DataSource test from JpaTransactionManagerTests 2018-04-10 00:40:51 +02:00
Juergen Hoeller
475c4d4425 Polishing 2018-04-03 12:24:00 +02:00
Juergen Hoeller
0bc01fcd55 Polishing 2018-03-30 13:42:23 +02:00
Johnny Lim
8dd0974e2f Rename SingleColumnRowMapperTest to align with the other tests 2018-03-30 12:28:16 +02:00
Juergen Hoeller
9a722b4558 Pass type name into PreparedStatement.setNull in case of Types.OTHER 
Issue: SPR-16669
 2018-03-29 23:43:53 +02:00
nkjackzhang
82cb5dbf2b NamedParameterUtils.parseSqlStatement should parse :{x} style parameter correctly 
In my opinion, we should parse ":{x}" style parameter as "x" is parameter using "NamedParameterUtils.parseSqlStatement",
so the condition "j - i > 2" is the correct condition, not "j - i > 3", because if "i" is the index of
":" in ":{x}", and "j" is the index of "}" in ":{x}",  "j - i == 3" is true.
Also add a test case for SPR-16663.
 2018-03-29 15:00:25 +02:00
Juergen Hoeller
b2d87abcbb Polishing 2018-03-28 12:06:38 +02:00
Juergen Hoeller
e3d0ef6015 Use Map.forEach instead of manual Map.Entry iteration wherever possible 
Issue: SPR-16646
 2018-03-27 00:38:32 +02:00
Juergen Hoeller
c441d60d1d Upgrade to Kotlin 1.2.31 and RxJava 2.1.12 
Includes H2 1.4.197 and Selenium HtmlUnit Driver 2.29.3 as well.
 2018-03-24 16:48:53 +01:00
Juergen Hoeller
702b27e1e4 Polishing 2018-03-19 12:05:04 +01:00
Juergen Hoeller
2c7efbb9d0 Deprecate TableMetaDataContext.getSimulationQueryForGetGeneratedKey 2018-03-19 12:04:51 +01:00
Juergen Hoeller
b7c423813d CallMetaDataContext handles 'procedureColumnResult' as return parameter 
Issue: SPR-16611
 2018-03-19 12:04:15 +01:00
Juergen Hoeller
4fef1fe820 Polishing 2018-03-16 18:49:12 +01:00
igor-suhorukov
2f9d0a7de8 simplify boolean NOT operation 2018-03-08 23:44:15 +01:00
igor-suhorukov
32b689a994 use StringBuilder for complex string concatenation 2018-03-08 21:25:47 +01:00
igor-suhorukov
407ecf7334 to get rid of "magic" time constants 2018-03-08 20:37:48 +01:00
Juergen Hoeller
50253f670e Quick access to volatile field (full synchronization only for lazy init) 
Issue: SPR-16570
 2018-03-08 18:13:00 +01:00
Juergen Hoeller
139dc1d373 Polishing (collapsed if checks, consistent downcasts, refined javadoc) 2018-03-08 18:11:57 +01:00
igor-suhorukov
0f7485b01d Polish: reorder the modifiers to comply with the Java Language Specification. 2018-03-08 17:57:47 +01:00
Juergen Hoeller
20287e0cb0 Polishing 2018-03-07 17:09:09 +01:00
Juergen Hoeller
82515a3f01 Consistent incrementer arrangement for PostgreSQL, DB2 and SAP HANA 
Includes related polishing in core.metadata and datasource.embedded and a revision of the corresponding database definitions in sql-error-codes.

Issue: SPR-16558
 2018-03-06 13:36:15 +01:00
Juergen Hoeller
4a4f2c2f08 Drop version check in isGetGeneratedKeysSimulated (for PostgreSQL 10) 
Issue: SPR-16556
 2018-03-06 13:31:26 +01:00
igor-suhorukov
49fd724d8f Polish: String function use should be optimized for single characters 2018-02-25 20:48:47 +01:00
Juergen Hoeller
3732032ee4 Customizable PreparedStatementCreator in NamedParameterJdbcTemplate 
Issue: SPR-16050
 2018-02-25 18:23:00 +01:00
igor-suhorukov
c782075a13 Polish: Array designators "[]" should be on the type, not the variable 2018-02-25 13:14:20 +01:00
Juergen Hoeller
a5cbf5fe24 Consistent use of Collection.toArray with zero-sized array argument 
Includes consistent use of ClassUtils.toClassArray (as non-null variant)

Issue: SPR-16523
 2018-02-22 11:29:46 +01:00
Juergen Hoeller
d7cab23e6d Consistent use of StringUtils.toStringArray 
(cherry picked from commit 6d11b40)
 2018-02-16 20:49:17 +01:00
Juergen Hoeller
8d3264f680 Prefer List.sort(Comparator) over Collections.sort(List, Comparator) 2018-02-16 10:23:18 +01:00
Juergen Hoeller
3b810f3544 Consistent Class array vs vararg declarations (and related polishing) 2018-02-14 14:44:00 +01:00
Juergen Hoeller
766e6028d7 Defensively handle DatabaseMetaData.getConnection() returning null 
Issue: SPR-16495
 2018-02-14 14:40:52 +01:00
Kazuki Shimizu
8c623c8a42 Supports ConversionService on SingleColumnRowMapper 
Issue: SPR-16483
 2018-02-11 22:36:50 +01:00
igor-suhorukov
0ee505b73e Polish: assertion arguments should be passed in the correct order, 
use assertNull instead of assertEquals(null, value),
declare delta as double value in assertEquals
 2018-02-10 17:17:28 +01:00
igor-suhorukov
9a6fbf59c5 Polish: follow name convention - make immutable fields final 2018-02-10 12:09:19 +01:00
Juergen Hoeller
fc93f99f53 Relaxed procedure existence check on Oracle (for non-exposed synonyms) 
Issue: SPR-16478
 2018-02-09 13:30:31 +01:00