Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
16,173 Commits 18 Branches 0 Tags
90d768bb7f36819893db968bd87daba81abbffb2
Commit Graph

1081 Commits

Author SHA1 Message Date
Juergen Hoeller
a0cc80063d Concurrency and exception message refinements for test transactions 2018-03-05 13:00:35 +01:00
igor-suhorukov
ed936cbd89 Polish: Overriding methods should do more than simply call the same method in the super class 2018-03-02 00:06:27 +01:00
Juergen Hoeller
bfddbbe731 Polishing 2018-03-01 01:39:06 +01:00
igor-suhorukov
8080f56db8 Polish: "@Override" should be used on overriding and implementing methods 2018-03-01 00:15:18 +01:00
Rossen Stoyanchev
e12fcca1e3 Fix failing test 2018-02-26 20:35:17 -05:00
Juergen Hoeller
9e55422334 Polishing 2018-02-25 15:38:32 +01:00
Juergen Hoeller
01d9475bcc Turn registered controller classes into controller instances on the fly 
Issue: SPR-16520
 2018-02-25 14:29:44 +01:00
igor-suhorukov
c782075a13 Polish: Array designators "[]" should be on the type, not the variable 2018-02-25 13:14:20 +01:00
Juergen Hoeller
3531c104b0 Prefer Collections.addAll call with array over Set.addAll(Arrays.asList) 2018-02-25 00:21:39 +01:00
Juergen Hoeller
a5cbf5fe24 Consistent use of Collection.toArray with zero-sized array argument 
Includes consistent use of ClassUtils.toClassArray (as non-null variant)

Issue: SPR-16523
 2018-02-22 11:29:46 +01:00
Rossen Stoyanchev
bb8cddda23 Assert instances (vs classes) in MockMvc/WebTestClient 
Issue: SPR-16520
 2018-02-21 14:01:53 -05:00
Juergen Hoeller
0de36d2883 Consistent HttpMethod identity comparisons 2018-02-18 22:01:22 +01:00
Juergen Hoeller
d7cab23e6d Consistent use of StringUtils.toStringArray 
(cherry picked from commit 6d11b40)
 2018-02-16 20:49:17 +01:00
Juergen Hoeller
8d3264f680 Prefer List.sort(Comparator) over Collections.sort(List, Comparator) 2018-02-16 10:23:18 +01:00
igor-suhorukov
2be4985b8f Polish: anonymous inner classes containing only one method should become lambdas, 
use getOrDefault instead of ternary operator
 2018-02-16 09:38:19 +01:00
Juergen Hoeller
3b810f3544 Consistent Class array vs vararg declarations (and related polishing) 2018-02-14 14:44:00 +01:00
igor-suhorukov
45e520ed86 Polish: remove unused private fields, remove empty operator 2018-02-13 23:00:18 +01:00
igor-suhorukov
0ee505b73e Polish: assertion arguments should be passed in the correct order, 
use assertNull instead of assertEquals(null, value),
declare delta as double value in assertEquals
 2018-02-10 17:17:28 +01:00
Juergen Hoeller
39201adca4 Consistent handling of InterruptedException 
Issue: SPR-16479
 2018-02-10 13:03:33 +01:00
igor-suhorukov
9a6fbf59c5 Polish: follow name convention - make immutable fields final 2018-02-10 12:09:19 +01:00
Stephane Nicoll
991eb4858e Update copyright header 2018-02-09 10:16:58 +01:00
igor-suhorukov
e381514b07 Collection.isEmpty() should be used to test for emptiness 
Closes gh-1670
 2018-02-09 10:11:44 +01:00
Rossen Stoyanchev
1653a32a04 Stabilize Flux.interval emissions in integration tests 
After this commit the use of interval in tests is combined with
take(n).onBackpressureBuffer(n) to ensure emissions don't fail if the
fixed rate is exceeded (e.g. on slow CI server).

Tests that verify N number of items followed by verifyOnComplete()
should set the number of emissions to N.

Tests that verify N number of items followed by thenCancel() should
set the number of buffered to an arbitrary number greater than N.
 2018-02-06 11:01:19 -05:00
Rossen Stoyanchev
f20eacdb9b Polish 2018-02-02 15:06:59 -05:00
Rob Winch
0cd427bdd3 MockHttpServletRequestBuilder decodes pathInfo 
Previously MockHttpServletRequestBuilder calculated the pathInfo from the
provided URL without decoding the value. This meant that the pathInfo
incorrectly included URL encoded values.

Now MockHttpServletRequestBuilder properly decodes the pathInfo.

Fixes: SPR-16453
 2018-02-02 15:00:47 -05:00
Juergen Hoeller
b3e21ec737 MockHttpServletRequest leniently handles invalid Accept-Language header 
Issue: SPR-16454
 2018-02-02 11:34:22 +01:00
Rossen Stoyanchev
6d909b013e Do not commit response on access to content 
MockHttpServletResponse no longer calls flushBuffer on calls to
getContentAsByteArray and getContentAsString. The flushing doesn't
actually do anything useful but does commit the response leading to
unexpected side effects.

Issue: SPR-16430
 2018-01-30 16:19:08 -05:00
Sam Brannen
b612f53e27 Rename doesExist() to exists() for header assertions 2018-01-26 17:24:54 +01:00
Juergen Hoeller
c6b0d85a7c Consistent available() support in DelegatingServletInputStream 
Issue: SPR-16416
 2018-01-25 19:06:20 +01:00
Ketan Padegaonkar
a0c9fdba12 Fix DelegatingServletInputStream#available 
Ensure that the method returns the correct number of bytes that can be
read without blocking

Issue: #SPR-16416
 2018-01-25 18:02:59 +01:00
Sam Brannen
165ca12e6d Add doesExist() to HeaderAssertions for WebTestClient 2018-01-25 15:50:19 +01:00
Sam Brannen
431494096a Polishing 2018-01-25 15:49:06 +01:00
Rossen Stoyanchev
49f1aa78eb Polish 2018-01-24 17:37:49 -05:00
Neonailol
81ca1f7c2b Add doesExist assertion method to HeaderResultMatchers 2018-01-24 17:28:46 -05:00
Juergen Hoeller
61579ffe7b Polishing 2018-01-22 21:34:44 +01:00
Juergen Hoeller
9d0e62ef68 Javadoc format and related polishing 2018-01-22 11:43:21 +01:00
Juergen Hoeller
40127bd9ad Polishing 2018-01-19 12:30:10 +01:00
Rossen Stoyanchev
0c289283ff Separate from expectations from response creation 
This commit separates the creation of a response so that it is executed
after the synchronized block inside which requests need to be matched
and validated (for order and count).

This allows a ResponseCreator to be slow or block if it has to.

Issue: SPR-16319
 2018-01-17 13:01:40 -05:00
Rossen Stoyanchev
7ab4d0ca08 Polish MockRestServiceServer code 2018-01-17 13:01:40 -05:00
Juergen Hoeller
214576673a Proper NoClassDefFoundError check against BeanUtils.instantiateClass 
Issue: SPR-16369
 2018-01-17 18:29:05 +01:00
Sam Brannen
c88f11f958 Avoid deprecation warnings on JDK 9 in spring-test 2018-01-13 16:45:04 +01:00
Juergen Hoeller
a15975d94d Log non-loadable TestExecutionListener classes at debug level only 
Issue: SPR-16369
 2018-01-12 16:47:46 +01:00
Juergen Hoeller
8f6d3feaa0 Tests for non-required MultipartFile parameters 
Issue: SPR-16329
 2018-01-11 10:22:59 +01:00
Juergen Hoeller
4a57e26d76 Polishing 2018-01-07 23:33:35 +01:00
Rossen Stoyanchev
0f1f95e090 Add hasJsonPath/doesNotHaveJsonPath assertion options 
Issue: SPR-16339
 2018-01-03 20:27:09 -05:00
Brian Clozel
6e587d5c57 Add new WebTestClient header assertions 
This commit adds new header assertions for `WebTestClient`.

`doesNotExist` tests that a given header is not present:

    .expectHeader().doesNotExist("Cache-Control");

`contentTypeCompatibleWith` tests for MediaType compatibility:

    .expectHeader().contentTypeCompatibleWith("text/*");

Issue: SPR-16285
 2017-12-21 20:34:24 +01:00
Rossen Stoyanchev
a8cf275aed MockServerHttpRequest builder supports query params 
Issue: SPR-16280
 2017-12-19 15:38:12 -05:00
Rossen Stoyanchev
6df1a7874a MockHttpServletResponse uses correct language header 
Issue: SPR-16311
 2017-12-19 13:56:16 -05:00
sdeleuze
9f1d8517ba Polish Kotlin source code style 2017-11-21 15:59:23 +01:00
Juergen Hoeller
7697b398d5 Polishing 2017-11-14 17:11:16 +01:00