Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
18,979 Commits 18 Branches 0 Tags
932f771380db98f80c75ccb16cd122db1bfdc970
Commit Graph

184 Commits

Author SHA1 Message Date
Sam Brannen
bdf3960283 Suppress warnings in Gradle build 2019-05-27 12:15:50 +02:00
Phillip Webb
9d74da006c Migrate JUnit 4 assertions to AssertJ 
Migrate all existing JUnit 4 `assert...` based assertions to AssertJ
and add a checkstyle rule to ensure they don't return.

See gh-23022
 2019-05-23 15:52:49 -07:00
Phillip Webb
95a9d46a87 Migrate Hamcrest assertions to AssertJ 
Migrate all existing `assertThat(..., Matcher)` assertions to AssertJ
and add checkstyle rules to ensure they don't return.

See gh-23022
 2019-05-23 15:49:59 -07:00
Phillip Webb
02850f357f Migrate exception checking tests to use AssertJ 
Migrate tests that use `@Test(expectedException=...)` or
`try...fail...catch` to use AssertJ's `assertThatException`
instead.
 2019-05-20 10:47:53 -07:00
Phillip Webb
816bbee8de Remove '.*' imports from tests 
Organize test imports to expand all '.*' static imports into
fully qualified imports.

This update will allow us to use additional checkstyle rules in
the future, and will also help if we migrate fully to AssertJ.
 2019-05-08 09:55:09 -07:00
Phil Webb
d7320de871 Migrate away from ExpectedException (#22922) 
* Add limited checkstyles to test code

Add a limited set of checkstyle rules to the test codebase to improve
code consistency.

* Fix checksyle violations in test code

* Organize imports to fix checkstyle for test code

* Migrate to assertThatExceptionOfType

Migrate aware from ExpectedException rules to AssertJ exception
assertions. Also include a checkstyle rules to ensure that the
the ExpectedException is not accidentally used in the future.

See gh-22894
 2019-05-08 16:25:52 +02:00
Sam Brannen
47c39304af Use assertThat from Hamcrest instead of JUnit 4 
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.

See gh-22894
 2019-05-05 18:27:38 +02:00
Juergen Hoeller
ce9162065c Merge branch '5.1.x' 2019-05-02 17:52:12 +02:00
Juergen Hoeller
18f6739be4 Allow null operands in compiled SpEL numeric operator expressions 
Closes gh-22358
 2019-05-02 17:27:49 +02:00
Andy Clement
0f553661a6 Allow null operands in compiled SpEL numeric operator expressions 
Prior to this when SpEL compiled an expression using the numeric
operators <, >, <= or >= then it would not create code that handled
nulls. Nulls can occur if a boxed numeric operand is used prior
to compilation, then it is nulled out. SpEL now creates null
handling bytecode.

Closes gh-22358
 2019-05-01 15:36:19 -07:00
Spring Operator
540759ec41 URL Cleanup 
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).

# Fixed URLs

## Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

* [ ] http://www.apache.org/licenses/ with 1 occurrences migrated to:
  https://www.apache.org/licenses/ ([https](https://www.apache.org/licenses/) result 200).
* [ ] http://www.apache.org/licenses/LICENSE-2.0 with 6515 occurrences migrated to:
  https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200).
 2019-03-23 15:19:34 +01:00
Spring Operator
dc6f63f610 URL Cleanup 
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).

# Fixed URLs

## Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

* [ ] http://www.apache.org/licenses/ with 1 occurrences migrated to:
  https://www.apache.org/licenses/ ([https](https://www.apache.org/licenses/) result 200).
* [ ] http://www.apache.org/licenses/LICENSE-2.0 with 6625 occurrences migrated to:
  https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200).
 2019-03-21 23:49:28 -05:00
Juergen Hoeller
7a77e83e10 SpelNodeImpl manages start/end position in separate integer values 
Fixes gh-22157
 2019-01-28 22:50:56 +01:00
Rossen Stoyanchev
bdac937a43 Replace more references to issue tracker 
Fixes #22254
 2019-01-17 17:08:39 -05:00
Stephane Nicoll
9cbd585c30 Polish "Join identical catch branches" 
Closes gh-2052
 2018-12-25 09:46:35 +01:00
igor-suhorukov
a218bf40cd Join identical catch branches 
See gh-2052
 2018-12-25 09:46:11 +01:00
Rossen Stoyanchev
38ae282c3b Update log category precision for all tests 
Replace the full category capped at 36 chars with the class name only
and 1 char per package, e.g. org.apache.commons.Foo -> o.a.c.Foo
 2018-12-12 11:40:33 -05:00
Hanope
bfb49c7249 Fix typos 
See gh-2019
 2018-11-19 08:41:21 +01:00
Juergen Hoeller
3abebb3799 Polishing 2018-09-07 13:23:22 +02:00
Juergen Hoeller
90a4740279 Polishing 2018-09-07 12:56:53 +02:00
Andy Clement
f87a37fd0d Fix SpEL compilation for non trivial elvis operand 
Issue: SPR-17214
 2018-09-05 09:41:13 -07:00
Juergen Hoeller
c4df335a1d ReflectiveMethodExecutor invokes interface method if possible 
Issue: SPR-16845
 2018-07-19 16:35:59 +02:00
Phillip Webb
a89e716cc7 Use tabs rather than spaces in tests 
Update tests to ensure that tabs are used instead of spaces. Also
consistently apply a new line at the end of each file.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb
1c25cec44f Polish test code 
Polish a few issue identified when adding checkstyle to the
build. Although checkstyle is not enforcing rules on tests,
these are a few minor changes that are still worth making.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Juergen Hoeller
ac1e2a4598 Consistent SpelEvaluationException messages in findAccessorForMethod 
Includes abstract declarations for FormatHelper and ReflectionHelper.

Issue: SPR-16762
 2018-05-01 23:48:26 +02:00
Juergen Hoeller
d4a55a257b OperatorMatches flags misguided evaluation attempts as FLAWED_PATTERN 
Issue: SPR-16731
 2018-04-17 11:10:15 +02:00
Juergen Hoeller
b2d87abcbb Polishing 2018-03-28 12:06:38 +02:00
Juergen Hoeller
c60cefa331 SimpleEvaluationContext.Builder withRootObject/withTypedRootObject 
Issue: SPR-16588
 2018-03-27 00:22:54 +02:00
Juergen Hoeller
9128226da4 SimpleEvaluationContext.Builder withMethodResolvers/withInstanceMethods 
Includes DataBindingMethodResolver as ReflectiveMethodResolver subclass.

Issue: SPR-16588
 2018-03-24 16:30:37 +01:00
Juergen Hoeller
51c57d77d9 SimpleEvaluationContext with dedicated factory methods for common cases 
Aligned with DataBindingPropertyAccessor and shown in ref doc examples.

Issue: SPR-16588
 2018-03-22 18:09:27 +01:00
Juergen Hoeller
b5511645b8 DataBindingPropertyAccessor with factory methods (forReadOnlyAccess etc) 
Includes configurable write support at ReflectivePropertyAccessor level.

Issue: SPR-16588
 2018-03-22 00:03:06 +01:00
Juergen Hoeller
c1405ef140 Polishing 2018-03-21 16:12:42 +01:00
Juergen Hoeller
639d2c6fe7 Polishing 2018-03-21 12:39:15 +01:00
Juergen Hoeller
1fd5935afa SimplePropertyAccessor with configurable write support 
Issue: SPR-16588
 2018-03-21 12:06:40 +01:00
Andy Clement
1db7e02de3 Modify SpEL code gen to take account of null safe refs 
With this change the code generation for method and property
references is modified to include branching logic in the
case of null safe dereferencing (?.). This is complicated
by the possible usage of primitives on the left hand side
of the dereference. To cope with this case primitives are
promoted to boxed types when this situation occurs enabling
null to be passed as a possible result.

Issue: SPR-16489
 2018-03-12 15:58:59 -07:00
Juergen Hoeller
c543368aad Polishing 2018-03-03 17:33:48 +01:00
igor-suhorukov
06fef1e5a4 Polish: assertion arguments should be passed in the correct order 2018-03-03 16:14:45 +01:00
Juergen Hoeller
fa670dd07d Indexer enforces target descriptor only after non-null target check 
Issue: SPR-16544
 2018-03-01 13:31:56 +01:00
Juergen Hoeller
3b810f3544 Consistent Class array vs vararg declarations (and related polishing) 2018-02-14 14:44:00 +01:00
Juergen Hoeller
d5cabca2f7 Internal adaptation to Deque semantics 2018-02-12 15:55:09 +01:00
Juergen Hoeller
b5bd977d9a Revised assertion refactoring in AbstractExpressionTests 2018-02-10 18:17:40 +01:00
igor-suhorukov
0ee505b73e Polish: assertion arguments should be passed in the correct order, 
use assertNull instead of assertEquals(null, value),
declare delta as double value in assertEquals
 2018-02-10 17:17:28 +01:00
Juergen Hoeller
4a57e26d76 Polishing 2018-01-07 23:33:35 +01:00
Juergen Hoeller
c30145d6f9 MethodReference treats proxy-targeting expressions as non-compilable 
Issue: SPR-16191
 2017-11-13 23:00:53 +01:00
Juergen Hoeller
78284a62e2 Polishing 2017-10-27 15:28:51 +02:00
Juergen Hoeller
419b4440a7 Introspect interface-declared methods in case of proxy (for varargs) 
Issue: SPR-16122
 2017-10-27 10:52:44 +02:00
Juergen Hoeller
fd6f2bd6a4 Test for null value against boolean property 
Issue: SPR-16123
 2017-10-26 22:49:34 +02:00
Juergen Hoeller
03b68286a2 Tokenizer uses single process step and length-based exhaustion check 
Issue: SPR-16032
 2017-10-04 12:23:16 +02:00
Juergen Hoeller
7ae59d0c2a Nullability refinements on private and static methods 
Based on IntelliJ IDEA 2017.3 introspection results.

Issue: SPR-15756
 2017-09-22 18:22:14 +02:00
Juergen Hoeller
efc5b47b9a Polishing 2017-07-14 17:37:06 +02:00