Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
16,472 Commits 18 Branches 0 Tags
a683472daa1d5059944656f8e12440c3f575cde0
Commit Graph

875 Commits

Author SHA1 Message Date
Juergen Hoeller
a683472daa Support for non-standard HTTP status in reactive ClientHttpResponse 
Issue: SPR-16748
 2018-04-27 18:25:11 +02:00
Rossen Stoyanchev
9bc4e70e93 Better assertion message in MockPart 
Issue: SPR-16767
 2018-04-25 09:59:06 -04:00
Sam Brannen
4f3a7dd9b4 Expand scope of SpringFailOnTimeoutTests 
Issue: SPR-16716
 2018-04-12 10:56:40 +02:00
Igor Suhorukov
3c34a1cb8c Throw exception from user code in SpringFailOnTimeout even if a timeout occurs 
Issue: SPR-16717
 2018-04-12 10:37:13 +02:00
Sam Brannen
2523c3ab77 Clean up deprecation warning in spring-test 2018-04-11 12:03:55 +02:00
Arjen Poutsma
7e2726f400 Add remoteAddress() to ServerRequest 
Issue: SPR-16681
 2018-04-10 11:13:45 +02:00
Rossen Stoyanchev
313308208e TestDispatcherServlet unwraps to find mock request 
Issue: SPR-16695
 2018-04-06 11:02:46 -04:00
Juergen Hoeller
912c270f2b Polishing 2018-03-31 17:49:21 +02:00
Sam Brannen
e5096be660 Polishing 2018-03-30 12:23:28 +02:00
Juergen Hoeller
d553ddc5b3 Nullability refinements (based on IntelliJ IDEA 2018.1 introspection) 
Issue: SPR-15756
 2018-03-29 23:50:17 +02:00
igor-suhorukov
c1ff97e2a8 Short-circuit logic should be used in boolean contexts 2018-03-29 23:33:22 +02:00
Sam Brannen
9244090ba0 Support DI of individual constructor args in @Nested tests 
Prior to this commit it was impossible to have an individual
constructor argument in a @Nested (i.e., inner) test class injected via
@Autowired, @Qualifier, or @Value.

This is due to a bug in javac on JDK versions prior to 9, whereby
annotation lookups performed directly via the
java.lang.reflect.Parameter API fail for inner class constructors.

Specifically, the parameter annotations array in the compiled byte code
for the user's test class excludes an entry for the implicit enclosing
instance parameter for an inner class constructor.

This commit introduces a workaround in ParameterAutowireUtils for this
off-by-one error by transparently looking up annotations on the
preceding Parameter object (i.e., index - 1). In addition, this commit
relies on the change recently introduced in MethodParameter in order to
compensate for the same JDK bug (see SPR-16652).

Issue: SPR-16653
 2018-03-29 17:47:45 +02:00
Rossen Stoyanchev
f9e6ea5482 MvcResult returns asyncResult after asyncDispatch 
Issue: SPR-16648
 2018-03-28 22:15:16 -04:00
igor-suhorukov
4aae6a6dda Use Map.forEach instead of manual Map.Entry iteration wherever possible SPR-16646 2018-03-28 01:09:03 +02:00
Juergen Hoeller
f00afe3247 Use (Concurrent)Map.computeIfAbsent for lazy nested collection creation 2018-03-23 17:36:23 +01:00
Arjen Poutsma
c56317928f Add formData() and multipartData() to ServerRequest 
Issue: SPR-16551
 2018-03-23 10:00:30 +01:00
Juergen Hoeller
c1405ef140 Polishing 2018-03-21 16:12:42 +01:00
Rossen Stoyanchev
72bbb2619d Commit actions are (properly) deferred 
Issue: SPR-16597
 2018-03-15 23:17:57 -04:00
Rossen Stoyanchev
541ee13934 Add bufferContent option to MockRestServiceServer 
Issue: SPR-14694
 2018-03-15 22:13:44 -04:00
Sam Brannen
5f4d5f17f7 Polishing 2018-03-13 16:48:52 +01:00
Sam Brannen
2c2ce55f47 Support target type in JsonPath assertions for MockMvc results 
This commit picks up where SPR-14498 left off by adding support for an
explicit target type when using JsonPath to perform an assertion against
the response content using a Hamcrest Matcher.

Specifically, there is a new overloaded value(Matcher<T>, Class<T>)
method in JsonPathResultMatchers for use with Hamcrest matchers where
the target type (i.e., Class<T>) can be specified.

Issue: SPR-16587
 2018-03-13 15:55:39 +01:00
Bronwyn Perry-Huston
d64f2eb038 Add JSON matcher to assert on request body 
Support asserting JSON regardless of order and formatting.
Based on same JsonExpectationHelper used in ContentResultMatchers.

Issue: SPR-13919
 2018-03-13 12:27:05 +01:00
Juergen Hoeller
139dc1d373 Polishing (collapsed if checks, consistent downcasts, refined javadoc) 2018-03-08 18:11:57 +01:00
igor-suhorukov
0f7485b01d Polish: reorder the modifiers to comply with the Java Language Specification. 2018-03-08 17:57:47 +01:00
Sam Brannen
b14301bfba Allow TestContextManager to be compiled in Eclipse again 2018-03-07 17:44:24 +01:00
Sam Brannen
2454b31b30 Polish MockRestRequestMatchers[Tests] 2018-03-07 14:20:57 +01:00
Sam Brannen
f932796201 Polishing 2018-03-07 13:22:36 +01:00
Sam Brannen
fef0c7b151 Throw AssertionError instead of IAE in MockRestRequestMatchers 2018-03-07 13:22:21 +01:00
Yannik Hampe
4094879daf Make MockRestRequestMatchers independent of JUnit (#1720) 
MockRestRequestMatchers was using org.junit.Assert.assertNotNull
and thus could not be used in projects that use e.g. TestNG instead
of JUnit 4.
 2018-03-07 13:07:32 +01:00
Juergen Hoeller
a0cc80063d Concurrency and exception message refinements for test transactions 2018-03-05 13:00:35 +01:00
igor-suhorukov
ed936cbd89 Polish: Overriding methods should do more than simply call the same method in the super class 2018-03-02 00:06:27 +01:00
Juergen Hoeller
bfddbbe731 Polishing 2018-03-01 01:39:06 +01:00
igor-suhorukov
8080f56db8 Polish: "@Override" should be used on overriding and implementing methods 2018-03-01 00:15:18 +01:00
Juergen Hoeller
9e55422334 Polishing 2018-02-25 15:38:32 +01:00
Juergen Hoeller
01d9475bcc Turn registered controller classes into controller instances on the fly 
Issue: SPR-16520
 2018-02-25 14:29:44 +01:00
igor-suhorukov
c782075a13 Polish: Array designators "[]" should be on the type, not the variable 2018-02-25 13:14:20 +01:00
Juergen Hoeller
3531c104b0 Prefer Collections.addAll call with array over Set.addAll(Arrays.asList) 2018-02-25 00:21:39 +01:00
Juergen Hoeller
a5cbf5fe24 Consistent use of Collection.toArray with zero-sized array argument 
Includes consistent use of ClassUtils.toClassArray (as non-null variant)

Issue: SPR-16523
 2018-02-22 11:29:46 +01:00
Rossen Stoyanchev
bb8cddda23 Assert instances (vs classes) in MockMvc/WebTestClient 
Issue: SPR-16520
 2018-02-21 14:01:53 -05:00
Juergen Hoeller
0de36d2883 Consistent HttpMethod identity comparisons 2018-02-18 22:01:22 +01:00
Juergen Hoeller
d7cab23e6d Consistent use of StringUtils.toStringArray 
(cherry picked from commit 6d11b40)
 2018-02-16 20:49:17 +01:00
Juergen Hoeller
8d3264f680 Prefer List.sort(Comparator) over Collections.sort(List, Comparator) 2018-02-16 10:23:18 +01:00
igor-suhorukov
2be4985b8f Polish: anonymous inner classes containing only one method should become lambdas, 
use getOrDefault instead of ternary operator
 2018-02-16 09:38:19 +01:00
igor-suhorukov
45e520ed86 Polish: remove unused private fields, remove empty operator 2018-02-13 23:00:18 +01:00
Juergen Hoeller
39201adca4 Consistent handling of InterruptedException 
Issue: SPR-16479
 2018-02-10 13:03:33 +01:00
igor-suhorukov
9a6fbf59c5 Polish: follow name convention - make immutable fields final 2018-02-10 12:09:19 +01:00
Stephane Nicoll
991eb4858e Update copyright header 2018-02-09 10:16:58 +01:00
igor-suhorukov
e381514b07 Collection.isEmpty() should be used to test for emptiness 
Closes gh-1670
 2018-02-09 10:11:44 +01:00
Rossen Stoyanchev
f20eacdb9b Polish 2018-02-02 15:06:59 -05:00
Rob Winch
0cd427bdd3 MockHttpServletRequestBuilder decodes pathInfo 
Previously MockHttpServletRequestBuilder calculated the pathInfo from the
provided URL without decoding the value. This meant that the pathInfo
incorrectly included URL encoded values.

Now MockHttpServletRequestBuilder properly decodes the pathInfo.

Fixes: SPR-16453
 2018-02-02 15:00:47 -05:00