Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
16,560 Commits 18 Branches 0 Tags
ade2eab169a385ffe0bc5402815d2b830b708b01
Commit Graph

687 Commits

Author SHA1 Message Date
Rossen Stoyanchev
37b0ed9fcb Improve TCP connection info logging. 
After the recent changes to expose configuring TcpOperations, it no
longer makes sense to automatically log the relayHost/Port since that's
mutually exclusive with a custom TcpOperations.

Instead we delegate to TcpOperations.toString().

Issue: SPR-16801
 2018-05-16 11:40:51 -04:00
Rossen Stoyanchev
020c6c0102 Polish: remove Javadoc tags from spring-websocket.xsd 2018-05-16 10:18:01 -04:00
Rossen Stoyanchev
29158aa79a Expose timeToFirstMessage in Java/XML config 
Issue: SPR-16531
 2018-05-16 10:03:57 -04:00
Johnny Lim
fb898e1727 Remove inconsistent spaces 2018-05-05 11:07:35 +02:00
Rossen Stoyanchev
0e776d4e77 Add more detail to ISE in ServerEndpointExporter 
Issue: SPR-16655
 2018-04-23 17:03:09 -04:00
Rossen Stoyanchev
ff2228fdaf Selector header name is exposed for configuration 
Issue: SPR-16732
 2018-04-16 23:56:30 -04:00
igor-suhorukov
4aae6a6dda Use Map.forEach instead of manual Map.Entry iteration wherever possible SPR-16646 2018-03-28 01:09:03 +02:00
Juergen Hoeller
e3d0ef6015 Use Map.forEach instead of manual Map.Entry iteration wherever possible 
Issue: SPR-16646
 2018-03-27 00:38:32 +02:00
Juergen Hoeller
d4a8f76bf9 Consistent volatile access to running flag in Lifecycle implementations 
Issue: SPR-16488
 2018-03-15 15:17:55 +01:00
igor-suhorukov
407ecf7334 to get rid of "magic" time constants 2018-03-08 20:37:48 +01:00
Juergen Hoeller
139dc1d373 Polishing (collapsed if checks, consistent downcasts, refined javadoc) 2018-03-08 18:11:57 +01:00
igor-suhorukov
0f7485b01d Polish: reorder the modifiers to comply with the Java Language Specification. 2018-03-08 17:57:47 +01:00
Juergen Hoeller
cec7204fca Polishing 2018-03-02 13:53:17 +01:00
igor-suhorukov
ed936cbd89 Polish: Overriding methods should do more than simply call the same method in the super class 2018-03-02 00:06:27 +01:00
Juergen Hoeller
bfddbbe731 Polishing 2018-03-01 01:39:06 +01:00
igor-suhorukov
8080f56db8 Polish: "@Override" should be used on overriding and implementing methods 2018-03-01 00:15:18 +01:00
Juergen Hoeller
a5cbf5fe24 Consistent use of Collection.toArray with zero-sized array argument 
Includes consistent use of ClassUtils.toClassArray (as non-null variant)

Issue: SPR-16523
 2018-02-22 11:29:46 +01:00
Juergen Hoeller
0de36d2883 Consistent HttpMethod identity comparisons 2018-02-18 22:01:22 +01:00
Alexander Münch
37f19a4b43 Polish Javadoc 
WebSocketMessageBrokerStats's Javadoc now states the correct default
logging period.

Closes gh-1691
 2018-02-18 08:57:08 +01:00
Juergen Hoeller
d7cab23e6d Consistent use of StringUtils.toStringArray 
(cherry picked from commit 6d11b40)
 2018-02-16 20:49:17 +01:00
Juergen Hoeller
b35274f5a7 WebSocket callbacks need to remain inner classes (retaining generics) 2018-02-16 10:22:05 +01:00
igor-suhorukov
2be4985b8f Polish: anonymous inner classes containing only one method should become lambdas, 
use getOrDefault instead of ternary operator
 2018-02-16 09:38:19 +01:00
igor-suhorukov
45e520ed86 Polish: remove unused private fields, remove empty operator 2018-02-13 23:00:18 +01:00
Juergen Hoeller
3c631f8ea0 SubProtocolWebSocketHandler closes sessions outside of lifecycle monitor 
Issue: SPR-16488
 2018-02-13 00:04:55 +01:00
Juergen Hoeller
d00e1c5e4f Polishing 2018-02-10 21:35:46 +01:00
Juergen Hoeller
39201adca4 Consistent handling of InterruptedException 
Issue: SPR-16479
 2018-02-10 13:03:33 +01:00
igor-suhorukov
d3a1d44864 Polish: Maps with keys that are enum values should be replaced with EnumMap 2018-02-10 12:09:33 +01:00
igor-suhorukov
9a6fbf59c5 Polish: follow name convention - make immutable fields final 2018-02-10 12:09:19 +01:00
Juergen Hoeller
5c813a366b Consistent use of @throws instead of @exception 2018-02-05 22:51:51 +01:00
Juergen Hoeller
cf100d4d03 AbstractClientSockJsSession.close propagates IOException from disconnect 
Issue: SPR-16415
 2018-01-25 12:24:46 +01:00
Juergen Hoeller
8e2be91353 Fine-tuned logging of WebSocket close exceptions 
Issue: SPR-16409
 2018-01-25 12:24:40 +01:00
Juergen Hoeller
0e6f8df0a8 ServletServerHttpRequest.getURI() ignores malformed query string 
The resolved URI instance is also being cached now. This should not make a difference in a real Servlet environment but does affect tests which assumed they could modify an HttpServletRequest path behind a pre-created ServletServerHttpRequest instance. Our WebSocket test base class has been revised accordingly, re-creating the ServletServerHttpRequest in such a case.

Issue: SPR-16414
 2018-01-24 22:13:40 +01:00
sdeleuze
43d3abdfd5 Fix SockJs CorsConfiguration for forbidden origins 
After this commit, AbstractSockJsService uses the configured allowed
origins when generating the CorsConfiguration instead of "*".

As a consequence, forbidden origin requests still result in a 403
response but now with no CORS headers in order to improve consistency
between the status code and the headers.

Issue: SPR-16304
 2018-01-15 18:07:24 +01:00
Rossen Stoyanchev
61352fe85b Fix compile error 2018-01-15 10:28:12 -05:00
Rossen Stoyanchev
dd09c08cdf Replace use of AbstractWebSocketMessageBrokerConfigurer 2018-01-15 10:01:14 -05:00
Sergey
d6591a6329 Default methods in WebSocketMessageBrokerConfigurer 
+ deprecate AbstractWebSocketMessageBrokerConfigurer
 2018-01-15 09:54:55 -05:00
Juergen Hoeller
7406f5993a Polishing 2017-11-13 22:39:39 +01:00
Juergen Hoeller
b5cedd43eb Consistent and efficient access to BeanDefinition argument values 
Issue: SPR-16192
 2017-11-13 21:51:11 +01:00
Christoph Dreis
9fab208fdd Reduce access on headers for STOMP messaging 
Issue: SPR-16165
 2017-11-06 20:19:00 +01:00
Juergen Hoeller
5809f5b8eb SubProtocolWebSocketHandler provides protected decorateSession method 
Issue: SPR-16089
 2017-10-21 23:02:54 +02:00
Rossen Stoyanchev
1cc5afe24b Fix lines over 120 characters 
https://github.com/spring-projects/spring-framework/wiki/Spring-Framework-Code-Style#line-wrapping
 2017-10-20 16:42:26 -04:00
Juergen Hoeller
a4537b1b6d Accessors for configured send-time and buffer-size limit 
Issue: SPR-16089
 2017-10-20 16:02:26 +02:00
Juergen Hoeller
16a08cb465 Upgrade to Jackson 2.9.2 2017-10-16 23:53:23 +02:00
Juergen Hoeller
efce7902c4 Polishing 2017-09-27 01:34:11 +02:00
Juergen Hoeller
7ae59d0c2a Nullability refinements on private and static methods 
Based on IntelliJ IDEA 2017.3 introspection results.

Issue: SPR-15756
 2017-09-22 18:22:14 +02:00
Juergen Hoeller
4cbef27f90 Consistent tolerance of unknown HTTP status codes behind RestTemplate 
Issue: SPR-15978
 2017-09-20 10:54:58 +02:00
Sebastien Deleuze
1bc93e3d0f Revisit nullability annotations 
This commit introduces the following changes.

1) It adds a new Spring @NonNull annotation which allows to apply
@NonNullApi semantic on a specific element, like @Nullable does.
Combined with @Nullable, it allows partial null-safety support when
package granularity is too broad.

2) @Nullable and @NonNull can apply to ElementType.TYPE_USE in order
to be used on generic type arguments (SPR-15942).

3) Annotations does not apply to ElementType.TYPE_PARAMETER anymore
since it is not supported yet (applicability for such use case is
controversial and need to be discussed).

4) @NonNullApi does not apply to ElementType.FIELD anymore since in a
lot of use cases (private, protected) it is not part for the public API
+ its usage should remain opt-in. A dedicated @NonNullFields annotation
has been added in order to set fields default to non-nullable.

5) Updated Javadoc and reference documentation.

Issue: SPR-15756
 2017-09-15 13:26:41 +02:00
Juergen Hoeller
fd0132c7e6 Polishing 2017-09-08 16:56:22 +02:00
Sebastien Deleuze
73cf07e9a4 Fix overridden methods nullability 
Issue: SPR-15869
 2017-08-17 15:02:59 +02:00
Juergen Hoeller
25e6a2da64 StompSubProtocolHandler consistently accesses current user 
Issue: SPR-15822
 2017-07-27 11:32:32 +02:00