Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
22,417 Commits 18 Branches 0 Tags
ceac2a5c3ccda3335241ef2eafdcbac9adde7e13
Commit Graph

509 Commits

Author SHA1 Message Date
Juergen Hoeller
d14140da69 Polishing 2020-06-06 13:21:46 +02:00
Sam Brannen
aaa7c6c422 Merge branch '5.2.x' 2020-06-05 15:35:05 +02:00
Sam Brannen
fbeecf3bf8 Test status quo for invocation order of all advice types 
Prior to this commit we did not have tests in place to verify the status
quo for the invocation order of all advice types when declared within
a single aspect, either via the <aop:aspect> XML namespace or AspectJ
auto-proxy support.

This commit introduces such tests that demonstrate where such ordering
is broken or suboptimal.

The only test for which the advice invocation order is correct or at
least as expected is the afterAdviceTypes() test method in
ReflectiveAspectJAdvisorFactoryTests, where an AOP proxy is hand crafted
using ReflectiveAspectJAdvisorFactory without the use of Spring's
AspectJPrecedenceComparator.

See gh-25186
 2020-06-05 15:30:57 +02:00
Sam Brannen
04c8de4e50 Polishing 2020-06-05 15:22:41 +02:00
Sam Brannen
104f7f339a Merge branch '5.2.x' 2020-06-04 18:43:52 +02:00
Sam Brannen
63e8609f3b Test status quo for 'after' advice invocation order 
See gh-25186
 2020-06-04 18:37:24 +02:00
Sam Brannen
70b3de4afe Polish AspectJAdvisorFactory tests 2020-06-04 18:37:16 +02:00
Juergen Hoeller
7207f7645c Deprecate InstantiationAwareBeanPostProcessorAdapter 
Consistently relying on default methods in the corresponding interfaces.

Closes gh-25165
 2020-05-29 23:07:10 +02:00
Juergen Hoeller
3c1ee64b7f Explicit nullability declarations for all AOP Alliance methods 
Includes consistent declarations in AOP Alliance related Spring AOP code.

Closes gh-24117
 2020-05-13 23:33:47 +02:00
Sam Brannen
e8335c94d5 Update Javadoc for LazyInitTargetSourceCreator 
See gh-24915
 2020-05-12 13:48:48 +02:00
Sam Brannen
3c3e8e6a8b Only proxy supported beans in BeanNameAutoProxyCreator 
Prior to this commit, if a BeanNameAutoProxyCreator was configured with
a custom TargetSourceCreator, the TargetSourceCreator was applied to
all beans in the ApplicationContext. Thus, the list of supported
beanNames was effectively ignored when applying any
TargetSourceCreator. Consequently, if a TargetSourceCreator returned a
non-null TargetSource for a given bean, the BeanNameAutoProxyCreator
proxied the bean even if the bean name had not been configured in the
beanNames list.

This commit addresses this issue by ensuring that a custom
TargetSourceCreator is only applied to beans whose names match the
configured beanNames list in a BeanNameAutoProxyCreator.

Closes gh-24915
 2020-05-12 11:59:51 +02:00
陈其苗
13970ae528 Use autoboxing instead of explicit wrapping in tests 
Closes gh-24801
 2020-04-01 14:34:20 +02:00
Sam Brannen
e26764d249 Remove duplicate words in documentation and polish Javadoc 2020-03-31 12:17:58 +02:00
Juergen Hoeller
fdc60311ed Avoid unnecessary trace logging in ProxyFactoryBean 
Closes gh-24669
 2020-03-24 00:07:40 +01:00
Juergen Hoeller
d91fc8c672 No log level check unless String concatenation is following 2020-03-14 00:01:13 +01:00
Juergen Hoeller
33642345a4 Lazily check log level within validation conditions 
See gh-24672
 2020-03-13 23:14:38 +01:00
Qimiao Chen
988aae4f2e Remove unnecessary variable declaration in ProxyCallbackFilter 
Closes gh-24675
 2020-03-11 13:51:13 +01:00
Сергей Цыпанов
1fd447f395 Reduce String garbage in CglibAopProxy.doValidateClass() 
Closes gh-24672
 2020-03-10 17:16:08 +01:00
Qimiao Chen
b92515bdee Add logger.isInfoEnabled check before logger.info 
Closes gh-24667
 2020-03-10 14:41:20 +01:00
Christoph Dreis
2093e35f27 Avoid unnecessary sorting 2020-03-04 19:10:14 +00:00
ZhangT
6add7b4dec Polishing 
Closes gh-24543
 2020-02-17 17:33:39 +01:00
Sam Brannen
51fa98a1b2 Apply compiler conventions to test fixtures 2020-02-07 11:04:03 +01:00
Rossen Stoyanchev
f5df422de9 Polishing contribution 
See gh-24470
 2020-02-03 20:32:36 +00:00
Hyunjin Choi
273812f9c5 Remove unnecessary escapes in regular expressions 
See gh-24470
 2020-02-03 20:22:40 +00:00
Sam Brannen
e8ef93c508 Polish contribution 
See gh-24321
 2020-01-09 15:56:25 +01:00
lixiaolong11000
047eefd2e2 Improve exception message in AopContext.currentProxy() 
Closes gh-24321
 2020-01-09 15:56:09 +01:00
stsypanov
8e5cad2af3 Add fast path for ClassUtils.hasMethod() 2020-01-08 18:52:15 +01:00
Sam Brannen
141dae6437 Polish contribution 
See gh-24293
 2020-01-07 11:07:03 +01:00
lixiaolong11000
132805133d Improve ExposeInvocationInterceptor exception message 
Closes gh-24293
 2020-01-07 11:03:11 +01:00
Sam Brannen
8a371c7669 Use Gradle test fixture support for spring-aop 
See gh-23550
 2020-01-02 16:01:35 +01:00
Sam Brannen
7cd4ddf5fc Rename test fixture package in spring-beans 
See gh-23550
 2020-01-02 16:01:35 +01:00
Sam Brannen
4260c34b47 Rename test fixture package in spring-core 
See gh-23550
 2020-01-02 16:01:34 +01:00
Sam Brannen
61d4ee594d Use Gradle test fixture support for spring-beans and spring-context 
See gh-23550
 2020-01-02 16:01:34 +01:00
Sam Brannen
5718bf424b Use Gradle test fixture support for spring-core 
See gh-23550
 2020-01-02 16:01:34 +01:00
Pascal Schumacher
e7d489667c Add missing space in AopConfigException message 
See gh-24266
 2019-12-26 09:52:54 +01:00
Sam Brannen
6fdf5ef6ee Polish contribution 
See gh-24205
 2019-12-13 17:14:26 +01:00
Сергей Цыпанов
d9cae339d6 Simplify AdvisedSupport.removeAdvisor() 
Closes gh-24205
 2019-12-13 17:12:18 +01:00
stsypanov
484006ce90 Hoist Class.getName() from String concatenation to dodge an issue related to profile pollution 2019-12-06 17:36:07 +01:00
Sam Brannen
59e250c93c Consistent use of SCOPE_PROTOTYPE and SCOPE_SINGLETON constants 
Closes gh-19905
 2019-11-24 13:49:43 +01:00
Sam Brannen
769a15cb82 Polishing 2019-11-18 13:01:26 +01:00
stsypanov
f2b3953d76 Use array.clone() instead of manual array creation 2019-11-13 13:53:42 +01:00
stsypanov
f5ae3c77c6 Use Method::getParameterCount where possible 2019-11-07 18:00:15 +01:00
Sam Brannen
1a13700f8b Polish contribution 
See gh-23923
 2019-11-06 12:57:01 +01:00
stsypanov
9da15ee23a Improve usage of String.substring() 
Closes gh-23923
 2019-11-06 12:57:01 +01:00
Juergen Hoeller
d00690f43f Merge branch '5.1.x' 
# Conflicts:
#	build.gradle
#	spring-context/spring-context.gradle
#	spring-test/spring-test.gradle
#	spring-web/spring-web.gradle
#	spring-webflux/spring-webflux.gradle
#	spring-webmvc/spring-webmvc.gradle
 2019-09-25 23:13:49 +02:00
Juergen Hoeller
357beb24bc Polishing 2019-09-25 22:15:07 +02:00
Juergen Hoeller
bd70f10d2b Merge branch '5.1.x' 
# Conflicts:
#	build.gradle
#	spring-aop/src/main/java/org/springframework/aop/framework/CglibAopProxy.java
#	spring-aspects/spring-aspects.gradle
#	spring-beans/src/main/java/org/springframework/beans/factory/annotation/AutowiredAnnotationBeanPostProcessor.java
#	spring-beans/src/main/java/org/springframework/beans/factory/support/GenericBeanDefinition.java
#	spring-beans/src/test/java/org/springframework/beans/factory/DefaultListableBeanFactoryTests.java
#	spring-orm/spring-orm.gradle
#	spring-test/spring-test.gradle
 2019-09-25 12:43:24 +02:00
Juergen Hoeller
bb6f9bb6d4 Polishing 2019-09-25 12:14:48 +02:00
Sam Brannen
c256af4ef7 Polishing 2019-09-19 16:31:07 +02:00
Sam Brannen
d611c7484f Fix Checkstyle violation 2019-09-19 16:21:44 +02:00