Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
16,159 Commits 18 Branches 0 Tags
cec7204fca11dfe9b3f5961da97b55a2db719c8a
Commit Graph

2091 Commits

Author SHA1 Message Date
igor-suhorukov
ed936cbd89 Polish: Overriding methods should do more than simply call the same method in the super class 2018-03-02 00:06:27 +01:00
Juergen Hoeller
478162741d WebApplicationContextFacesELResolver.isReadOnly returns true for WAC 
Issue: SPR-16543
 2018-03-01 01:32:11 +01:00
igor-suhorukov
8080f56db8 Polish: "@Override" should be used on overriding and implementing methods 2018-03-01 00:15:18 +01:00
Juergen Hoeller
9962df6527 Polishing 2018-02-28 00:09:15 +01:00
igor-suhorukov
7bce04c06c Polish: combine catches block with same body 2018-02-27 12:51:28 +01:00
Rossen Stoyanchev
e0e90ed006 SSE writer respects charset in MediaType 
Issue: SPR-16516
 2018-02-26 16:42:00 -05:00
Juergen Hoeller
15c97b753e Revised URI building in http.server (consistently use raw attributes) 
Issue: SPR-16434
 2018-02-26 13:00:38 +01:00
Juergen Hoeller
2a379e099c Polishing 2018-02-25 21:24:38 +01:00
Juergen Hoeller
8a56cd0e8b Revised URI building in http.server (avoid package cycle with web.util) 
Issue: SPR-16434
 2018-02-25 21:24:10 +01:00
igor-suhorukov
b202205d77 Polish: String.valueOf() should not be appended to a String 2018-02-25 21:10:19 +01:00
igor-suhorukov
49fd724d8f Polish: String function use should be optimized for single characters 2018-02-25 20:48:47 +01:00
igor-suhorukov
c782075a13 Polish: Array designators "[]" should be on the type, not the variable 2018-02-25 13:14:20 +01:00
Juergen Hoeller
3531c104b0 Prefer Collections.addAll call with array over Set.addAll(Arrays.asList) 2018-02-25 00:21:39 +01:00
Juergen Hoeller
eeecbaef2c Gson/JsonbHttpMessageConverter keeps output stream open (for SseEmitter) 
Issue: SPR-16529
 2018-02-23 10:49:38 +01:00
Juergen Hoeller
578c078082 Polishing 2018-02-22 15:14:20 +01:00
Juergen Hoeller
1278459ad5 ReactorHttpHandlerAdapter logs bad request at warn level only 
Issue: SPR-16524
 2018-02-22 15:12:51 +01:00
Juergen Hoeller
a5cbf5fe24 Consistent use of Collection.toArray with zero-sized array argument 
Includes consistent use of ClassUtils.toClassArray (as non-null variant)

Issue: SPR-16523
 2018-02-22 11:29:46 +01:00
Rossen Stoyanchev
3bfa56dff2 Polish 2018-02-21 10:29:46 -05:00
Rossen Stoyanchev
6959e66b25 JsonEOFException is wrapped as DecodingError 
Jackson2Tokenizer now also wraps JsonProcessingException's on
endOfInput(), as it also does in tokenize(DataBuffer). This ensures
treating those errors as 400 vs 500.

Issue: SPR-16521
 2018-02-21 10:12:33 -05:00
Rossen Stoyanchev
a6d527e57a Call onAllDataRead when read() returns -1 
When read returns -1, we know we've reached the end of input. Instead
of waiting for the onAllDataRead container callback, this commit
proactively calls onAllDataRead.

Issue: SPR-16521
 2018-02-21 09:44:24 -05:00
Juergen Hoeller
0de36d2883 Consistent HttpMethod identity comparisons 2018-02-18 22:01:22 +01:00
Juergen Hoeller
d7cab23e6d Consistent use of StringUtils.toStringArray 
(cherry picked from commit 6d11b40)
 2018-02-16 20:49:17 +01:00
Rossen Stoyanchev
9c679fccdf Fix intdentation 2018-02-16 12:34:25 -05:00
Rossen Stoyanchev
ac495d7380 Polish ForwardedHeaderFilter and related code 
Issue: SPR-16506
 2018-02-16 12:17:23 -05:00
Rossen Stoyanchev
6920a1f958 ForwardedHeaderFilter handles query+fragment correctly 
Issue: SPR-16506
 2018-02-16 11:10:50 -05:00
Rossen Stoyanchev
dcf5c646be Use correct X509 certificate attribute name 
Issue: SPR-16507
 2018-02-16 09:45:17 -05:00
Juergen Hoeller
8d3264f680 Prefer List.sort(Comparator) over Collections.sort(List, Comparator) 2018-02-16 10:23:18 +01:00
Rossen Stoyanchev
4db0d999af Polish UriBuilderFactory and implementation 
Issue: SPR-16422
 2018-02-15 15:44:44 -05:00
Rossen Stoyanchev
3d20db1e49 Polish UriUtils, UriComponents 
Issue: SPR-16422
 2018-02-15 15:44:37 -05:00
Juergen Hoeller
cd8a1bdb8b AcceptHeaderLocaleContextResolver leniently handles invalid header value 
Also falls back to language-only match among its supported locales now.

Issue: SPR-16500
Issue: SPR-16457
 2018-02-15 13:14:49 +01:00
Juergen Hoeller
7baf33fea0 Avoid multiple warnings related to jackson-module-kotlin 
Issue: SPR-16497
 2018-02-14 21:19:57 +01:00
Rossen Stoyanchev
1aeae5d40d Fix compiler error 2018-02-14 12:23:52 -05:00
Rossen Stoyanchev
0ead0503eb AbstractJackson2Encoder uses private fields 
Make the protected fields in AbstractJackson2Encoder private plus
minor refactoring to the way streaming separators are applied.

The current (5.0.3) behavior is to always use '\n', but in 5.0.4 the
newly supported "application/stream+x-jackson-smile" needs to be
excluded from that. For now, separator determination remains private
in the abstract base class, but current behavior remains which is to
apply '\n' by default.

Issue: SPR-15424
 2018-02-14 12:15:01 -05:00
Sam Brannen
24adc7d3c6 Delete unused imports 2018-02-14 16:55:57 +01:00
igor-suhorukov
7826567df6 Polish: lamdbas containing only one statement should not nest this statement in a block 2018-02-14 01:22:01 +01:00
Juergen Hoeller
99662bc702 Polishing 2018-02-13 23:32:10 +01:00
igor-suhorukov
45e520ed86 Polish: remove unused private fields, remove empty operator 2018-02-13 23:00:18 +01:00
Rossen Stoyanchev
8c37ad7ac5 Startup/shutdown log messages for AbstractHttpServer 
Issue: SPR-16494
 2018-02-13 14:58:10 -05:00
Juergen Hoeller
0c78c9c6f7 Refined javadoc and exception messages 2018-02-13 15:25:42 +01:00
Vladimir Sitnikov
659f13be1c Avoid creating message arguments to Assert.isABC calls 
See 67f184293b
 2018-02-13 12:31:49 +01:00
igor-suhorukov
0ee505b73e Polish: assertion arguments should be passed in the correct order, 
use assertNull instead of assertEquals(null, value),
declare delta as double value in assertEquals
 2018-02-10 17:17:28 +01:00
Juergen Hoeller
39201adca4 Consistent handling of InterruptedException 
Issue: SPR-16479
 2018-02-10 13:03:33 +01:00
igor-suhorukov
6ea0af3540 Polish: Lambdas should be replaced with method references 2018-02-10 12:09:46 +01:00
igor-suhorukov
9a6fbf59c5 Polish: follow name convention - make immutable fields final 2018-02-10 12:09:19 +01:00
Stephane Nicoll
991eb4858e Update copyright header 2018-02-09 10:16:58 +01:00
igor-suhorukov
c0b4b5787f Change this "try" to a try-with-resources 
Closes gh-1671
 2018-02-09 10:12:55 +01:00
igor-suhorukov
e381514b07 Collection.isEmpty() should be used to test for emptiness 
Closes gh-1670
 2018-02-09 10:11:44 +01:00
igor-suhorukov
4c888d0f32 Polish 
Closes gh-1669
 2018-02-09 10:10:05 +01:00
Arjen Poutsma
fb61af1882 Allow "release on close" for DataBuffer.asInputStream 
This commit introduces DataBuffer.asInputStream(boolean), that can
release the underlying buffer when the stream is closed.

Furthermore, this commit adds additional javadoc.

Issue: SPR-16444
 2018-02-08 10:11:53 +01:00
Rossen Stoyanchev
1b98d09855 Fix copy+paste error 2018-02-06 15:43:05 -05:00