From 2cafc7cc1b826b4f6a816df6417834021e512b96 Mon Sep 17 00:00:00 2001 From: Mark Paluch Date: Fri, 8 Nov 2024 11:24:08 +0100 Subject: [PATCH] Polishing. Refine assertions to ignore locale-specific error messages. See gh-1085 --- .../observation/GraphQlObservationInstrumentationTests.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/spring-graphql/src/test/java/org/springframework/graphql/observation/GraphQlObservationInstrumentationTests.java b/spring-graphql/src/test/java/org/springframework/graphql/observation/GraphQlObservationInstrumentationTests.java index 6b1f4247..e5c1546d 100644 --- a/spring-graphql/src/test/java/org/springframework/graphql/observation/GraphQlObservationInstrumentationTests.java +++ b/spring-graphql/src/test/java/org/springframework/graphql/observation/GraphQlObservationInstrumentationTests.java @@ -343,12 +343,14 @@ class GraphQlObservationInstrumentationTests { assertThat(response.errorCount()).isEqualTo(1); assertThat(response.error(0).errorType()).isEqualTo("InvalidSyntax"); - assertThat(response.error(0).message()).startsWith("Invalid syntax with offending token 'invalid'"); + assertThat(response.error(0).message()).containsIgnoringCase("syntax") + .containsIgnoringCase("token").contains("'invalid'"); assertThat(observationHandler.getEvents()).hasSize(1); Observation.Event errorEvent = observationHandler.getEvents().get(0); assertThat(errorEvent.getName()).isEqualTo("InvalidSyntax"); - assertThat(errorEvent.getContextualName()).startsWith("Invalid syntax with offending token 'invalid'"); + assertThat(errorEvent.getContextualName()).containsIgnoringCase("syntax") + .containsIgnoringCase("token").contains("'invalid'"); TestObservationRegistryAssert.assertThat(this.observationRegistry).hasObservationWithNameEqualTo("graphql.request") .that().hasLowCardinalityKeyValue("graphql.outcome", "REQUEST_ERROR")