diff --git a/samples/webflux-security/src/main/java/io/spring/sample/graphql/SalaryController.java b/samples/webflux-security/src/main/java/io/spring/sample/graphql/SalaryController.java index f8904a10..7b824184 100644 --- a/samples/webflux-security/src/main/java/io/spring/sample/graphql/SalaryController.java +++ b/samples/webflux-security/src/main/java/io/spring/sample/graphql/SalaryController.java @@ -21,12 +21,12 @@ import java.util.List; import reactor.core.publisher.Mono; import org.springframework.graphql.data.method.annotation.Argument; -import org.springframework.graphql.data.method.annotation.SchemaMapping; -import org.springframework.graphql.data.method.annotation.GraphQlController; import org.springframework.graphql.data.method.annotation.MutationMapping; import org.springframework.graphql.data.method.annotation.QueryMapping; +import org.springframework.graphql.data.method.annotation.SchemaMapping; +import org.springframework.stereotype.Controller; -@GraphQlController +@Controller public class SalaryController { private final EmployeeService employeeService; diff --git a/samples/webflux-websocket/src/main/java/io/spring/sample/graphql/SampleController.java b/samples/webflux-websocket/src/main/java/io/spring/sample/graphql/SampleController.java index 6112178f..c615cf95 100644 --- a/samples/webflux-websocket/src/main/java/io/spring/sample/graphql/SampleController.java +++ b/samples/webflux-websocket/src/main/java/io/spring/sample/graphql/SampleController.java @@ -18,11 +18,11 @@ package io.spring.sample.graphql; import reactor.core.publisher.Flux; import reactor.core.publisher.Mono; -import org.springframework.graphql.data.method.annotation.GraphQlController; import org.springframework.graphql.data.method.annotation.QueryMapping; import org.springframework.graphql.data.method.annotation.SubscriptionMapping; +import org.springframework.stereotype.Controller; -@GraphQlController +@Controller public class SampleController { private final DataRepository repository; diff --git a/samples/webmvc-http-security/src/main/java/io/spring/sample/graphql/SalaryController.java b/samples/webmvc-http-security/src/main/java/io/spring/sample/graphql/SalaryController.java index 8b8a63df..88590091 100644 --- a/samples/webmvc-http-security/src/main/java/io/spring/sample/graphql/SalaryController.java +++ b/samples/webmvc-http-security/src/main/java/io/spring/sample/graphql/SalaryController.java @@ -19,12 +19,12 @@ import java.math.BigDecimal; import java.util.List; import org.springframework.graphql.data.method.annotation.Argument; -import org.springframework.graphql.data.method.annotation.SchemaMapping; -import org.springframework.graphql.data.method.annotation.GraphQlController; import org.springframework.graphql.data.method.annotation.MutationMapping; import org.springframework.graphql.data.method.annotation.QueryMapping; +import org.springframework.graphql.data.method.annotation.SchemaMapping; +import org.springframework.stereotype.Controller; -@GraphQlController +@Controller public class SalaryController { private final EmployeeService employeeService; diff --git a/samples/webmvc-http/src/main/java/io/spring/sample/graphql/greeting/GreetingController.java b/samples/webmvc-http/src/main/java/io/spring/sample/graphql/greeting/GreetingController.java index 05c5fc91..88e170f5 100644 --- a/samples/webmvc-http/src/main/java/io/spring/sample/graphql/greeting/GreetingController.java +++ b/samples/webmvc-http/src/main/java/io/spring/sample/graphql/greeting/GreetingController.java @@ -15,14 +15,14 @@ */ package io.spring.sample.graphql.greeting; -import org.springframework.graphql.data.method.annotation.GraphQlController; import org.springframework.graphql.data.method.annotation.QueryMapping; +import org.springframework.stereotype.Controller; import org.springframework.web.context.request.RequestAttributes; import org.springframework.web.context.request.RequestContextHolder; import static org.springframework.web.context.request.RequestAttributes.SCOPE_REQUEST; -@GraphQlController +@Controller public class GreetingController { @QueryMapping diff --git a/samples/webmvc-http/src/main/java/io/spring/sample/graphql/project/ProjectController.java b/samples/webmvc-http/src/main/java/io/spring/sample/graphql/project/ProjectController.java index 96acbd1f..ed021132 100644 --- a/samples/webmvc-http/src/main/java/io/spring/sample/graphql/project/ProjectController.java +++ b/samples/webmvc-http/src/main/java/io/spring/sample/graphql/project/ProjectController.java @@ -18,11 +18,11 @@ package io.spring.sample.graphql.project; import java.util.List; import org.springframework.graphql.data.method.annotation.Argument; -import org.springframework.graphql.data.method.annotation.SchemaMapping; -import org.springframework.graphql.data.method.annotation.GraphQlController; import org.springframework.graphql.data.method.annotation.QueryMapping; +import org.springframework.graphql.data.method.annotation.SchemaMapping; +import org.springframework.stereotype.Controller; -@GraphQlController +@Controller public class ProjectController { private final SpringProjectsClient client; diff --git a/spring-graphql-docs/src/docs/asciidoc/boot-starter.adoc b/spring-graphql-docs/src/docs/asciidoc/boot-starter.adoc index 3893e40b..cf62dcb0 100644 --- a/spring-graphql-docs/src/docs/asciidoc/boot-starter.adoc +++ b/spring-graphql-docs/src/docs/asciidoc/boot-starter.adoc @@ -124,8 +124,8 @@ starter detects such beans adds them to <>. The Boot starter declares a `RuntimeWiringConfigurer` called `AnnotatedDataFetcherConfigurer` that -detects `@GraphQlController` classes with annotated handler methods and registers those -as ``DataFetcher``s. +detects `@Controller` classes with annotated handler methods and registers those as +``DataFetcher``s. [[boot-repositories-querydsl]] diff --git a/spring-graphql-docs/src/docs/asciidoc/index.adoc b/spring-graphql-docs/src/docs/asciidoc/index.adoc index 8ab05f63..d5715f0b 100644 --- a/spring-graphql-docs/src/docs/asciidoc/index.adoc +++ b/spring-graphql-docs/src/docs/asciidoc/index.adoc @@ -370,7 +370,7 @@ Such repositories are auto-detected in the < beanType) { - return (AnnotatedElementUtils.hasAnnotation(beanType, GraphQlController.class) || + return (AnnotatedElementUtils.hasAnnotation(beanType, Controller.class) || AnnotatedElementUtils.hasAnnotation(beanType, SchemaMapping.class)); } diff --git a/spring-graphql/src/main/java/org/springframework/graphql/data/method/annotation/GraphQlController.java b/spring-graphql/src/main/java/org/springframework/graphql/data/method/annotation/GraphQlController.java index ba4af458..504b9926 100644 --- a/spring-graphql/src/main/java/org/springframework/graphql/data/method/annotation/GraphQlController.java +++ b/spring-graphql/src/main/java/org/springframework/graphql/data/method/annotation/GraphQlController.java @@ -30,11 +30,12 @@ import org.springframework.stereotype.Controller; * {@link QueryMapping}, {@link MutationMapping}, and {@link SubscriptionMapping}. * * @author Rossen Stoyanchev - * @since 1.0.0 + * @deprecated in favor of using {@link Controller @Controller} */ @Target(ElementType.TYPE) @Retention(RetentionPolicy.RUNTIME) @Documented @Controller +@Deprecated public @interface GraphQlController { } diff --git a/spring-graphql/src/test/java/org/springframework/graphql/data/method/AnnotatedDataFetcherConfigurerTests.java b/spring-graphql/src/test/java/org/springframework/graphql/data/method/AnnotatedDataFetcherConfigurerTests.java index 5fee1ae1..291cc88d 100644 --- a/spring-graphql/src/test/java/org/springframework/graphql/data/method/AnnotatedDataFetcherConfigurerTests.java +++ b/spring-graphql/src/test/java/org/springframework/graphql/data/method/AnnotatedDataFetcherConfigurerTests.java @@ -27,12 +27,12 @@ import org.springframework.context.annotation.AnnotationConfigApplicationContext import org.springframework.graphql.Author; import org.springframework.graphql.Book; import org.springframework.graphql.data.method.annotation.Argument; -import org.springframework.graphql.data.method.annotation.GraphQlController; -import org.springframework.graphql.data.method.annotation.SchemaMapping; import org.springframework.graphql.data.method.annotation.MutationMapping; import org.springframework.graphql.data.method.annotation.QueryMapping; +import org.springframework.graphql.data.method.annotation.SchemaMapping; import org.springframework.graphql.data.method.annotation.SubscriptionMapping; import org.springframework.http.converter.json.MappingJackson2HttpMessageConverter; +import org.springframework.stereotype.Controller; import static org.assertj.core.api.Assertions.assertThat; @@ -100,7 +100,7 @@ public class AnnotatedDataFetcherConfigurerTests { } - @GraphQlController + @Controller private static class BookController { diff --git a/spring-graphql/src/test/java/org/springframework/graphql/data/method/AnnotatedDataFetcherInvocationTests.java b/spring-graphql/src/test/java/org/springframework/graphql/data/method/AnnotatedDataFetcherInvocationTests.java index 3066256c..fb209cb4 100644 --- a/spring-graphql/src/test/java/org/springframework/graphql/data/method/AnnotatedDataFetcherInvocationTests.java +++ b/spring-graphql/src/test/java/org/springframework/graphql/data/method/AnnotatedDataFetcherInvocationTests.java @@ -35,13 +35,13 @@ import org.springframework.graphql.Book; import org.springframework.graphql.BookCriteria; import org.springframework.graphql.BookSource; import org.springframework.graphql.data.method.annotation.Argument; -import org.springframework.graphql.data.method.annotation.GraphQlController; import org.springframework.graphql.data.method.annotation.MutationMapping; import org.springframework.graphql.data.method.annotation.QueryMapping; import org.springframework.graphql.data.method.annotation.SchemaMapping; import org.springframework.graphql.data.method.annotation.SubscriptionMapping; import org.springframework.graphql.execution.GraphQlSource; import org.springframework.http.codec.ServerCodecConfigurer; +import org.springframework.stereotype.Controller; import static org.assertj.core.api.Assertions.assertThat; @@ -204,7 +204,7 @@ public class AnnotatedDataFetcherInvocationTests { } - @GraphQlController + @Controller private static class BookController { @QueryMapping