From 5aac81c0035f0142360ae5317cc040357992221e Mon Sep 17 00:00:00 2001 From: Rossen Stoyanchev Date: Wed, 3 Nov 2021 17:24:26 +0000 Subject: [PATCH] Polishing contribution Closes gh-176 --- .../springframework/graphql/test/tester/GraphQlTester.java | 3 ++- .../graphql/test/tester/GraphQlTesterTests.java | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/spring-graphql-test/src/main/java/org/springframework/graphql/test/tester/GraphQlTester.java b/spring-graphql-test/src/main/java/org/springframework/graphql/test/tester/GraphQlTester.java index 9b04c378..ef123463 100644 --- a/spring-graphql-test/src/main/java/org/springframework/graphql/test/tester/GraphQlTester.java +++ b/spring-graphql-test/src/main/java/org/springframework/graphql/test/tester/GraphQlTester.java @@ -170,7 +170,8 @@ public interface GraphQlTester { /** * Add a variable. * @param name the variable name - * @param value the variable value + * @param value the variable value, possibly {@code null} since GraphQL + * supports providing null value vs not providing a value at all. * @return this request spec */ T variable(String name, @Nullable Object value); diff --git a/spring-graphql-test/src/test/java/org/springframework/graphql/test/tester/GraphQlTesterTests.java b/spring-graphql-test/src/test/java/org/springframework/graphql/test/tester/GraphQlTesterTests.java index f9df0295..d287b414 100644 --- a/spring-graphql-test/src/test/java/org/springframework/graphql/test/tester/GraphQlTesterTests.java +++ b/spring-graphql-test/src/test/java/org/springframework/graphql/test/tester/GraphQlTesterTests.java @@ -179,7 +179,7 @@ public class GraphQlTesterTests { .operationName("HeroNameAndFriends") .variable("episode", "JEDI") .variable("foo", "bar") - .variable("optional", null) + .variable("keyOnly", null) .execute(); spec.path("hero").entity(MovieCharacter.class).isEqualTo(MovieCharacter.create("R2-D2")); @@ -190,7 +190,7 @@ public class GraphQlTesterTests { assertThat(input.getVariables()).hasSize(3); assertThat(input.getVariables()).containsEntry("episode", "JEDI"); assertThat(input.getVariables()).containsEntry("foo", "bar"); - assertThat(input.getVariables()).containsEntry("optional", null); + assertThat(input.getVariables()).containsEntry("keyOnly", null); } @Test