diff --git a/src/main/java/org/springframework/guice/annotation/GuiceModuleRegistrar.java b/src/main/java/org/springframework/guice/annotation/GuiceModuleRegistrar.java index 5a1ebd2..7acb74b 100644 --- a/src/main/java/org/springframework/guice/annotation/GuiceModuleRegistrar.java +++ b/src/main/java/org/springframework/guice/annotation/GuiceModuleRegistrar.java @@ -137,7 +137,7 @@ class GuiceModuleRegistrar implements ImportBeanDefinitionRegistrar, .include( includeNames.toArray(new String[includeNames.size()])) .exclude( - excludeNames.toArray(new Pattern[excludeNames.size()])); + excludeNames.toArray(new String[excludeNames.size()])); } @Override diff --git a/src/test/java/org/springframework/guice/annotation/GuiceModuleAnnotationTests.java b/src/test/java/org/springframework/guice/annotation/GuiceModuleAnnotationTests.java index ef84be4..753c582 100644 --- a/src/test/java/org/springframework/guice/annotation/GuiceModuleAnnotationTests.java +++ b/src/test/java/org/springframework/guice/annotation/GuiceModuleAnnotationTests.java @@ -68,6 +68,18 @@ public class GuiceModuleAnnotationTests { assertNull(injector.getInstance(Service.class)); } + @Test(expected = ConfigurationException.class) + public void excludesNames() throws Exception { + Injector injector = createInjector(TestConfig.class, MetadataExcludeNamesConfig.class); + injector.getBinding(Service.class); + } + + @Test(expected = ConfigurationException.class) + public void excludesPatterns() throws Exception { + Injector injector = createInjector(TestConfig.class, MetadataExcludePatternsConfig.class); + injector.getBinding(Service.class); + } + @Test public void twoIncludes() throws Exception { Injector injector = createInjector(TestConfig.class, MetadataIncludesConfig.class, MetadataMoreIncludesConfig.class); @@ -98,9 +110,14 @@ public class GuiceModuleAnnotationTests { protected static class MetadataExcludesConfig { } + @Configuration + @GuiceModule(excludeNames="*") + protected static class MetadataExcludeNamesConfig { + } + @Configuration @GuiceModule(excludePatterns=".*") - protected static class MetadataExcludesNameConfig { + protected static class MetadataExcludePatternsConfig { } @Configuration