Spring/spring-hateoas
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#977 - Performance improvements in link generation.

Browse Source 
Introduced more caches for reusable value objects: UriTemplate, MethodParameters. Cache UriTemplate.toString() to avoid re-computation. Avoid recomputing the affordances if possible in WebHandler. Removed cache in AnnotatedParametersParameterAccessor as that one now transitively benefits from the one introduced in MethodParameters.

Related ticket: spring-projects/spring-framework#22730.
This commit is contained in:
Oliver Drotbohm
2019-04-03 18:31:46 +02:00
parent fc3767b90b
commit 39404ea2d9
15 changed files with 152 additions and 137 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/main/java/org/springframework/hateoas/Link.java
View File

@@ -118,7 +118,7 @@ public class Link implements Serializable {
* @param rel must not be {@literal null} or empty.
*/
public Link(String href, String rel) {
this(new UriTemplate(href), LinkRelation.of(rel));
this(UriTemplate.of(href), LinkRelation.of(rel));
}
/**
@@ -128,7 +128,7 @@ public class Link implements Serializable {
* @param rel must not be {@literal null} or empty.
*/
public Link(String href, LinkRelation rel) {
this(new UriTemplate(href), rel);
this(UriTemplate.of(href), rel);
}
/**
@@ -299,7 +299,7 @@ public class Link implements Serializable {
*/
@JsonIgnore
public List<String> getVariableNames() {
return getUriTemplate().getVariableNames();
return template.getVariableNames();
}
/**
@@ -309,7 +309,7 @@ public class Link implements Serializable {
*/
@JsonIgnore
public List<TemplateVariable> getVariables() {
return getUriTemplate().getVariables();
return template.getVariables();
}
/**
@@ -318,7 +318,7 @@ public class Link implements Serializable {
* @return
*/
public boolean isTemplated() {
return !getUriTemplate().getVariables().isEmpty();
return !template.getVariables().isEmpty();
}
/**
@@ -328,7 +328,7 @@ public class Link implements Serializable {
* @return
*/
public Link expand(Object... arguments) {
return new Link(getUriTemplate().expand(arguments).toString(), getRel());
return new Link(template.expand(arguments).toString(), getRel());
}
/**
@@ -338,7 +338,7 @@ public class Link implements Serializable {
* @return
*/
public Link expand(Map<String, ? extends Object> arguments) {
return new Link(getUriTemplate().expand(arguments).toString(), getRel());
return new Link(template.expand(arguments).toString(), getRel());
}
/**
@@ -390,15 +390,6 @@ public class Link implements Serializable {
return this.rel.isSameAs(rel);
}
private UriTemplate getUriTemplate() {
if (this.template == null) {
this.template = new UriTemplate(href);
}
return this.template;
}
/**
* Returns the current href as URI after expanding the links without any arguments, i.e. all optional URI
* {@link TemplateVariable}s will be dropped. If the href contains mandatory {@link TemplateVariable}s, the URI