Spring/spring-hateoas
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#1405 - Use ConcurrentLruCache for affordances.

Browse Source 
We now use a ConcurrentLruCache limited to 256 entries instead of a ConcurrentReferenceHashMap to cache Affordance instances to prevent the cache from growing unboundedly before GC kicks in.
This commit is contained in:
Oliver Drotbohm
2021-01-20 20:30:30 +01:00
parent 752b000e6c
commit 60bf4e92ff
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/java/org/springframework/hateoas/server/core/WebHandler.java
View File

@@ -38,7 +38,7 @@ import org.springframework.hateoas.TemplateVariables;
import org.springframework.hateoas.server.LinkBuilder;
import org.springframework.lang.Nullable;
import org.springframework.util.Assert;
import org.springframework.util.ConcurrentReferenceHashMap;
import org.springframework.util.ConcurrentLruCache;
import org.springframework.util.LinkedMultiValueMap;
import org.springframework.util.MultiValueMap;
import org.springframework.util.ObjectUtils;
@@ -63,7 +63,8 @@ public class WebHandler {
public static final MappingDiscoverer DISCOVERER = CachingMappingDiscoverer
.of(new PropertyResolvingMappingDiscoverer(new AnnotationMappingDiscoverer(RequestMapping.class)));
private static final Map<AffordanceKey, List<Affordance>> AFFORDANCES_CACHE = new ConcurrentReferenceHashMap<>();
private static final ConcurrentLruCache<AffordanceKey, List<Affordance>> AFFORDANCES_CACHE = new ConcurrentLruCache<>(
256, key -> SpringAffordanceBuilder.create(key.type, key.method, key.href.toUriString(), DISCOVERER));
public interface LinkBuilderCreator<T extends LinkBuilder> {
T createBuilder(UriComponents components, TemplateVariables variables, List<Affordance> affordances);
@@ -160,9 +161,8 @@ public class WebHandler {
variables = variables.concat(variable);
}
List<Affordance> affordances = AFFORDANCES_CACHE.computeIfAbsent(
new AffordanceKey(invocation.getTargetType(), invocation.getMethod(), components),
key -> SpringAffordanceBuilder.create(key.type, key.method, key.href.toUriString(), DISCOVERER));
List<Affordance> affordances = AFFORDANCES_CACHE
.get(new AffordanceKey(invocation.getTargetType(), invocation.getMethod(), components));
return creator.createBuilder(components, variables, affordances);
};