diff --git a/src/main/java/org/springframework/hateoas/core/LinkBuilderSupport.java b/src/main/java/org/springframework/hateoas/core/LinkBuilderSupport.java index e9259b19..e79251bc 100644 --- a/src/main/java/org/springframework/hateoas/core/LinkBuilderSupport.java +++ b/src/main/java/org/springframework/hateoas/core/LinkBuilderSupport.java @@ -1,5 +1,5 @@ /* - * Copyright 2012-2014 the original author or authors. + * Copyright 2012-2016 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -33,6 +33,7 @@ import org.springframework.web.util.UriComponentsBuilder; * @author Ricardo Gladwell * @author Oliver Gierke * @author Kamill Sokol + * @author Kevin Conaway */ public abstract class LinkBuilderSupport implements LinkBuilder { @@ -45,12 +46,18 @@ public abstract class LinkBuilderSupport implements LinkB */ public LinkBuilderSupport(UriComponentsBuilder builder) { - Assert.notNull(builder); + Assert.notNull(builder, "UriComponentsBuilder must not be null!"); this.uriComponents = builder.build(); } + /** + * Creates a new {@link LinkBuilderSupport} using the given {@link UriComponents}. + * + * @param uriComponents must not be {@literal null}. + */ public LinkBuilderSupport(UriComponents uriComponents) { - Assert.notNull(uriComponents); + + Assert.notNull(uriComponents, "UriComponents must not be null!"); this.uriComponents = uriComponents; } @@ -79,8 +86,7 @@ public abstract class LinkBuilderSupport implements LinkB } String uriString = uriComponents.toUriString(); - UriComponentsBuilder builder = uriString.isEmpty() ? fromUri(uriComponents.toUri()) - : fromUriString(uriString); + UriComponentsBuilder builder = uriString.isEmpty() ? fromUri(uriComponents.toUri()) : fromUriString(uriString); UriComponents components = UriComponentsBuilder.fromUriString(path).build(); diff --git a/src/main/java/org/springframework/hateoas/mvc/ControllerLinkBuilder.java b/src/main/java/org/springframework/hateoas/mvc/ControllerLinkBuilder.java index de281314..90f8a9bf 100755 --- a/src/main/java/org/springframework/hateoas/mvc/ControllerLinkBuilder.java +++ b/src/main/java/org/springframework/hateoas/mvc/ControllerLinkBuilder.java @@ -1,5 +1,5 @@ /* - * Copyright 2012-2015 the original author or authors. + * Copyright 2012-2016 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -43,6 +43,7 @@ import org.springframework.web.util.UriTemplate; * @author Oliver Gierke * @author Kamill Sokol * @author Greg Turnquist + * @author Kevin Conaway */ public class ControllerLinkBuilder extends LinkBuilderSupport { @@ -60,15 +61,15 @@ public class ControllerLinkBuilder extends LinkBuilderSupport - * @RequestMapping("/customers") + * @RequestMapping("/customers") * class CustomerController { * - * @RequestMapping("/{id}/addresses") + * @RequestMapping("/{id}/addresses") * HttpEntity<Addresses> showAddresses(@PathVariable Long id) { … } * } * diff --git a/src/main/java/org/springframework/hateoas/mvc/ControllerLinkBuilderFactory.java b/src/main/java/org/springframework/hateoas/mvc/ControllerLinkBuilderFactory.java index d1ce4981..ba3d7a19 100644 --- a/src/main/java/org/springframework/hateoas/mvc/ControllerLinkBuilderFactory.java +++ b/src/main/java/org/springframework/hateoas/mvc/ControllerLinkBuilderFactory.java @@ -1,5 +1,5 @@ /* - * Copyright 2012-2015 the original author or authors. + * Copyright 2012-2016 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -55,6 +55,7 @@ import org.springframework.web.util.UriTemplate; * @author Kamill Sokol * @author Ross Turner * @author Oemer Yildiz + * @author Kevin Conaway */ public class ControllerLinkBuilderFactory implements MethodLinkBuilderFactory { @@ -156,7 +157,8 @@ public class ControllerLinkBuilderFactory implements MethodLinkBuilderFactory parameterValues = Arrays.asList(invocation.getArguments()).iterator(); @@ -235,8 +237,8 @@ public class ControllerLinkBuilderFactory implements MethodLinkBuilderFactory