From ca0263fc5aa5969f41d545179dfe8545749d5afe Mon Sep 17 00:00:00 2001 From: Johnny Lim Date: Thu, 22 Nov 2018 22:40:35 +0900 Subject: [PATCH] #751 - Align Hop header assertions with HttpHeaders and javadocs. Spring Framework accepts `null` for header values in HttpHeaders. This is already reflected in the javadocs. --- src/main/java/org/springframework/hateoas/client/Hop.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/main/java/org/springframework/hateoas/client/Hop.java b/src/main/java/org/springframework/hateoas/client/Hop.java index 3d887f61..9f60827a 100644 --- a/src/main/java/org/springframework/hateoas/client/Hop.java +++ b/src/main/java/org/springframework/hateoas/client/Hop.java @@ -95,8 +95,7 @@ public class Hop { */ public Hop header(String headerName, String headerValue) { - Assert.notNull(headerName, "headerName must not be null!"); - Assert.notNull(headerValue, "headerValue must not be null!"); + Assert.hasText(headerName, "headerName must not be null or empty!"); if (this.headers == HttpHeaders.EMPTY) {