Spring/spring-hateoas
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#838 - Improved registration of BeanPostProcessor implementations.

Browse Source 
The BeanPostProcessor implementations in (WebMVC|WebFlux)HateoasConfiguration are now declared as static methods and their dependencies use ObjectProvider wrapper types to prevent the need to prematurely initialize the entire configuration class which triggered the creation of a lot of downstream dependencies which were then reported as ineligible for post processing themselves.
This commit is contained in:
Oliver Drotbohm
2019-02-28 15:56:08 +01:00
parent a89e57eed7
commit df4e099458
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/main/java/org/springframework/hateoas/config/WebFluxHateoasConfiguration.java
View File

@@ -54,7 +54,8 @@ class WebFluxHateoasConfiguration {
}
@Bean
HypermediaWebClientBeanPostProcessor webClientBeanPostProcessor(WebClientConfigurer configurer) {
static HypermediaWebClientBeanPostProcessor webClientBeanPostProcessor(
ObjectProvider<WebClientConfigurer> configurer) {
return new HypermediaWebClientBeanPostProcessor(configurer);
}
@@ -85,7 +86,7 @@ class WebFluxHateoasConfiguration {
@RequiredArgsConstructor
static class HypermediaWebClientBeanPostProcessor implements BeanPostProcessor {
private final WebClientConfigurer configurer;
private final ObjectProvider<WebClientConfigurer> configurer;
/*
* (non-Javadoc)
@@ -95,7 +96,7 @@ class WebFluxHateoasConfiguration {
public Object postProcessBeforeInitialization(Object bean, String beanName) throws BeansException {
if (bean instanceof WebClient) {
return this.configurer.registerHypermediaTypes((WebClient) bean);
return this.configurer.getObject().registerHypermediaTypes((WebClient) bean);
}
return bean;

7
src/main/java/org/springframework/hateoas/config/WebMvcHateoasConfiguration.java
View File

@@ -52,7 +52,8 @@ class WebMvcHateoasConfiguration {
}
@Bean
HypermediaRestTemplateBeanPostProcessor restTemplateBeanPostProcessor(HypermediaWebMvcConfigurer configurer) {
static HypermediaRestTemplateBeanPostProcessor restTemplateBeanPostProcessor(
ObjectProvider<HypermediaWebMvcConfigurer> configurer) {
return new HypermediaRestTemplateBeanPostProcessor(configurer);
}
@@ -100,7 +101,7 @@ class WebMvcHateoasConfiguration {
@RequiredArgsConstructor
static class HypermediaRestTemplateBeanPostProcessor implements BeanPostProcessor {
private final HypermediaWebMvcConfigurer configurer;
private final ObjectProvider<HypermediaWebMvcConfigurer> configurer;
/*
* (non-Javadoc)
@@ -113,7 +114,7 @@ class WebMvcHateoasConfiguration {
return bean;
}
configurer.extendMessageConverters(((RestTemplate) bean).getMessageConverters());
configurer.getObject().extendMessageConverters(((RestTemplate) bean).getMessageConverters());
return bean;
}