Spring/spring-integration-samples
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make fields immutable (final) where possible

Browse Source
This commit is contained in:
René Scheibe
2022-06-08 16:13:03 +02:00
committed by GitHub
parent 9f4428153c
commit 80af14a2e6
40 changed files with 80 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
applications/cafe-scripted/src/main/java/org/springframework/integration/samples/cafe/Delivery.java
View File

@@ -25,11 +25,9 @@ public class Delivery {
private static final String SEPARATOR = "-----------------------";
private final List<Drink> deliveredDrinks;
private List<Drink> deliveredDrinks;
private int orderNumber;
private final int orderNumber;
public Delivery(List<Drink> deliveredDrinks) {
assert(deliveredDrinks.size() > 0);
@@ -37,7 +35,6 @@ public class Delivery {
this.orderNumber = deliveredDrinks.get(0).getOrderNumber();
}
public int getOrderNumber() {
return orderNumber;
}

10
applications/cafe-scripted/src/main/java/org/springframework/integration/samples/cafe/Drink.java
View File

@@ -21,15 +21,14 @@ package org.springframework.integration.samples.cafe;
*/
public class Drink {
private boolean iced;
private final boolean iced;
private int shots;
private final int shots;
private DrinkType drinkType;
private final DrinkType drinkType;
private int orderNumber;
private final int orderNumber;
public Drink(int orderNumber, DrinkType drinkType, boolean hot, int shots) {
this.orderNumber = orderNumber;
this.drinkType = drinkType;
@@ -37,7 +36,6 @@ public class Drink {
this.shots = shots;
}
public int getOrderNumber() {
return orderNumber;
}

6
applications/cafe-scripted/src/main/java/org/springframework/integration/samples/cafe/Order.java
View File

@@ -25,9 +25,9 @@ import java.util.List;
*/
public class Order {
private List<OrderItem> orderItems = new ArrayList<OrderItem>();
private final List<OrderItem> orderItems = new ArrayList<OrderItem>();
private int number;
private final int number;
public Order(int number) {
this.number = number;
@@ -44,7 +44,7 @@ public class Order {
public List<OrderItem> getItems() {
return this.orderItems;
}
public String toString() {
return "Order number " + number;
}

2
applications/cafe-scripted/src/main/java/org/springframework/integration/samples/cafe/Waiter.java
View File

@@ -31,7 +31,7 @@ import org.springframework.jmx.export.annotation.ManagedResource;
@ManagedResource
public class Waiter {
private AtomicInteger totalDeliveries = new AtomicInteger();
private final AtomicInteger totalDeliveries = new AtomicInteger();
public Delivery prepareDelivery(List<Drink> drinks) {
totalDeliveries.getAndIncrement();

2
applications/cafe-scripted/src/main/java/org/springframework/integration/samples/cafe/demo/ControlBusMain.java
View File

@@ -30,7 +30,7 @@ import org.springframework.integration.samples.cafe.WaiterMonitor;
*
*/
public class ControlBusMain {
private static Log logger = LogFactory.getLog(ControlBusMain.class);
private static final Log logger = LogFactory.getLog(ControlBusMain.class);
public static void main(String[] args) {