diff --git a/spring-integration-ftp/src/test/java/org/springframework/integration/ftp/config/FtpInboundOutboundSanitySample.java b/spring-integration-ftp/src/test/java/org/springframework/integration/ftp/config/FtpInboundOutboundSanitySample.java index 79eb64e24c..106465fc4b 100644 --- a/spring-integration-ftp/src/test/java/org/springframework/integration/ftp/config/FtpInboundOutboundSanitySample.java +++ b/spring-integration-ftp/src/test/java/org/springframework/integration/ftp/config/FtpInboundOutboundSanitySample.java @@ -23,7 +23,7 @@ import java.io.File; import org.junit.Ignore; import org.junit.Test; -import org.springframework.context.ApplicationContext; +import org.springframework.context.ConfigurableApplicationContext; import org.springframework.context.support.ClassPathXmlApplicationContext; import org.springframework.messaging.MessageChannel; import org.springframework.messaging.support.GenericMessage; @@ -55,18 +55,20 @@ public class FtpInboundOutboundSanitySample { fileB.delete(); } - new ClassPathXmlApplicationContext("FtpInboundChannelAdapterSample-context.xml", this.getClass()); + ConfigurableApplicationContext context = + new ClassPathXmlApplicationContext("FtpInboundChannelAdapterSample-context.xml", this.getClass()); Thread.sleep(3000); fileA = new File("local-test-dir/b.test"); fileB = new File("local-test-dir/b.test"); assertTrue(fileA.exists()); assertTrue(fileB.exists()); + context.close(); } @Test @Ignore public void testFtpOutboundChannelAdapter() throws Exception{ - ApplicationContext ac = + ConfigurableApplicationContext ac = new ClassPathXmlApplicationContext("FtpOutboundChannelAdapterSample-context.xml", this.getClass()); File fileA = new File("local-test-dir/a.test"); File fileB = new File("local-test-dir/b.test"); @@ -78,6 +80,7 @@ public class FtpInboundOutboundSanitySample { fileB = new File("remote-target-dir/b.test"); assertTrue(fileA.exists()); assertTrue(fileB.exists()); + ac.close(); } } diff --git a/spring-integration-sftp/src/test/java/org/springframework/integration/sftp/config/InboundChannelAdapterParserCachingTests.java b/spring-integration-sftp/src/test/java/org/springframework/integration/sftp/config/InboundChannelAdapterParserCachingTests.java index b432292dd0..a8addda7ce 100644 --- a/spring-integration-sftp/src/test/java/org/springframework/integration/sftp/config/InboundChannelAdapterParserCachingTests.java +++ b/spring-integration-sftp/src/test/java/org/springframework/integration/sftp/config/InboundChannelAdapterParserCachingTests.java @@ -28,6 +28,7 @@ import org.springframework.beans.factory.annotation.Autowired; import org.springframework.integration.file.remote.session.CachingSessionFactory; import org.springframework.integration.sftp.session.DefaultSftpSessionFactory; import org.springframework.integration.test.util.TestUtils; +import org.springframework.test.annotation.DirtiesContext; import org.springframework.test.context.ContextConfiguration; import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; @@ -38,6 +39,7 @@ import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; */ @ContextConfiguration @RunWith(SpringJUnit4ClassRunner.class) +@DirtiesContext public class InboundChannelAdapterParserCachingTests { @Autowired private Object cachingAdapter; diff --git a/spring-integration-sftp/src/test/java/org/springframework/integration/sftp/config/InboundChannelAdapterParserTests.java b/spring-integration-sftp/src/test/java/org/springframework/integration/sftp/config/InboundChannelAdapterParserTests.java index 54640f371f..9cf15e75db 100644 --- a/spring-integration-sftp/src/test/java/org/springframework/integration/sftp/config/InboundChannelAdapterParserTests.java +++ b/spring-integration-sftp/src/test/java/org/springframework/integration/sftp/config/InboundChannelAdapterParserTests.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2013 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -31,17 +31,18 @@ import org.junit.After; import org.junit.Before; import org.junit.Ignore; import org.junit.Test; + import org.springframework.beans.factory.BeanCreationException; import org.springframework.beans.factory.BeanDefinitionStoreException; -import org.springframework.context.ApplicationContext; +import org.springframework.context.ConfigurableApplicationContext; import org.springframework.context.support.ClassPathXmlApplicationContext; -import org.springframework.messaging.MessageChannel; -import org.springframework.messaging.PollableChannel; import org.springframework.integration.endpoint.SourcePollingChannelAdapter; import org.springframework.integration.file.filters.FileListFilter; import org.springframework.integration.sftp.inbound.SftpInboundFileSynchronizer; import org.springframework.integration.sftp.inbound.SftpInboundFileSynchronizingMessageSource; import org.springframework.integration.test.util.TestUtils; +import org.springframework.messaging.MessageChannel; +import org.springframework.messaging.PollableChannel; /** * @author Oleg Zhurakousky @@ -57,16 +58,17 @@ public class InboundChannelAdapterParserTests { @Test public void testAutoStartup() throws Exception{ - ApplicationContext context = + ConfigurableApplicationContext context = new ClassPathXmlApplicationContext("SftpInboundAutostartup-context.xml", this.getClass()); SourcePollingChannelAdapter adapter = context.getBean("sftpAutoStartup", SourcePollingChannelAdapter.class); assertFalse(adapter.isRunning()); + context.close(); } @Test public void testWithLocalFiles() throws Exception{ - ApplicationContext context = + ConfigurableApplicationContext context = new ClassPathXmlApplicationContext("InboundChannelAdapterParserTests-context.xml", this.getClass()); assertTrue(new File("src/main/resources").exists()); @@ -90,43 +92,48 @@ public class InboundChannelAdapterParserTests { PollableChannel requestChannel = context.getBean("requestChannel", PollableChannel.class); assertNotNull(requestChannel.receive(2000)); FileListFilter acceptAllFilter = context.getBean("acceptAllFilter", FileListFilter.class); - assertTrue(TestUtils.getPropertyValue(source, "fileSource.scanner.filter.fileFilters", Collection.class).contains(acceptAllFilter)); + assertTrue(TestUtils.getPropertyValue(source, "fileSource.scanner.filter.fileFilters", Collection.class) + .contains(acceptAllFilter)); + context.close(); } @Test public void testAutoChannel() { - ApplicationContext context = + ConfigurableApplicationContext context = new ClassPathXmlApplicationContext("InboundChannelAdapterParserTests-context.xml", this.getClass()); // Auto-created channel MessageChannel autoChannel = context.getBean("autoChannel", MessageChannel.class); - SourcePollingChannelAdapter autoChannelAdapter = context.getBean("autoChannel.adapter", SourcePollingChannelAdapter.class); + SourcePollingChannelAdapter autoChannelAdapter = context.getBean("autoChannel.adapter", + SourcePollingChannelAdapter.class); assertSame(autoChannel, TestUtils.getPropertyValue(autoChannelAdapter, "outputChannel")); + context.close(); } @Test(expected=BeanDefinitionStoreException.class) //exactly one of 'filename-pattern' or 'filter' is allowed on SFTP inbound adapter public void testFailWithFilePatternAndFilter() throws Exception{ assertTrue(!new File("target/bar").exists()); - new ClassPathXmlApplicationContext("InboundChannelAdapterParserTests-context-fail.xml", this.getClass()); + new ClassPathXmlApplicationContext("InboundChannelAdapterParserTests-context-fail.xml", this.getClass()).close(); } @Test @Ignore public void testLocalFilesAreFound() throws Exception{ assertTrue(new File("target").exists()); - new ClassPathXmlApplicationContext("InboundChannelAdapterParserTests-context.xml", this.getClass()); + new ClassPathXmlApplicationContext("InboundChannelAdapterParserTests-context.xml", this.getClass()).close(); assertTrue(new File("target").exists()); } @Test public void testLocalDirAutoCreated() throws Exception{ assertFalse(new File("foo").exists()); - new ClassPathXmlApplicationContext("InboundChannelAdapterParserTests-context.xml", this.getClass()); + new ClassPathXmlApplicationContext("InboundChannelAdapterParserTests-context.xml", this.getClass()).close(); assertTrue(new File("foo").exists()); } @Test(expected=BeanCreationException.class) public void testLocalDirAutoCreateFailed() throws Exception{ - new ClassPathXmlApplicationContext("InboundChannelAdapterParserTests-context-fail-autocreate.xml", this.getClass()); + new ClassPathXmlApplicationContext("InboundChannelAdapterParserTests-context-fail-autocreate.xml", + this.getClass()).close(); } @After