Spring/spring-integration
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Sonar fixes

Browse Source 
- printStackTrace in test mail server
- Illegal throws
- Large anon. classes

* - indexOf char
- stored external object

* - ignored exceptional return values

* - checkstyle
This commit is contained in:
Gary Russell
2019-04-30 13:57:13 -04:00
committed by Artem Bilan
parent 4199ff57cd
commit 0bb901b286
19 changed files with 280 additions and 235 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
spring-integration-file/src/main/java/org/springframework/integration/file/remote/gateway/AbstractRemoteFileOutboundGateway.java
View File

@@ -685,10 +685,10 @@ public abstract class AbstractRemoteFileOutboundGateway<F> extends AbstractReply
* nothing.
* @param remoteFileOperations the remote file template.
* @param path the path.
* @param chmod the chmod to set.
* @param chmodToSet the chmod to set.
* @since 4.3
*/
protected void doChmod(RemoteFileOperations<F> remoteFileOperations, String path, int chmod) {
protected void doChmod(RemoteFileOperations<F> remoteFileOperations, String path, int chmodToSet) {
// no-op
}
@@ -921,7 +921,9 @@ public abstract class AbstractRemoteFileOutboundGateway<F> extends AbstractReply
outputStream = new BufferedOutputStream(new FileOutputStream(tempFile));
}
if (replacing) {
localFile.delete();
if (!localFile.delete() && this.logger.isWarnEnabled()) {
this.logger.warn("Failed to delete " + localFile);
}
}
try {
session.read(remoteFilePath, outputStream);
@@ -944,7 +946,7 @@ public abstract class AbstractRemoteFileOutboundGateway<F> extends AbstractReply
try {
outputStream.close();
}
catch (Exception ignored2) {
catch (@SuppressWarnings("unused") Exception ignored2) {
//Ignore it
}
}
@@ -953,7 +955,9 @@ public abstract class AbstractRemoteFileOutboundGateway<F> extends AbstractReply
}
if (this.options.contains(Option.PRESERVE_TIMESTAMP)
|| FileExistsMode.REPLACE_IF_MODIFIED.equals(existsMode)) {
localFile.setLastModified(getModified(fileInfo));
if (!localFile.setLastModified(getModified(fileInfo)) && this.logger.isWarnEnabled()) {
logger.warn("Failed to set lastModified on " + localFile);
}
}
if (this.options.contains(Option.DELETE)) {
boolean result = session.remove(remoteFilePath);

4
spring-integration-file/src/main/java/org/springframework/integration/file/remote/synchronizer/AbstractInboundFileSynchronizingMessageSource.java
View File

@@ -181,7 +181,9 @@ public abstract class AbstractInboundFileSynchronizingMessageSource<F>
if (logger.isDebugEnabled()) {
logger.debug("The '" + this.localDirectory + "' directory doesn't exist; Will create.");
}
this.localDirectory.mkdirs();
if (!this.localDirectory.mkdirs() && this.logger.isWarnEnabled()) {
this.logger.warn("Failed to create directories for " + this.localDirectory);
}
}
else {
throw new FileNotFoundException(this.localDirectory.getName());