Sonar - protected fields

This commit is contained in:
Gary Russell
2019-05-01 16:18:58 -04:00
committed by Artem Bilan
parent 37e49a23f4
commit 0d6faa2e34
58 changed files with 278 additions and 261 deletions

View File

@@ -73,67 +73,67 @@ public abstract class AbstractConnectionFactory extends IntegrationObjectSupport
private static final int DEFAULT_READ_DELAY = 100;
private volatile String host;
private volatile int port;
private volatile TcpListener listener;
private volatile TcpSender sender;
private volatile int soTimeout = -1;
private volatile int soSendBufferSize;
private volatile int soReceiveBufferSize;
private volatile boolean soTcpNoDelay;
private volatile int soLinger = -1; // don't set by default
private volatile boolean soKeepAlive;
private volatile int soTrafficClass = -1; // don't set by default
private volatile Executor taskExecutor;
private volatile boolean privateExecutor;
private volatile Deserializer<?> deserializer = new ByteArrayCrLfSerializer();
private volatile boolean deserializerSet;
private volatile Serializer<?> serializer = new ByteArrayCrLfSerializer();
private volatile TcpMessageMapper mapper = new TcpMessageMapper();
private volatile boolean mapperSet;
private volatile boolean singleUse;
private volatile boolean active;
private volatile TcpConnectionInterceptorFactoryChain interceptorFactoryChain;
private volatile boolean lookupHost = true;
protected final Object lifecycleMonitor = new Object(); // NOSONAR final
private final Map<String, TcpConnectionSupport> connections = new ConcurrentHashMap<String, TcpConnectionSupport>();
private volatile TcpSocketSupport tcpSocketSupport = new DefaultTcpSocketSupport();
protected final Object lifecycleMonitor = new Object();
private volatile long nextCheckForClosedNioConnections;
private volatile int nioHarvestInterval = DEFAULT_NIO_HARVEST_INTERVAL;
private volatile ApplicationEventPublisher applicationEventPublisher;
private final BlockingQueue<PendingIO> delayedReads = new LinkedBlockingQueue<AbstractConnectionFactory.PendingIO>();
private volatile long readDelay = DEFAULT_READ_DELAY;
private String host;
private volatile Integer sslHandshakeTimeout;
private int port;
private TcpListener listener;
private TcpSender sender;
private int soTimeout = -1;
private int soSendBufferSize;
private int soReceiveBufferSize;
private boolean soTcpNoDelay;
private int soLinger = -1; // don't set by default
private boolean soKeepAlive;
private int soTrafficClass = -1; // don't set by default
private Executor taskExecutor;
private boolean privateExecutor;
private Deserializer<?> deserializer = new ByteArrayCrLfSerializer();
private boolean deserializerSet;
private Serializer<?> serializer = new ByteArrayCrLfSerializer();
private TcpMessageMapper mapper = new TcpMessageMapper();
private boolean mapperSet;
private boolean singleUse;
private TcpConnectionInterceptorFactoryChain interceptorFactoryChain;
private boolean lookupHost = true;
private TcpSocketSupport tcpSocketSupport = new DefaultTcpSocketSupport();
private long nextCheckForClosedNioConnections;
private int nioHarvestInterval = DEFAULT_NIO_HARVEST_INTERVAL;
private ApplicationEventPublisher applicationEventPublisher;
private long readDelay = DEFAULT_READ_DELAY;
private Integer sslHandshakeTimeout;
private volatile boolean active;
public AbstractConnectionFactory(int port) {
this.port = port;
@@ -504,6 +504,10 @@ public abstract class AbstractConnectionFactory extends IntegrationObjectSupport
this.readDelay = readDelay;
}
protected Object getLifecycleMonitor() {
return this.lifecycleMonitor;
}
@Override
protected void onInit() {
super.onInit();

View File

@@ -52,7 +52,7 @@ import org.springframework.util.Assert;
*/
public abstract class TcpConnectionSupport implements TcpConnection {
protected final Log logger = LogFactory.getLog(this.getClass());
protected final Log logger = LogFactory.getLog(this.getClass()); // NOSONAR final
private final CountDownLatch listenerRegisteredLatch = new CountDownLatch(1);
@@ -69,28 +69,28 @@ public abstract class TcpConnectionSupport implements TcpConnection {
private final SocketInfo socketInfo;
@SuppressWarnings("rawtypes")
private volatile Deserializer deserializer;
private Deserializer deserializer;
@SuppressWarnings("rawtypes")
private volatile Serializer serializer;
private Serializer serializer;
private volatile TcpMessageMapper mapper;
private TcpMessageMapper mapper;
private volatile TcpListener listener;
private TcpListener listener;
private volatile TcpSender sender;
private TcpSender sender;
private volatile String connectionId;
private String connectionId;
private volatile String hostName = "unknown";
private String hostName = "unknown";
private volatile String hostAddress = "unknown";
private String hostAddress = "unknown";
private volatile String connectionFactoryName = "unknown";
private String connectionFactoryName = "unknown";
private volatile boolean noReadErrorOnClose;
private boolean noReadErrorOnClose;
private volatile boolean manualListenerRegistration;
private boolean manualListenerRegistration;
public TcpConnectionSupport() {
this(null);

View File

@@ -65,21 +65,21 @@ public class TcpMessageMapper implements
OutboundMessageMapper<Object>,
BeanFactoryAware {
protected final Log logger = LogFactory.getLog(this.getClass());
protected final Log logger = LogFactory.getLog(this.getClass()); // NOSONAR final
private volatile String charset = "UTF-8";
private String charset = "UTF-8";
private volatile boolean stringToBytes = true;
private boolean stringToBytes = true;
private volatile boolean applySequence = false;
private boolean applySequence = false;
private volatile MessageBuilderFactory messageBuilderFactory = new DefaultMessageBuilderFactory();
private MessageBuilderFactory messageBuilderFactory = new DefaultMessageBuilderFactory();
private volatile boolean messageBuilderFactorySet;
private boolean messageBuilderFactorySet;
private volatile String contentType = "application/octet-stream;charset=" + this.charset;
private String contentType = "application/octet-stream;charset=" + this.charset;
private volatile boolean addContentTypeHeader;
private boolean addContentTypeHeader;
private BeanFactory beanFactory;