From 0dcbde06426c44ef8f34052c7b3bbc7f885f8a3f Mon Sep 17 00:00:00 2001
From: Steve Singer <steve@ssinger.info>
Date: Thu, 12 Jul 2018 17:52:23 -0400
Subject: [PATCH] INT-4500: Fix DefAmqpHeaderMapper correlationId

JIRA https://jira.spring.io/browse/INT-4500

The `correlationId` condition was against a `contentType` by mistake

* Code style polishing, add `@author`
---
 .../amqp/support/DefaultAmqpHeaderMapper.java    |  6 ++++--
 .../support/DefaultAmqpHeaderMapperTests.java    | 16 ++++++++++++++++
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/spring-integration-amqp/src/main/java/org/springframework/integration/amqp/support/DefaultAmqpHeaderMapper.java b/spring-integration-amqp/src/main/java/org/springframework/integration/amqp/support/DefaultAmqpHeaderMapper.java
index 1bcf174fc5..28e7df3749 100644
--- a/spring-integration-amqp/src/main/java/org/springframework/integration/amqp/support/DefaultAmqpHeaderMapper.java
+++ b/spring-integration-amqp/src/main/java/org/springframework/integration/amqp/support/DefaultAmqpHeaderMapper.java
@@ -53,11 +53,13 @@ import org.springframework.util.StringUtils;
  * @author Gary Russell
  * @author Artem Bilan
  * @author Stephane Nicoll
+ * @author Steve Singer
+ *
  * @since 2.1
  */
 public class DefaultAmqpHeaderMapper extends AbstractHeaderMapper<MessageProperties> implements AmqpHeaderMapper {
 
-	private static final List<String> STANDARD_HEADER_NAMES = new ArrayList<String>();
+	private static final List<String> STANDARD_HEADER_NAMES = new ArrayList<>();
 
 	static {
 		STANDARD_HEADER_NAMES.add(AmqpHeaders.APP_ID);
@@ -126,7 +128,7 @@ public class DefaultAmqpHeaderMapper extends AbstractHeaderMapper<MessagePropert
 				headers.put(AmqpHeaders.CONTENT_TYPE, contentType);
 			}
 			String correlationId = amqpMessageProperties.getCorrelationId();
-			if (StringUtils.hasText(contentType)) {
+			if (StringUtils.hasText(correlationId)) {
 				headers.put(AmqpHeaders.CORRELATION_ID, correlationId);
 			}
 			MessageDeliveryMode receivedDeliveryMode = amqpMessageProperties.getReceivedDeliveryMode();
diff --git a/spring-integration-amqp/src/test/java/org/springframework/integration/amqp/support/DefaultAmqpHeaderMapperTests.java b/spring-integration-amqp/src/test/java/org/springframework/integration/amqp/support/DefaultAmqpHeaderMapperTests.java
index 0615c89531..2656790dc8 100644
--- a/spring-integration-amqp/src/test/java/org/springframework/integration/amqp/support/DefaultAmqpHeaderMapperTests.java
+++ b/spring-integration-amqp/src/test/java/org/springframework/integration/amqp/support/DefaultAmqpHeaderMapperTests.java
@@ -48,6 +48,8 @@ import org.springframework.util.MimeTypeUtils;
  * @author Oleg Zhurakousky
  * @author Stephane Nicoll
  * @author Artem Bilan
+ * @author Steve Singer
+ *
  * @since 2.1
  */
 public class DefaultAmqpHeaderMapperTests {
@@ -213,6 +215,20 @@ public class DefaultAmqpHeaderMapperTests {
 		assertEquals("test.replyTo2", headerMap.get(AmqpHeaders.SPRING_REPLY_TO_STACK));
 	}
 
+	@Test
+	public void toHeadersNonContenType() {
+		DefaultAmqpHeaderMapper headerMapper = DefaultAmqpHeaderMapper.inboundMapper();
+		MessageProperties amqpProperties = new MessageProperties();
+		amqpProperties.setAppId("test.appId");
+		amqpProperties.setClusterId("test.clusterId");
+		amqpProperties.setContentType(null);
+		String testCorrelationId = "foo";
+		amqpProperties.setCorrelationId(testCorrelationId);
+		Map<String, Object> headerMap = headerMapper.toHeadersFromReply(amqpProperties);
+		assertEquals(testCorrelationId, headerMap.get(AmqpHeaders.CORRELATION_ID));
+	}
+
+
 	@Test
 	public void testToHeadersConsumerMetadata() {
 		DefaultAmqpHeaderMapper headerMapper = DefaultAmqpHeaderMapper.inboundMapper();