Spring/spring-integration
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Sonar Fixes

Browse Source 
- avoid parameter assignments
This commit is contained in:
Gary Russell
2019-01-04 13:20:17 -05:00
committed by Artem Bilan
parent 76439e3440
commit 1bafe89d49
29 changed files with 236 additions and 163 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
spring-integration-websocket/src/main/java/org/springframework/integration/websocket/IntegrationWebSocketContainer.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2014-2016 the original author or authors.
* Copyright 2014-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -51,6 +51,7 @@ import org.springframework.web.socket.handler.ConcurrentWebSocketSessionDecorato
* have a precedent.
*
* @author Artem Bilan
* @author Gary Russell
* @since 4.1
* @see org.springframework.integration.websocket.inbound.WebSocketInboundChannelAdapter
* @see org.springframework.integration.websocket.outbound.WebSocketOutboundMessageHandler
@@ -158,8 +159,8 @@ public abstract class IntegrationWebSocketContainer implements DisposableBean {
}
@Override
public void afterConnectionEstablished(WebSocketSession session) throws Exception {
session = new ConcurrentWebSocketSessionDecorator(session,
public void afterConnectionEstablished(WebSocketSession sessionToDecorate) throws Exception { // NOSONAR SF ifce
WebSocketSession session = new ConcurrentWebSocketSessionDecorator(sessionToDecorate,
IntegrationWebSocketContainer.this.sendTimeLimit,
IntegrationWebSocketContainer.this.sendBufferSizeLimit);

9
spring-integration-websocket/src/main/java/org/springframework/integration/websocket/support/ClientStompEncoder.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2017 the original author or authors.
* Copyright 2017-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -30,6 +30,7 @@ import org.springframework.messaging.simp.stomp.StompHeaderAccessor;
* {@link org.springframework.web.socket.messaging.StompSubProtocolHandler}.
*
* @author Artem Bilan
* @author Gary Russell
*
* @since 4.3.13
*/
@@ -40,9 +41,11 @@ public class ClientStompEncoder extends StompEncoder {
if (StompCommand.MESSAGE.equals(headers.get("stompCommand"))) {
StompHeaderAccessor stompHeaderAccessor = StompHeaderAccessor.create(StompCommand.SEND);
stompHeaderAccessor.copyHeadersIfAbsent(headers);
headers = stompHeaderAccessor.getMessageHeaders();
return super.encode(stompHeaderAccessor.getMessageHeaders(), payload);
}
else {
return super.encode(headers, payload);
}
return super.encode(headers, payload);
}
}